Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qXwbM-000OHB-Qs for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Aug 2023 04:33:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qXwbL-002JiN-Mv for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Aug 2023 04:33:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qXwbL-002JiF-Az for pgadmin-hackers@lists.postgresql.org; Mon, 21 Aug 2023 04:33:15 +0000 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qXwbH-0005Fk-7x for pgadmin-hackers@postgresql.org; Mon, 21 Aug 2023 04:33:13 +0000 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-590685a3be5so11769937b3.0 for ; Sun, 20 Aug 2023 21:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1692592390; x=1693197190; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PwUHuFVLP0SsY89zKpAC2bRQIn9mtJ5YqNcxgMxDIDM=; b=j6Mu7+07lJ9ZErUq5vmpY9Je2mbUbI5fD7DJBtO22bl4gQVVsfuSlTBQcNP+Gmiscz E8Omq6P5nVsdDRWe+Ev7a99WPjcBqtdTXp8+n+EXrVhYUsFENmmXHQckVv7iZKsiOZyO IOx9wsXM3wpJuwq48JPuhE3t6aY99D6mOsMjPUHyqhqFmC4ZgeqnKJDQLNE0Lyr4aHLj apX6UPfoe39V+fUUXIsIuxJugsDqcBDA/ciIZHv5joPmOHwXIbObM+jnedBYPcYIkk5k 7qdRsZ1rLLL2uDbjVwmo2OTd1xOZ+tp2JzRACFqFkhLtNPfMQQV4eG89nYP7/Fv5tpdS VyoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692592390; x=1693197190; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PwUHuFVLP0SsY89zKpAC2bRQIn9mtJ5YqNcxgMxDIDM=; b=l2PQZbHpXICiyIrKi7vBKK11NG6SpFeutxkZxfIjPJ3F1xRAdaEo5kjobM+FgVqJfB 8ewRykgiLu9Qnl/6dPqDhAoN20VO72X+B6u40MP44Q0oIulALz3nGrZfoVH+NB/Cjtj5 Emrg+gRPcGpYZnha2quOkWxfdyF5eEiR7yfCuhslEgvy4dKr1agejesxXNcJ03JD+IZE qZ7D0ULoRvrLTY95masbrqNvHOZHdBSG/PR6tjczwm8ZPa3LbS4xOikq9VmwR8YX8YBp o8U2YQRjRanyXfk7xSyKhDEELztka3eNCyqS4gKKUdjX8VAyARK4x1a4Uo3Hl+LV2R4D 35wg== X-Gm-Message-State: AOJu0YzwRcWcOTsEos8NM+VDOZngoEuBgie6DZuto+m2b3npSxW4rW4n tm8dNhxqBgu3NVYG8ztGcCYCoQfJoVEXsMmHGpk0Dg== X-Google-Smtp-Source: AGHT+IF0mMY1QJOqXs+fskK+wx0er2WsvIZfUw7deS8HKAhdfBpctqqzCuW9qW5g9BnPIBhTh1SCRzbUHTxz+Rcu2fw= X-Received: by 2002:a25:d487:0:b0:d72:a54d:4b7 with SMTP id m129-20020a25d487000000b00d72a54d04b7mr6223488ybf.1.1692592390408; Sun, 20 Aug 2023 21:33:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Mon, 21 Aug 2023 10:02:59 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Sahil Harpal Cc: pgadmin-hackers@postgresql.org, Dave Page , Aditya Toshniwal , Akshay Joshi , Ashesh Vashi Content-Type: multipart/alternative; boundary="0000000000002e2a9306036760b9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000002e2a9306036760b9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sahil, once the issues get resolved, please raise the PR and we will do the final review there. On Mon, Aug 21, 2023 at 9:59=E2=80=AFAM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Sat, Aug 19, 2023 at 4:21=E2=80=AFPM Sahil Harpal > wrote: > >> On Thu, 10 Aug 2023 at 00:37, Sahil Harpal >> wrote: >> >>> Pending Work: >>> >>> 1. Process information - >>> - Issue: The pg_sys_process_info() query takes much longer (more >>> than 2 mins) to execute and prevents the updation of other graphs= and >>> tables. >>> >>> This may happen on Windows, can you try to fetch these details > separately (not combining with other charts) only for Windows? > >> >>> 1. Disk information - >>> - Issue: The pg_sys_disk_info() query returns NULL value for some >>> of the drive letters. >>> >>> If it returns NULL then do not show anything for that field for > particular Disk. > >> >>> 1. StreamingChart - >>> - Issue: Graph shifting glitch. For the first time, graphs start >>> from the opposite side, and after the following API call or a few= seconds >>> later, those get adjusted. >>> >>> I need suggestions for labels for different tables and charts. Also, >>> could you please clarify the use of the counterData variable, which is = used >>> for some of the charts (tps_stats, ti_stats, to_stats, and bio_stats)? >>> >> >> Could you please help me with these blockers and doubts? >> >> Thank you, >> Sahil >> > --0000000000002e2a9306036760b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sahil, once the issues get resolved, please raise the PR a= nd we will do the final review there.

<= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Aug 21, 2023 at 9:59=E2=80=AFA= M Khushboo Vashi <khu= shboo.vashi@enterprisedb.com> wrote:

On Sat, A= ug 19, 2023 at 4:21=E2=80=AFPM Sahil Harpal <sahilharpal1234@gmail.com> wrote= :
3D""
On Thu, 10 Aug 2023 at 00:37, Sahil Har= pal <sahi= lharpal1234@gmail.com> wrote:
Pending Wo= rk:
  1. Process information -
    • Issue: The pg_sys_process= _info() query takes much longer (more than 2 mins) to execute and prevents = the updation of other graphs and tables.=C2=A0
This may happen on Windows, = can you try to fetch these details separately (not combining with other=C2= =A0charts) only for Windows?
    Disk information -
    • Issue: The=C2=A0pg_sys_disk_info() query r= eturns NULL value for some of the drive letters.
=
If it returns=C2=A0NULL th= en do not show anything=C2=A0for that field for particular Disk.
  1. StreamingChart -=C2=A0
    • Issu= e: Graph shifting=C2=A0glitc= h.=C2=A0For the first time, graphs start from the opposite side, and= after the following API call or a few seconds later, those get adjusted.
I need suggestions for labels for different tables and ch= arts. Also, could you please clarify the use of the counterData variable, w= hich is used for some of the charts (tps_stats, ti_stats, to_stats, and bio= _stats)?

Could you please= help me with these blockers and=C2=A0doubts?

Thank you= ,
Sahil
--0000000000002e2a9306036760b9--