Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnyx9-0000pQ-0W for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 Jul 2019 05:27:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hnyx7-0002H5-PJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 Jul 2019 05:27:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnyx7-0002FQ-CN for pgadmin-hackers@lists.postgresql.org; Thu, 18 Jul 2019 05:27:37 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnyx4-00029t-7O for pgadmin-hackers@postgresql.org; Thu, 18 Jul 2019 05:27:36 +0000 Received: by mail-ot1-x331.google.com with SMTP id o101so27665346ota.8 for ; Wed, 17 Jul 2019 22:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6r8f436HbA6D3tIdC89hI/L0O7MbueMQ/AkDIglNpic=; b=lgeZ5AHDK/mKcT23fbmsT0TIBfuLfbuv9CV3j03bb+HbTVknwUPRjyQr8qdEoezMIN YBOGdAC9wrzzkO+McyFsDou29KFhkAcEADsEgJLgt0mV1Y8EzCvjqr0uNe2pYnOkYjuT JeQJ1y/T86Bm2fklkGNFgL89uigqA6g94RmmO1uDHG6+dtGXMNE12dilq9G0AvxboYmi J7CRvklAtypI7dEEhGgCahzg/D/5BZvGzPGHChgXJWlrc/DnDyYi5npSywHG5+a6gjUB FFfX3NZ6+NS8r/ga12BpsUHjYwy6tnAwmXenKiEFBWQ/1ReC/NkqIqOUg03aYzTmZoLn 5rNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6r8f436HbA6D3tIdC89hI/L0O7MbueMQ/AkDIglNpic=; b=ijPGL/Jwa1B7ji9HF9hWWKrPjAneK0P48hjaKX/FAww/GHmtnzTVpNqw2BdAejKd0/ PGeQ3WRNvX7t+z6M0dXSEFaGDbDEoiWy3+MZS/iSz3H5xN4E25XZJDIH+gwjwiZsc6z9 rBcBmn62tngYP7lZqtYpur6Fx9ox+ennfZGNLsxMqo16hxP3jEmk+1PFLZTWfBeochzT PG3bwGhGFSDm7fQ+pMD6QKtcKKEJ32hMgOSSOIxp5grcBT6qvbDApapAYcPrPfgUA4wg MT646gWpFyJYLstQ/iN6xJrtRl433gOr1Pz++AfhTJAXDsaZDyzd6GFQwl/tQnnwgnKQ J4Mg== X-Gm-Message-State: APjAAAWVrSl8szbGU4ui0ewPKDTFasr4YI8KiLXY3VRv8IdD+QtD7Qlu +tje+a6RaJ7yhqLIwzwePmxCJEOherVjIx0RCVcSFg== X-Google-Smtp-Source: APXvYqwZvIQokXp0HAWGubmhiOxuvx6Pe539NeJDYgoiDakGPp45+CjWY70asPHpG/70FvX/zywMkgqLBxcXWSW7YlY= X-Received: by 2002:a9d:5787:: with SMTP id q7mr33819981oth.75.1563427651134; Wed, 17 Jul 2019 22:27:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Thu, 18 Jul 2019 10:57:21 +0530 Message-ID: Subject: Re: Bug in Database Nodes in the Tree To: Yosry Muhammad Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c7355a058dedddd6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c7355a058dedddd6 Content-Type: text/plain; charset="UTF-8" Hi Yosry, On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad wrote: > Hi Khushboo, > > There's a minor bug that I noticed a while back that when you right click > a disconnected database (to drop it for example) it automatically connects > to the database and expands the node. This behaviour is a little annoying > to users (me too), I am trying to fix it. > > This behavior is by design as we have considered some of the pgAdmin III behavior. One behavior we can change is that on the selection of the database node, we can just connect it and not expand it and when we expand the database node (by arrow icon or double click), we can connect and expand both. We need Dave's approval to change this. I looked around the code in the browser module (node.js, database.js, > menu.js) and I couldn't find a way to modify this behaviour. Is this > handled internally by jQuery? Is modifying this behaviour feasible? > > I think the problem is that the right click event triggers the left event > click too. Am I correct? > > Basically, the browser tree is generated through the aciTree library, so when required, the public APIs (provided by aciTree) of the events are being called. In this case, on the selection of the database node, the selected event is used in the database.js file. Thanks, Khushboo Thanks! > --000000000000c7355a058dedddd6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Yosry,

On Wed, Jul 17, 2019 at 10:49 PM= Yosry Muhammad <yosrym93@gmail.co= m> wrote:
Hi Khushboo,

There's a minor bug that I noticed a while back that when you right c= lick a disconnected database (to drop it for example) it automatically conn= ects to the database and expands the node. This behaviour is a little annoy= ing to users (me too), I am trying to fix it.

This behavior is by design as we have considere= d some of the pgAdmin III=C2=A0behavior. One behavior we can change is that= on the selection of the database node, we can just connect it and not expa= nd it and when we expand the database node (by arrow icon or double click),= we can connect and expand both.

We need Dave'= s approval to change this.

I looked around the code in the browser module (node.js, database.js= , menu.js) and I couldn't find a way to modify this behaviour. Is this = handled internally by jQuery? Is modifying this behaviour feasible?
=C2=A0
I think the problem is that the right click event triggers the l= eft event click too. Am I correct?

<= /blockquote>
Basically, the browser tree is generated through the aciTr= ee library, so when required, the public APIs (provided by aciTree) of the = events are being called.
In this case, on the selection of the da= tabase node, the selected event is used in the database.js file.
=
Thanks,
Khushboo

Thanks!
--000000000000c7355a058dedddd6--