Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aidCQ-00068K-PV for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Mar 2016 07:27:26 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aidCQ-00066p-CW for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Mar 2016 07:27:26 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aidCC-0005kJ-C6 for pgadmin-hackers@postgresql.org; Wed, 23 Mar 2016 07:27:12 +0000 Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aidC9-0001Rn-9g for pgadmin-hackers@postgresql.org; Wed, 23 Mar 2016 07:27:11 +0000 Received: by mail-lf0-x22b.google.com with SMTP id d82so4636787lfe.3 for ; Wed, 23 Mar 2016 00:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=P1suSsk+Y0rdrKch/+XLkhb6f6BqY1QbLcQKCfSl3pg=; b=bUrPKTzqA+n03rkssoB63STmxTw85cAdBwFsnARn3UBbs762EFAq98+CPOrNfZJeuM hFuO3Z+dKfvDwJ/KDpYDoULJRma46wtNYFwaNqG60P3OKsUo5AmHgt6AeZ+HAAVqNhab +uxorIRS9sLtHqGBum5af4TZQ9fH9S8quLEJLW7GI+g9fhBO4/CfPtYEQAsCusVZypFR YceEHYloA3QHFKboNAwzWkDKrEn+emPjaWHc1WW+aJ/K8+3vEYtqfyrczQSHkxDGHxCR PNAdclmoMgu4KkewbtYZB1hvM7pB5RV9pvtXQ9T1OB0QWYEdR+gBYNa3skosIxg0CTDx aDIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=P1suSsk+Y0rdrKch/+XLkhb6f6BqY1QbLcQKCfSl3pg=; b=mUxDN4OWS7/IGSF8DmvuL11n0ej0bLMeEwhRvopgrIiT0RrXZFGzqbOYRBfP6IpW6l nRioG9ZUDULEcHjxO2AqkUxwhOOWrEHEphsoGSDJtT4FrFjuLRs+b2T0Fzr6xwD9I78V +PxgAx7sWJLba+rYHq2FhU1enb5RgifwFilnT+U9k/gSGSeBAgM+2eiBmzvWacjShGrC Fn/p8rzrBi1AVm4CmVbmlmQwLJqxQkSTIlt8+5v5Lg18VgcK+/9qLaxgiVan6g/qONAy NmHvI7jkfDPRHb1vH7qoSg+raXJQMSGCvWF3w4lmDILgDDbXM2P13FpkWfUSSJ8pW006 iXJw== X-Gm-Message-State: AD7BkJKFb4fzaHHWFaTfX2BAuEdJGPcMEg1UeM9d27i+sNEw6iBBGPC/KkFFzZiFVy5py3PIgQjvN5/xtJPAc1OL MIME-Version: 1.0 X-Received: by 10.25.25.84 with SMTP id 81mr510500lfz.71.1458718027326; Wed, 23 Mar 2016 00:27:07 -0700 (PDT) Received: by 10.25.159.85 with HTTP; Wed, 23 Mar 2016 00:27:07 -0700 (PDT) In-Reply-To: References: Date: Wed, 23 Mar 2016 12:57:07 +0530 Message-ID: Subject: Re: pgAdmin4 PATCH: Domain Module From: Khushboo Vashi To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11471f86d8bc26052eb24126 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11471f86d8bc26052eb24126 Content-Type: text/plain; charset=UTF-8 Updated one comment. On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch for the Domains module. > > On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote: > >> Hi >> >> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi >> wrote: >> > Hi, >> > >> > Please find the updated Domain Module Patch. >> > >> > To test this patch, please apply Backgrid Textarea Cell Patch before >> this. >> >> Thanks. I believe with the following fixes, we'll be done :-) >> >> - Default values should be auto-quoted when necessary (ie. strings, on >> a text-based domain). >> > As per our discussion, this should leave unquoted. > And also added a hint to the field stated 'Enter an expression or a value.' > > - "System Domain?" should be in the General section, between owner and >> comment. >> > Done > >> - The switches should use the same colouring/styling as other objects, >> e.g. >> >> options: { >> 'onText': 'Yes', 'offText': 'No', >> 'onColor': 'success', 'offColor': 'primary', >> 'size': 'small' >> } >> > Done > >> - Please remove the Schema property from the main properties tab (not >> the properties dialogue). >> > Done > >> - No icon is show for Checks on the Dependents tab for a domain. >> > Done > >> - The add button on the Security Labels tab is spelt "Add". Why is >> that? Other instances of this grid use "ADD" which is the default in >> backform.pgadmin.js. >> > Done > >> - Dependencies on domain check constraints are listed as being on a >> "Type" not a "Domain". >> > Done > >> - If adding a domain constraint using the grid on the Domain dialogue, >> I cannot specify "NOT VALID". We need a checkbox for that in a narrow >> columns at the end. Unchecking it for an existing constraint should be >> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT" >> > Done > >> - If I switch the "Don't Validate" switch on a constraint, there are >> leading blank lines in the generated SQL. The same occurs when adding >> a comment to a constraint. >> > Done > >> - I think we need to reverse the meaning of "Don't Validate" and >> rename to match the "Valid?" field that's on the properties list. >> Otherwise it's not clear they're the same thing. >> > Done > >> - s/Not Null/Not Null?/ >> > Done > >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a11471f86d8bc26052eb24126 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Updated one comment.
On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vas= hi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Plea= se find attached updated patch for the Domains module.

On Wed, Mar 16, 2= 016 at 9:40 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
<kh= ushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the updated Domain Module Patch.
>
> To test this patch, please apply Backgrid Textarea Cell Patch before t= his.

Thanks. I believe with the following fixes, we'll be done :-)
- Default values should be auto-quoted when necessary (ie. strings, on
a text-based domain).
As per our discussion, this should leave unquoted.
A= nd also added a hint to the field stated 'Enter an expression or a valu= e.'

- "System Domain?" should be in the General section, between owne= r and comment.
Done
- The switches should use the same colouring/styling as other objects, e.g.=

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 options: {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'onText': 'Yes', = 'offText': 'No',
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'onColor': 'success&#= 39;, 'offColor': 'primary',
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'size': 'small' =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
Done=C2=A0
- Please remove the Schema property from the main properties tab (not
the properties dialogue).
Done=C2=A0
- No icon is show for Checks on the Dependents tab for a domain.
Done=C2=A0
- The add button on the Security Labels tab is spelt "Add". Why i= s
that? Other instances of this grid use "ADD" which is the default= in
backform.pgadmin.js.
Done
- Dependencies on domain check constraints are listed as being on a
"Type" not a "Domain".
Done
- If adding a domain constraint using the grid on the Domain dialogue,
I cannot specify "NOT VALID". We need a checkbox for that in a na= rrow
columns at the end. Unchecking it for an existing constraint should be
the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
Done =
Done
- I think we need to reverse the meaning of "Don't Validate" = and
rename to match the "Valid?" field that's on the properties l= ist.
Otherwise it's not clear they're the same thing.
Done
- s/Not Null/Not Null?/
Done


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a11471f86d8bc26052eb24126--