public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view
Date: Tue, 24 Mar 2020 13:47:37 +0530
Message-ID: <CAFOhELeDDEVtAFNE1FjiUEtu7TqFzUFxwi4DysfqvT8AsS6TDg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdfJGOASsQVknwHkbk+L4zWP5UdWjPZBsVqtg8hL6-SfA@mail.gmail.com>
References: <CAFOhELdGhQ1O2R+GLgNj_jbOtUduDt=rsNvwUdwmxeUxAmes6Q@mail.gmail.com>
	<CANxoLDdfJGOASsQVknwHkbk+L4zWP5UdWjPZBsVqtg8hL6-SfA@mail.gmail.com>

Hi Akshay,

On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi <[email protected]>
wrote:

> Hi Khushboo
>
> Following are the review comments:
>
>    - Fix the PEP8 issue.
>    - Drop query should be part of the jinja template for consistency.
>    Currently, it is added through the python file.
>
> The Delete query is already in the template file, I have just reused the
delete call and merged the SQL queries in the python file.

>
>    - Any changes in the view code should not warn the user "Changing the
>    columns in a view requires dropping...." and we should not drop the view.
>    For example, I have only change the WHERE clause or added 'ORDER BY'.
>
> I have tested but  couldn't reproduce this issue.  Can you please let me
know the proper use case?

Thanks,
Khushboo

>
>

> On Tue, Jan 14, 2020 at 10:27 AM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the attached patch for RM #5053 - Getting an error while
>> changing the columns in the existing view.
>>
>> PostgreSQL doesn't allow to change the view columns. So, while performing
>> this task the existing view should be dropped first and then recreate it
>> and also user will get a warning first.
>>
>> Thanks,
>> Khushboo
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view
  In-Reply-To: <CAFOhELeDDEVtAFNE1FjiUEtu7TqFzUFxwi4DysfqvT8AsS6TDg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox