public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Collection Control Fixes
Date: Mon, 28 Mar 2016 14:52:55 +0530
Message-ID: <CAFOhELeFaDKGiPpQsuWvAaGFEF_X3srpx7a8duaQq+gNGjOmLg@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Please find attached patch to fix below issues in the Collection Control:

1> Unique Collection Control:
Couldn't listen Change event
2> Subnode Collection Control:
Add button Label was not in Upper case

First Issue was reported by Murtuza.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_collection_control_fixes.patch (1.2K, 3-pgAdmin4_collection_control_fixes.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 60a93ac..e30a278 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -899,7 +899,7 @@
     },
     render: function() {
       // Clean up existing elements
-      this.cleanup();
+      this.undelegateEvents();
 
       var field = _.defaults(this.field.toJSON(), this.defaults),
           attributes = this.model.toJSON(),
@@ -945,6 +945,7 @@
       this.$el.html(grid).addClass(field.name);
       this.updateInvalid();
 
+      this.delegateEvents();
       return this;
     },
     showGridControl: function(data) {
@@ -1169,7 +1170,7 @@
     showGridControl: function(data) {
       var gridHeader = ["<div class='subnode-header'>",
           "  <label class='control-label col-sm-4'>" + data.label + "</label>" ,
-          "  <button class='btn-sm btn-default add'>Add</buttton>",
+          "  <button class='btn-sm btn-default add'>ADD</buttton>",
           "</div>"].join("\n");
         gridBody = $("<div class='pgadmin-control-group backgrid form-group col-xs-12 object subnode'></div>").append(gridHeader);
 

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: Collection Control Fixes
  In-Reply-To: <CAFOhELeFaDKGiPpQsuWvAaGFEF_X3srpx7a8duaQq+gNGjOmLg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox