public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Patch] RM 3899 - Unable to Drop Rules for table and foreign table through properties section
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Patch] RM 3899 - Unable to Drop Rules for table and foreign table through properties section
@ 2019-01-31 06:15 Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Khushboo Vashi @ 2019-01-31 06:15 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
Please find the attached patch to fix the RM 3899 - Unable to Drop Rules
for table and foreign table through properties section.
Another minor issue fixed with this patch is - while adding/editing the
foreign table, the foreign server cache level has not getting updated that
has been fixed now.
Thanks,
Khushboo
Attachments:
[application/octet-stream] RM_3899.patch (2.1K, 3-RM_3899.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/static/js/foreign_table.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/static/js/foreign_table.js
index 57b3912e..168da53d 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/static/js/foreign_table.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/static/js/foreign_table.js
@@ -523,6 +523,7 @@ define('pgadmin.node.foreign_table', [
},
model: pgBrowser.Node.Model.extend({
+ idAttribute: 'oid',
initialize: function(attrs, args) {
var isNew = (_.size(attrs) === 0);
if (isNew) {
@@ -571,7 +572,8 @@ define('pgadmin.node.foreign_table', [
type: 'multiline',
},{
id: 'ftsrvname', label: gettext('Foreign server'), cell: 'string', control: 'node-ajax-options',
- type: 'text', group: gettext('Definition'), url: 'get_foreign_servers', disabled: function(m) { return !m.isNew(); },
+ type: 'text', group: gettext('Definition'), url: 'get_foreign_servers',
+ disabled: function(m) { return !m.isNew(); }, cache_node: 'database',
},{
id: 'inherits', label: gettext('Inherits'), group: gettext('Definition'),
type: 'array', min_version: 90500, control: NodeAjaxOptionsMultipleControl,
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/rules/static/js/rule.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/rules/static/js/rule.js
index 3016f042..1e3d0111 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/rules/static/js/rule.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/rules/static/js/rule.js
@@ -125,6 +125,7 @@ define('pgadmin.node.rule', [
properties of the model in schema.
*/
model: pgAdmin.Browser.Node.Model.extend({
+ idAttribute: 'oid',
schema: [{
id: 'name', label: gettext('Name'),
type: 'text', disabled: function(m) {
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][Patch] RM 3899 - Unable to Drop Rules for table and foreign table through properties section
@ 2019-01-31 07:34 Akshay Joshi <[email protected]>
parent: Khushboo Vashi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2019-01-31 07:34 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers
Thanks patch applied.
On Thu, Jan 31, 2019 at 11:46 AM Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> Please find the attached patch to fix the RM 3899 - Unable to Drop Rules
> for table and foreign table through properties section.
>
> Another minor issue fixed with this patch is - while adding/editing the
> foreign table, the foreign server cache level has not getting updated that
> has been fixed now.
>
> Thanks,
> Khushboo
>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-01-31 07:34 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31 06:15 [pgAdmin4][Patch] RM 3899 - Unable to Drop Rules for table and foreign table through properties section Khushboo Vashi <[email protected]>
2019-01-31 07:34 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox