Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSYje-0000XX-CH for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 06:26:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nSYjd-00087B-5r for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 06:26:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSYjc-000872-IU for pgadmin-hackers@lists.postgresql.org; Fri, 11 Mar 2022 06:26:44 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nSYjY-00025D-Je for pgadmin-hackers@postgresql.org; Fri, 11 Mar 2022 06:26:44 +0000 Received: by mail-lf1-x130.google.com with SMTP id bu29so13468842lfb.0 for ; Thu, 10 Mar 2022 22:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ReFID0arIRu6VvClhR2pepbSTluJ3YOefQONgR7gE00=; b=kv8KKtEmFLsLS29ZgcWp0O++ENE6DDO6H7y3SIyf2e5bas8sE9iuwjTU+3x0ojcbYq XRQoz52Qes9zpGAhVuOV1kzwiBX883y+Gun9unsIsOhwuXSA5bF2J+iiukBqtTK7x4x/ rTa6oIDs9AYHGwEh+Zb3ljUwthpidIdITKZj323gOTEjTrUv6p6U4V0EdAfAiBsz2EFD RzHjM4Qv/GNr3gSxI5FNu3GOBjEg710vZNsjc81JKALM4ePoiqbMSDuVZIbQfHsTCOhQ 5HT/EqaIS1x4VPJ/rxP+hrGDUUyrGJLiThd4JwV2j8J21T+glTXbNnsGFGTqQAsE3+nr S0Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ReFID0arIRu6VvClhR2pepbSTluJ3YOefQONgR7gE00=; b=AwCJSb/MmYproUYZQdlK+HCvKy7yJA4so4efoJTYLHJbxJle/klGfjocwf4C3jrlzV Dq1vDKVJhWMz6imSSZdbLGW330X2ouF+LRqNAcwwRdUvWk114ga2U2yGneAQKynMArWZ Utg69mHmDOJSKIniUqtqTcbYy8ihggW5MxYy8N/haTublRgq5ppWtTTl6nU72SzjFSM1 BCx9KfEgFq0d7+EWdCiZtvq797aX3Si9ctV9Ai/kHab3yscwAQcrsxBBJtP6HH+LrmBh As1+2dOELws9hK8F5rN9+ArstC0Su4DYFZGkbaJfHOfjLoFFJg4rCqChgPQsyDAoMRoP Ttxg== X-Gm-Message-State: AOAM533FmONHuKStEb6JJUCgo0p2qeiYadR1Lx+7H36yH/w5v+031Asq t9SeulPdveI4TnzSTpO1iNCURVElzgyNNud7An11JRkQ9H1k5qtSegBZroY42cggD8DMVH0yEPI z+XdOjyXVB2IADAVk/b9AaKO8ftMYv7mLitjWGfD2BuhGa41ugIi0uUFCZKMcYkPoK7iLDA8yWl WQR/RsMi8TqpCnvrRXnDxC6TmLiTlraAJl2AaS06Aq5P0Ejbw4SD3Sy/shIFkTFps= X-Google-Smtp-Source: ABdhPJw1HSrLxMdBXosYAAlhfmDYSSVI5Mk1t1tHGy5nnAOgyQSb1guCK1kLn4cZYBEqZPzlVb2D1mUUVH3p248GZY8= X-Received: by 2002:ac2:5229:0:b0:448:1bd5:35c7 with SMTP id i9-20020ac25229000000b004481bd535c7mr5097055lfl.520.1646979998256; Thu, 10 Mar 2022 22:26:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Fri, 11 Mar 2022 11:56:25 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment To: Akshay Joshi Cc: Yogesh Mahajan , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000bfa86105d9eb6931" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000bfa86105d9eb6931 Content-Type: text/plain; charset="UTF-8" One is for pgacloud standalone code for background process and one for pgadmin module. On Fri, 11 Mar 2022, 10:11 Akshay Joshi, wrote: > Hi Khushboo > > Why there are two identical functions (def get_my_ip) in two different > files, can you please make it generic in one place only and send the patch. > > On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan < > yogesh.mahajan@enterprisedb.com> wrote: > >> Hi, >> >> Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and >> IPv6 respectively. >> >> Thanks, >> Yogesh Mahajan >> EnterpriseDB >> >> >> On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the default Public IP range issue >>> in AWS deployment. >>> >>> @Yogesh Mahajan , please test. >>> >>> >>> Thanks, >>> Khushboo >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --000000000000bfa86105d9eb6931 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
One is for pgacloud standalone code for background proces= s and one for pgadmin module.

On Fri, 11 Mar 2022, 10:11 Akshay Joshi, <= akshay.joshi@enterprisedb.= com> wrote:
Hi Khushboo

Why there are two identical func= tions (def=C2=A0get_my_ip)=C2=A0in two different files, c= an you please make it generic in one place only and send the patch.

On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan <yogesh.ma= hajan@enterprisedb.com> wrote:
Hi,
Patch looks=C2=A0fine. IP Addresses are prefixed by 32 an= d 128 for IPv4 and IPv6 respectively.
=C2=A0
Thanks,
Yogesh Mahajan
EnterpriseDB


On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Pl= ease find the attached patch to fix the default Public IP range issue in AW= S deployment.

@Yogesh Mahajan, please test.

Thanks,
Khushboo


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Postgres
Mobile: +91 976-788-8246
<= br>
--000000000000bfa86105d9eb6931--