MIME-Version: 1.0
In-Reply-To: <20180702072255.GA12924@msg.df7cb.de>
References: 
 <CA+OCxow1BDDXK9K1d-pnSAoBE5O=+RD6QNxA5ynH-X+-rPN7jA@mail.gmail.com>
 <20180626192819.GA32582@msg.df7cb.de>
 <CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyXNsR84Xw@mail.gmail.com>
 <20180628114706.GB32048@msg.df7cb.de>
 <CA+OCxoyu6KQamBfgV2kF2uB2AYsty7HhyeSsvTa1yuTdANWimw@mail.gmail.com>
 <20180630161647.GC23723@msg.df7cb.de>
 <CAFOhELc2oFoN_ic3a6oW6nt-9W3=ADgczfZxdE9VjHcj1emL_Q@mail.gmail.com>
 <20180702072255.GA12924@msg.df7cb.de>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Mon, 2 Jul 2018 15:25:42 +0530
Message-ID: 
 <CAFOhELeTeg=On7t0wZqtyusQD-+fuTpFMuPkwbuM2ttiaH+PwA@mail.gmail.com>
Subject: Re: pgAdmin v3.1 candidate builds and source...
To: Christoph Berg <myon@debian.org>
Cc: Dave Page <dpage@pgadmin.org>,
 Syed Fahar Abbas <fahar.abbas@enterprisedb.com>,
	=?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= <devrim@gunduz.org>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000006573260570013326"
Precedence: bulk

--0000000000006573260570013326
Content-Type: text/plain; charset="UTF-8"

On Mon, Jul 2, 2018 at 12:52 PM, Christoph Berg <myon@debian.org> wrote:

> Re: Khushboo Vashi 2018-07-02 <CAFOhELc2oFoN_ic3a6oW6nt-9W3=
> ADgczfZxdE9VjHcj1emL_Q@mail.gmail.com>
> > > I could finally build the packages now. (There were some issues with
> > > the python3.7 update happening in Debian at the same time, which broke
> > > a few bits, but I managed to work around.)
> > >
> > > One user raised the same issue that pgAdmin is not working with python
> > 3.7. He found that the issue is with psycopg2 (Ref:
> > https://github.com/psycopg/psycopg2/issues/714) as async and await are
> now
> > keywords and we are using async in pgAdmin 4.
> >
> > So, I am curious to know how you have fixed this issue?
>
> Hi Khushboo,
>
> I simply postponed building the pgadmin4 packages for sid until the
> problem is fixed.
>
> pgadmin4 |      3.0-2.pgdg+1 |             sid-pgdg | amd64, i386,
> ppc64el, source
> pgadmin4 |   3.1-1.pgdg100+1 |          buster-pgdg | amd64, i386,
> ppc64el, source
> pgadmin4 |    3.1-1.pgdg90+1 |         stretch-pgdg | amd64, i386,
> ppc64el, source
> pgadmin4 | 3.1-1.pgdg18.04+1 |          bionic-pgdg | amd64, i386,
> ppc64el, source
> pgadmin4 | 3.1-1.pgdg16.04+1 |          xenial-pgdg | amd64, i386,
> ppc64el, source
>
> The fix from
> https://github.com/psycopg/psycopg2/issues/714#issuecomment-401570055
> looks promising, I'll probably apply that to psycopg2 in sid unless
> someone else is faster.
>
> Thanks for the explanation.
We also need some code changes in pgAdmin 4 to support python 3.7.

> Christoph
>

--0000000000006573260570013326
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Mon, Jul 2, 2018 at 12:52 PM, Christoph Berg <span dir=3D"ltr">&lt;<=
a href=3D"mailto:myon@debian.org" target=3D"_blank">myon@debian.org</a>&gt;=
</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .=
8ex;border-left:1px #ccc solid;padding-left:1ex">Re: Khushboo Vashi 2018-07=
-02 &lt;CAFOhELc2oFoN_ic3a6oW6nt-9W3=3D<a href=3D"mailto:ADgczfZxdE9VjHcj1e=
mL_Q@mail.gmail.com"><wbr>ADgczfZxdE9VjHcj1emL_Q@mail.<wbr>gmail.com</a>&gt=
;<br>
<span class=3D"">&gt; &gt; I could finally build the packages now. (There w=
ere some issues with<br>
&gt; &gt; the python3.7 update happening in Debian at the same time, which =
broke<br>
&gt; &gt; a few bits, but I managed to work around.)<br>
&gt; &gt;<br>
&gt; &gt; One user raised the same issue that pgAdmin is not working with p=
ython<br>
&gt; 3.7. He found that the issue is with psycopg2 (Ref:<br>
&gt; <a href=3D"https://github.com/psycopg/psycopg2/issues/714" rel=3D"nore=
ferrer" target=3D"_blank">https://github.com/psycopg/<wbr>psycopg2/issues/7=
14</a>) as async and await are now<br>
&gt; keywords and we are using async in pgAdmin 4.<br>
&gt; <br>
&gt; So, I am curious to know how you have fixed this issue?<br>
<br>
</span>Hi Khushboo,<br>
<br>
I simply postponed building the pgadmin4 packages for sid until the<br>
problem is fixed.<br>
<br>
pgadmin4 |=C2=A0 =C2=A0 =C2=A0 3.0-2.pgdg+1 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0sid-pgdg | amd64, i386, ppc64el, source<br>
pgadmin4 |=C2=A0 =C2=A03.1-1.pgdg100+1 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
buster-pgdg | amd64, i386, ppc64el, source<br>
pgadmin4 |=C2=A0 =C2=A0 3.1-1.pgdg90+1 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0s=
tretch-pgdg | amd64, i386, ppc64el, source<br>
pgadmin4 | 3.1-1.pgdg18.04+1 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bionic-pgd=
g | amd64, i386, ppc64el, source<br>
pgadmin4 | 3.1-1.pgdg16.04+1 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 xenial-pgd=
g | amd64, i386, ppc64el, source<br>
<br>
The fix from<br>
<a href=3D"https://github.com/psycopg/psycopg2/issues/714#issuecomment-4015=
70055" rel=3D"noreferrer" target=3D"_blank">https://github.com/psycopg/<wbr=
>psycopg2/issues/714#<wbr>issuecomment-401570055</a><br>
looks promising, I&#39;ll probably apply that to psycopg2 in sid unless<br>
someone else is faster.<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br></font></span></blockquo=
te><div>Thanks for the explanation.</div><div>We also need some code change=
s in pgAdmin 4 to support python 3.7.=C2=A0</div><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex"><span class=3D"HOEnZb"><font color=3D"#888888">
Christoph<br>
</font></span></blockquote></div><br></div></div>

--0000000000006573260570013326--