Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bv2XN-0002Zc-4P for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Oct 2016 13:28:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bv2XM-0005DR-K6 for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Oct 2016 13:28:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bv2X8-0004yU-Cu for pgadmin-hackers@postgresql.org; Fri, 14 Oct 2016 13:28:22 +0000 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bv2X1-0006sK-Ou for pgadmin-hackers@postgresql.org; Fri, 14 Oct 2016 13:28:21 +0000 Received: by mail-lf0-x234.google.com with SMTP id l131so153715741lfl.2 for ; Fri, 14 Oct 2016 06:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=vEn7GQMaX1lZ8NBIK5Viy+98u94Thalj4JZT67euNRY=; b=EiZeVDp8yfagL+UAlrHXrF1B9RYCSQIl8N7PWfeSsHmvQzcBzwEUyZ+23bYz5ygGE4 1xYwjJF5rW2lwKPqYi1yLf+C96p/7yqnogHvgRXCUig4M2PvFGBfJjHnjJyJsXq0WazA TjFHha3huAHL5ww4LxRReScKx71MljlyIrn8dQNi9SuBpvxxno0mcdOAo39t8Ce4fA50 VAndtFyHsPXJ4BpgXsMhSTlRIwkeWXtGlkTW99lLG7OJIlMNT+1aHmIoE9D4GFtontrl VomNG9/Z/7ctsUZhW9zkv/n2pUYkNP30eNww7g9pWGN01xvBBylQS5CZQH+69GMQb3xD ZsTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=vEn7GQMaX1lZ8NBIK5Viy+98u94Thalj4JZT67euNRY=; b=ky1LnpgqywAcxzlU6UTjxqO77S/ZKjHzXjmOBnXkH0JFMN6W+r1EF5Me0MSN3jEH79 lnxEDLgaRoZHHiKyVHOSNcZnMWAmPSZc+LLE+nOkBfOtJKH2O85QaJb0hW+wx5/dn1c6 E8NSipUF1omtVBgWl1RFXOUS2m7hwOY2+63fJbXOtAq1f6kw/3KCaWJiS37Mz8opGidW CCGWD3lHRThRSXbH4XBaxiEw/U7iruftqiytru5qY/umH/veOh90p4wL+/rwesWCeWo5 4cOafr6B2kkPHfW5JgQjhymOFOE3h4InrCj6v4NehVhO28ESceu2rWwvSNZEg139SCoE nkTA== X-Gm-Message-State: AA6/9RlRIDib+WJivmJFmW1bpD9W7V/mhYYcbcqnM6idto29J16uYO9JCUx3KWta5L4lxMnzvFzyFVcpV/7jYpls X-Received: by 10.25.35.6 with SMTP id j6mr3860239lfj.147.1476451692980; Fri, 14 Oct 2016 06:28:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.27.75 with HTTP; Fri, 14 Oct 2016 06:28:12 -0700 (PDT) From: Khushboo Vashi Date: Fri, 14 Oct 2016 18:58:12 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220 To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113ca762b06555053ed33247 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113ca762b06555053ed33247 Content-Type: multipart/alternative; boundary=001a113ca762b0654e053ed33245 --001a113ca762b0654e053ed33245 Content-Type: text/plain; charset=UTF-8 Hi, Please find the attached patch to fix the below 2 bugs. RM 1603: [Web Based] Export database failed if object contains double quotes. RM 1220: Backup database is not working with special characters The issues which were fixed: 1. Client side data were not unescaped 2. Required command line arguments were quoted twice Thanks, Khushboo --001a113ca762b0654e053ed33245 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please find the attached patch to f= ix the below 2 bugs.

RM 1603:=C2=A0[Web Based] Exp= ort database failed if object contains double quotes.
RM=C2=A0122= 0: Backup database is not working with special characters

The issues which were fixed:

1. Client sid= e data were not unescaped
2. Required command line arguments were= quoted twice=C2=A0

Thanks,
Khushboo

--001a113ca762b0654e053ed33245-- --001a113ca762b06555053ed33247 Content-Type: text/x-patch; charset=US-ASCII; name="RM_1603.patch" Content-Disposition: attachment; filename="RM_1603.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iu9t474p0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9fX2luaXRf Xy5weSBiL3dlYi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9fX2luaXRfXy5weQpp bmRleCA3NzFiM2ZmLi5hY2ZjNmUxIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1p bi90b29scy9iYWNrdXAvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4v dG9vbHMvYmFja3VwL19faW5pdF9fLnB5CkBAIC0yNzYsNyArMjc2LDcgQEAg ZGVmIGNyZWF0ZV9iYWNrdXBfam9iKHNpZCk6CiAgICAgICAgIHNlcnZlci51 c2VybmFtZSwKICAgICAgICAgJy0tbm8tcGFzc3dvcmQnLAogICAgICAgICAn LS1kYXRhYmFzZScsCi0gICAgICAgIGRyaXZlci5xdElkZW50KGNvbm4sIHNl cnZlci5tYWludGVuYW5jZV9kYikKKyAgICAgICAgc2VydmVyLm1haW50ZW5h bmNlX2RiCiAgICAgXQogICAgIGlmICdyb2xlJyBpbiBkYXRhIGFuZCBkYXRh Wydyb2xlJ106CiAgICAgICAgIGFyZ3MuYXBwZW5kKCctLXJvbGUnKQpAQCAt NDI4LDE0ICs0MjgsMTQgQEAgZGVmIGNyZWF0ZV9iYWNrdXBfb2JqZWN0c19q b2Ioc2lkKToKICAgICBzZXRfdmFsdWUoJ25vX29mX2pvYnMnLCAnLS1qb2Jz JywgVHJ1ZSkKIAogICAgIGZvciBzIGluIGRhdGFbJ3NjaGVtYXMnXToKLSAg ICAgICAgYXJncy5leHRlbmQoWyctLXNjaGVtYScsIGRyaXZlci5xdElkZW50 KGNvbm4sIHMpXSkKKyAgICAgICAgYXJncy5leHRlbmQoWyctLXNjaGVtYScs IHNdKQogCiAgICAgZm9yIHMsIHQgaW4gZGF0YVsndGFibGVzJ106CiAgICAg ICAgIGFyZ3MuZXh0ZW5kKFsKICAgICAgICAgICAgICctLXRhYmxlJywgZHJp dmVyLnF0SWRlbnQoY29ubiwgcywgdCkKICAgICAgICAgXSkKIAotICAgIGFy Z3MuYXBwZW5kKGRyaXZlci5xdElkZW50KGNvbm4sIGRhdGFbJ2RhdGFiYXNl J10pKQorICAgIGFyZ3MuYXBwZW5kKGRhdGFbJ2RhdGFiYXNlJ10pCiAKICAg ICB0cnk6CiAgICAgICAgIHAgPSBCYXRjaFByb2Nlc3MoCmRpZmYgLS1naXQg YS93ZWIvcGdhZG1pbi90b29scy9iYWNrdXAvdGVtcGxhdGVzL2JhY2t1cC9q cy9iYWNrdXAuanMgYi93ZWIvcGdhZG1pbi90b29scy9iYWNrdXAvdGVtcGxh dGVzL2JhY2t1cC9qcy9iYWNrdXAuanMKaW5kZXggYTEzYTMxYy4uOGRkZDRm YyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvYmFja3VwL3RlbXBs YXRlcy9iYWNrdXAvanMvYmFja3VwLmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rv b2xzL2JhY2t1cC90ZW1wbGF0ZXMvYmFja3VwL2pzL2JhY2t1cC5qcwpAQCAt NzQ3LDIwICs3NDcsMjAgQEAgVE9ETyBMSVNUIEZPUiBCQUNLVVA6CiAgICAg ICAgICAgICAgICAgICB2YXIgdHJlZUluZm8gPSBub2RlLmdldFRyZWVOb2Rl SGllcmFyY2h5LmFwcGx5KG5vZGUsIFtpXSk7CiAKICAgICAgICAgICAgICAg ICAgIC8vIFNldCBjdXJyZW50IGRhdGFiYXNlIGludG8gbW9kZWwKLSAgICAg ICAgICAgICAgICAgIHRoaXMudmlldy5tb2RlbC5zZXQoJ2RhdGFiYXNlJywg dHJlZUluZm8uZGF0YWJhc2UubGFiZWwpOworICAgICAgICAgICAgICAgICAg dGhpcy52aWV3Lm1vZGVsLnNldCgnZGF0YWJhc2UnLCBfLnVuZXNjYXBlKHRy ZWVJbmZvLmRhdGFiYXNlLmxhYmVsKSk7CiAKICAgICAgICAgICAgICAgICAg IC8vIFdlIHdpbGwgcmVtb3ZlIG9uY2Ugb2JqZWN0IHRyZWUgaXMgaW1wbGVt ZW50ZWQKICAgICAgICAgICAgICAgICAgIC8vIElmIHNlbGVjdGVkIG5vZGUg aXMgU2NoZW1hIHRoZW4gYWRkIGl0IGluIG1vZGVsCiAgICAgICAgICAgICAg ICAgICBpZihkLl90eXBlID09ICdzY2hlbWEnKSB7CiAgICAgICAgICAgICAg ICAgICAgIHZhciBzY2hlbWFzID0gW107Ci0gICAgICAgICAgICAgICAgICAg IHNjaGVtYXMucHVzaChkLmxhYmVsKTsKKyAgICAgICAgICAgICAgICAgICAg c2NoZW1hcy5wdXNoKF8udW5lc2NhcGUoZC5sYWJlbCkpOwogICAgICAgICAg ICAgICAgICAgICB0aGlzLnZpZXcubW9kZWwuc2V0KCdzY2hlbWFzJywgc2No ZW1hcyk7CiAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAg ICAvLyBJZiBzZWxlY3RlZCBub2RlIGlzIFRhYmxlIHRoZW4gYWRkIGl0IGlu IG1vZGVsIGFsb25nIHdpdGgKICAgICAgICAgICAgICAgICAgIC8vIGl0cyBz Y2hlbWEKICAgICAgICAgICAgICAgICAgIGlmKGQuX3R5cGUgPT0gJ3RhYmxl JykgewogICAgICAgICAgICAgICAgICAgICB0aGlzLnZpZXcubW9kZWwuc2V0 KAotICAgICAgICAgICAgICAgICAgICAgICd0YWJsZXMnLCBbW3RyZWVJbmZv LnNjaGVtYS5sYWJlbCwgZC5sYWJlbF1dCisgICAgICAgICAgICAgICAgICAg ICAgJ3RhYmxlcycsIFtbXy51bmVzY2FwZSh0cmVlSW5mby5zY2hlbWEubGFi ZWwpLCBfLnVuZXNjYXBlKGQubGFiZWwpXV0KICAgICAgICAgICAgICAgICAg ICAgKTsKICAgICAgICAgICAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvd2Vi L3BnYWRtaW4vdG9vbHMvaW1wb3J0X2V4cG9ydC9fX2luaXRfXy5weSBiL3dl Yi9wZ2FkbWluL3Rvb2xzL2ltcG9ydF9leHBvcnQvX19pbml0X18ucHkKaW5k ZXggZTFkYzA2MS4uYmZhZTk4YiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4v dG9vbHMvaW1wb3J0X2V4cG9ydC9fX2luaXRfXy5weQorKysgYi93ZWIvcGdh ZG1pbi90b29scy9pbXBvcnRfZXhwb3J0L19faW5pdF9fLnB5CkBAIC0yNTQs OCArMjU0LDcgQEAgZGVmIGNyZWF0ZV9pbXBvcnRfZXhwb3J0X2pvYihzaWQp OgogCiAgICAgYXJncyA9IFsKICAgICAgICAgJy0taG9zdCcsIHNlcnZlci5o b3N0LCAnLS1wb3J0Jywgc3RyKHNlcnZlci5wb3J0KSwKLSAgICAgICAgJy0t dXNlcm5hbWUnLCBzZXJ2ZXIudXNlcm5hbWUsICctLWRibmFtZScsCi0gICAg ICAgIGRyaXZlci5xdElkZW50KGNvbm4sIGRhdGFbJ2RhdGFiYXNlJ10pLAor ICAgICAgICAnLS11c2VybmFtZScsIHNlcnZlci51c2VybmFtZSwgJy0tZGJu YW1lJywgZGF0YVsnZGF0YWJhc2UnXSwKICAgICAgICAgJy0tY29tbWFuZCcs IHF1ZXJ5CiAgICAgXQogCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29s cy9pbXBvcnRfZXhwb3J0L3RlbXBsYXRlcy9pbXBvcnRfZXhwb3J0L2pzL2lt cG9ydF9leHBvcnQuanMgYi93ZWIvcGdhZG1pbi90b29scy9pbXBvcnRfZXhw b3J0L3RlbXBsYXRlcy9pbXBvcnRfZXhwb3J0L2pzL2ltcG9ydF9leHBvcnQu anMKaW5kZXggZjU2NGEwZS4uMDg1OWIxNiAxMDA2NDQKLS0tIGEvd2ViL3Bn YWRtaW4vdG9vbHMvaW1wb3J0X2V4cG9ydC90ZW1wbGF0ZXMvaW1wb3J0X2V4 cG9ydC9qcy9pbXBvcnRfZXhwb3J0LmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rv b2xzL2ltcG9ydF9leHBvcnQvdGVtcGxhdGVzL2ltcG9ydF9leHBvcnQvanMv aW1wb3J0X2V4cG9ydC5qcwpAQCAtNDAwLDkgKzQwMCw5IEBAIGRlZmluZSgK ICAgICAgICAgICAgICAgICAgICAgdHJlZUluZm8gPSBuLmdldFRyZWVOb2Rl SGllcmFyY2h5LmFwcGx5KG4sIFtpXSkKIAogICAgICAgICAgICAgICAgICAg dGhpcy52aWV3Lm1vZGVsLnNldCh7Ci0gICAgICAgICAgICAgICAgICAgICdk YXRhYmFzZSc6IHRyZWVJbmZvLmRhdGFiYXNlLmxhYmVsLAotICAgICAgICAg ICAgICAgICAgICAnc2NoZW1hJzogdHJlZUluZm8uc2NoZW1hLmxhYmVsLAot ICAgICAgICAgICAgICAgICAgICAndGFibGUnOiB0cmVlSW5mby50YWJsZS5s YWJlbAorICAgICAgICAgICAgICAgICAgICAnZGF0YWJhc2UnOiBfLnVuZXNj YXBlKHRyZWVJbmZvLmRhdGFiYXNlLmxhYmVsKSwKKyAgICAgICAgICAgICAg ICAgICAgJ3NjaGVtYSc6IF8udW5lc2NhcGUodHJlZUluZm8uc2NoZW1hLmxh YmVsKSwKKyAgICAgICAgICAgICAgICAgICAgJ3RhYmxlJzogXy51bmVzY2Fw ZSh0cmVlSW5mby50YWJsZS5sYWJlbCkKICAgICAgICAgICAgICAgICAgIH0p OwogICAgICAgICAgICAgICAgICAgdmFyIHNlbGYgPSB0aGlzLAogICAgICAg ICAgICAgICAgICAgICAgIGJhc2VVcmwgPSAie3sgdXJsX2ZvcignaW1wb3J0 X2V4cG9ydC5pbmRleCcpIH19IiArCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1p bi90b29scy9yZXN0b3JlL3RlbXBsYXRlcy9yZXN0b3JlL2pzL3Jlc3RvcmUu anMgYi93ZWIvcGdhZG1pbi90b29scy9yZXN0b3JlL3RlbXBsYXRlcy9yZXN0 b3JlL2pzL3Jlc3RvcmUuanMKaW5kZXggMmJjMzVlOC4uZmUyMWEzOCAxMDA2 NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvcmVzdG9yZS90ZW1wbGF0ZXMv cmVzdG9yZS9qcy9yZXN0b3JlLmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xz L3Jlc3RvcmUvdGVtcGxhdGVzL3Jlc3RvcmUvanMvcmVzdG9yZS5qcwpAQCAt NDcyLDI2ICs0NzIsMjYgQEAgZGVmaW5lKFsKICAgICAgICAgICAgICAgICAg IHZhciBpbmZvID0gbm9kZS5nZXRUcmVlTm9kZUhpZXJhcmNoeS5hcHBseShu b2RlLCBbaV0pLAogICAgICAgICAgICAgICAgICAgICAgIG0gPSB0aGlzLnZp ZXcubW9kZWw7CiAgICAgICAgICAgICAgICAgICAvLyBTZXQgY3VycmVudCBu b2RlIGluZm8gaW50byBtb2RlbAotICAgICAgICAgICAgICAgICAgbS5zZXQo J2RhdGFiYXNlJywgaW5mby5kYXRhYmFzZS5sYWJlbCk7CisgICAgICAgICAg ICAgICAgICBtLnNldCgnZGF0YWJhc2UnLCBfLnVuZXNjYXBlKGluZm8uZGF0 YWJhc2UubGFiZWwpKTsKICAgICAgICAgICAgICAgICAgIGlmICghbS5nZXQo J2N1c3RvbScpKSB7CiAgICAgICAgICAgICAgICAgICAgIHN3aXRjaCAoZC5f dHlwZSkgewogICAgICAgICAgICAgICAgICAgICAgIGNhc2UgJ3NjaGVtYSc6 Ci0gICAgICAgICAgICAgICAgICAgICAgICBtLnNldCgnc2NoZW1hcycsIGQu bGFiZWwpOworICAgICAgICAgICAgICAgICAgICAgICAgbS5zZXQoJ3NjaGVt YXMnLCBfLnVuZXNjYXBlKGQubGFiZWwpKTsKICAgICAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICAgIGNhc2UgJ3Rh YmxlJzoKLSAgICAgICAgICAgICAgICAgICAgICAgIG0uc2V0KCd0YWJsZXMn LCBbaW5mby5zY2hlbWEubGFiZWwsIGQubGFiZWxdKTsKKyAgICAgICAgICAg ICAgICAgICAgICAgIG0uc2V0KCd0YWJsZXMnLCBbXy51bmVzY2FwZShpbmZv LnNjaGVtYS5sYWJlbCksIF8udW5lc2NhcGUoZC5sYWJlbCldKTsKICAgICAg ICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAg ICAgIGNhc2UgJ2Z1bmN0aW9uJzoKLSAgICAgICAgICAgICAgICAgICAgICAg IG0uc2V0KCdmdW5jdGlvbnMnLCBbaW5mby5zY2hlbWEubGFiZWwsIGQubGFi ZWxdKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG0uc2V0KCdmdW5jdGlv bnMnLCBbXy51bmVzY2FwZShpbmZvLnNjaGVtYS5sYWJlbCksIF8udW5lc2Nh cGUoZC5sYWJlbCldKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgICAgICAgICAgIGNhc2UgJ2luZGV4JzoKLSAgICAg ICAgICAgICAgICAgICAgICAgIG0uc2V0KCdpbmRleGVzJywgW2luZm8uc2No ZW1hLmxhYmVsLCBkLmxhYmVsXSk7CisgICAgICAgICAgICAgICAgICAgICAg ICBtLnNldCgnaW5kZXhlcycsIFtfLnVuZXNjYXBlKGluZm8uc2NoZW1hLmxh YmVsKSwgXy51bmVzY2FwZShkLmxhYmVsKV0pOwogICAgICAgICAgICAgICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgICAgY2FzZSAn dHJpZ2dlcic6Ci0gICAgICAgICAgICAgICAgICAgICAgICBtLnNldCgndHJp Z2dlcnMnLCBbaW5mby5zY2hlbWEubGFiZWwsIGQubGFiZWxdKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgIG0uc2V0KCd0cmlnZ2VycycsIFtfLnVuZXNj YXBlKGluZm8uc2NoZW1hLmxhYmVsKSwgXy51bmVzY2FwZShkLmxhYmVsKV0p OwogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg ICAgICAgICAgICAgY2FzZSAndHJpZ2dlcl9mdW5jJzoKLSAgICAgICAgICAg ICAgICAgICAgICAgIG0uc2V0KCd0cmlnZ2VyX2Z1bmNzJywgW2luZm8uc2No ZW1hLmxhYmVsLCBkLmxhYmVsXSk7CisgICAgICAgICAgICAgICAgICAgICAg ICBtLnNldCgndHJpZ2dlcl9mdW5jcycsIFtfLnVuZXNjYXBlKGluZm8uc2No ZW1hLmxhYmVsKSwgXy51bmVzY2FwZShkLmxhYmVsKV0pOwogICAgICAgICAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7Cg== --001a113ca762b06555053ed33247 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113ca762b06555053ed33247--