Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etd9i-000672-GK for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 17:47:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etd9h-0007I0-LE for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 17:47:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etd6Q-0004UF-M1 for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 17:43:46 +0000 Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etd6K-0005lV-Pm for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 17:43:45 +0000 Received: by mail-oi0-x234.google.com with SMTP id t185so2293988oif.6 for ; Wed, 07 Mar 2018 09:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9bu2t/SShDjL/f/lnNT+hKT53uCgZRD81JOV53FyVjA=; b=dLib9EKp574V2SlI+Nku0OKYcZY61yGQeiuSX+8j6cLlkZnQAQP8JPp//KbfnqLkND U59K8hPuwvS2LGhgTATeKY/9Cl3pMlmGedpwB6SGmnwJjwmB8p3ig56I1C25Q+6Am9Ko rr3FrH9xMs9etWrrjmyT6vJHW1VwTmy/BzeUdQjg4AjCK3Jcg1i7iBQ0/0FzRuUyQj4Q KhnirjVOsDich+b6p389XK3llPjemVhLn19qx16gV6/k1QTYXk5Zy/EWqYaG3Yh8WaPY YIgoUg3HkNrizbT7R18jWWWcnnMU0yiaKoMpmbsWEbLroJhO1VtDTNk9/GS49uoi1LLI fhAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9bu2t/SShDjL/f/lnNT+hKT53uCgZRD81JOV53FyVjA=; b=h/YBg/tLLA84pIqZCngnPeHvBrybcMQVOt6Rp+Sp7E48FKR6ofJgmkNigdp1+ZDGW9 E9J3zH8aQNkTLy+5Sbt0Tc+wVzuGGMeF0GC6KYXaqerjF4Cz9S2P3qMSB47O8YeSH8xF ZebZvtrHzwBhiChuj94yMLTvzXNZRDAnxhrahm2fw/Mxzt8hb7TQCYrOCji/0LAjpdfj FpLjOAFfUEZCg/a6p1JDnigoCZLqZjV3ow4R2AqVfP8oYTN2u8eyCQyydsJ76UsELl6t xPgLP2EPY2EDhSiHO07g9i87m7zq/uQxlRLEMNcpCQqZv73AZX4Fg+ueEwfB5tER8Fu5 +0fg== X-Gm-Message-State: AElRT7ExcXvq3XfgdgwQ8hakMj2S1CpY/EhcSfrNyGnjVeyzkKhoP8u/ QuDfr2HCryyZ5GCqoeL0QZTw8Yp57VTjuH1FJ0Vrwg== X-Google-Smtp-Source: AG47ELvPIjt7fjWK8zZv5MRQDdiKrofdyHTttPjTRdLoXO4/EuojacjNZyYJ/6zh3LnEnm06BxjBWKtvj69IPIDA0kc= X-Received: by 10.202.218.197 with SMTP id r188mr13317667oig.203.1520444618106; Wed, 07 Mar 2018 09:43:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.203.154 with HTTP; Wed, 7 Mar 2018 09:43:37 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Khushboo Vashi Date: Wed, 7 Mar 2018 23:13:37 +0530 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="001a113d595a5dd7590566d619b7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113d595a5dd7590566d619b7 Content-Type: multipart/alternative; boundary="001a113d595a5dd7510566d619b5" --001a113d595a5dd7510566d619b5 Content-Type: text/plain; charset="UTF-8" Hi Dave, Please find the patch to fix this. I have fixed this issue in the StartRunningQueryTest class, this test class changes the behaviour of the methods through MagicMock and due to this this test case is failing. Thanks, Khushboo On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Wed, Mar 7, 2018 at 10:33 PM, Dave Page wrote: > >> It still seems to be failing :-( >> >> :( > >> https://jenkins.pgadmin.org/job/pgadmin4-master-python26/las >> tFailedBuild/consoleFull >> >> On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: >> >>> Thanks, applied. Lets see what happens. >>> >>> On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Please find the attached updated patch. >>>> This should work. >>>> >>>> >>>> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: >>>> >>>>> >>>>> >>>>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Khushboo, can you look at this ASAP please? It passed tests on my >>>>>>>>> machine, but Jenkins isn't happy. >>>>>>>>> >>>>>>>>> I have tried to reproduce the issue with many combination but >>>>>>>> couldn't reproduce it. >>>>>>>> With the help of logs, I have tried to fix it. Can you please check >>>>>>>> this fix is helpful or not? >>>>>>>> >>>>>>> >>>>>>> On my laptop I now get: >>>>>>> >>>>>>> ============================================================ >>>>>>> ========== >>>>>>> ERROR: runTest (pgadmin.tools.sqleditor.tests >>>>>>> .test_poll_query_tool.TestPollQueryTool) >>>>>>> When query tool polling returns messages with result data-set >>>>>>> ------------------------------------------------------------ >>>>>>> ---------- >>>>>>> Traceback (most recent call last): >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", >>>>>>> line 104, in runTest >>>>>>> response_data['data']['additional_messages']) >>>>>>> File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", >>>>>>> line 802, in assertIn >>>>>>> if member not in container: >>>>>>> TypeError: argument of type 'NoneType' is not iterable >>>>>>> >>>>>>> ------------------------------------------------------------ >>>>>>> ---------- >>>>>>> >>>>>>> Please provide some more details. Is this failing for particular >>>>>> server version? >>>>>> I am not getting any error with this patch and without this patch on >>>>>> PY2 and PY3 with a single/multiple servers. >>>>>> >>>>> >>>>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here >>>>> are the package versions in the venv: >>>>> >>>>> alabaster==0.7.10 >>>>> alembic==0.9.6 >>>>> args==0.1.0 >>>>> Babel==2.3.4 >>>>> backports.csv==1.0.4 >>>>> beautifulsoup4==4.4.1 >>>>> blinker==1.3 >>>>> chromedriver-installer==0.0.6 >>>>> click==6.6 >>>>> clint==0.5.1 >>>>> dateutils==0.6.6 >>>>> docutils==0.13.1 >>>>> extras==1.0.0 >>>>> fixtures==3.0.0 >>>>> Flask==0.11.1 >>>>> Flask-Babel==0.11.1 >>>>> Flask-Gravatar==0.4.2 >>>>> Flask-HTMLmin==1.2 >>>>> Flask-Login==0.3.2 >>>>> Flask-Mail==0.9.1 >>>>> Flask-Migrate==2.0.3 >>>>> Flask-Paranoid==0.1.0 >>>>> Flask-Principal==0.4.0 >>>>> Flask-Script==2.0.6 >>>>> Flask-Security==1.7.5 >>>>> Flask-SQLAlchemy==2.1 >>>>> Flask-WTF==0.12 >>>>> funcsigs==1.0.2 >>>>> html5lib==1.0b3 >>>>> htmlmin==0.1.11 >>>>> imagesize==0.7.1 >>>>> importlib==1.0.3 >>>>> itsdangerous==0.24 >>>>> Jinja2==2.7.3 >>>>> linecache2==1.0.0 >>>>> Mako==1.0.7 >>>>> MarkupSafe==0.23 >>>>> minify==0.1.4 >>>>> mock==2.0.0 >>>>> passlib==1.6.2 >>>>> pbr==3.1.1 >>>>> pkginfo==1.4.1 >>>>> psycopg2==2.7.3.2 >>>>> pycodestyle==2.3.1 >>>>> pycrypto==2.6.1 >>>>> Pygments==2.2.0 >>>>> pyperclip==1.5.32 >>>>> pyrsistent==0.14.0 >>>>> python-dateutil==2.5.0 >>>>> python-editor==1.0.3 >>>>> python-mimeparse==1.6.0 >>>>> pytz==2014.10 >>>>> requests==2.13.0 >>>>> requests-toolbelt==0.7.1 >>>>> selenium==3.3.3 >>>>> simplejson==3.6.5 >>>>> six==1.11.0 >>>>> snowballstemmer==1.2.1 >>>>> speaklater==1.3 >>>>> Sphinx==1.5.3 >>>>> SQLAlchemy==1.0.14 >>>>> sqlparse==0.1.19 >>>>> testscenarios==0.5.0 >>>>> testtools==2.0.0 >>>>> traceback2==1.4.0 >>>>> unittest2==1.1.0 >>>>> Werkzeug==0.9.6 >>>>> WTForms==2.0.2 >>>>> yuicompressor==2.4.8 >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a113d595a5dd7510566d619b5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

Please find the patch to fix t= his.
I have fixed this issue in the StartRunningQueryTest class, = this test class changes the behaviour of the methods through MagicMock and = due to this this test case is failing.

Thanks,
Khushboo


On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

=
On Wed, Mar 7, 2018 at 10:3= 3 PM, Dave Page <dpage@pgadmin.org> wrote:
It still seems to be failing :-(

=
:(=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
<= div class=3D"gmail_extra">
On Wed, Mar 7, 201= 8 at 4:50 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied. Lets see what ha= ppens.

On Wed, Mar 7, 2018 at 4:37 PM,= Khushboo Vashi <khushboo.vashi@enterprisedb.com>= ; wrote:
Please f= ind the attached updated patch.
This should work.


On Wed, Mar 7, 2018 at 9= :46 PM, Dave Page <dpage@pgadmin.org> wrote:


On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi= <khushboo.vashi@enterprisedb.com> wrote:=

=

On Wed, Mar 7, 2018 at 9:23 PM, Dave P= age <dpage@pgadmin.org> wrote:
Hi
<= br>
On Wed, Mar 7, 2018 at 3:10 PM, Khushbo= o Vashi <khushboo.vashi@enterprisedb.com>= wrote:
Hi Dave,

On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpag= e@pgadmin.org> wrote:
Khushboo, can you look at this ASAP please? = It passed tests on my machine, but Jenkins isn't happy.

<= /div>
I have tried to reproduce the issue with many= combination but couldn't reproduce it.
With the help of logs= , I have tried to fix it. Can you please check this fix is helpful or not?= =C2=A0

On my= laptop I now get:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin= .tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with result data-set=
----------------------------------------------------= ------------------
Traceback (most recent call last):
<= div>=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqle= ditor/tests/test_poll_query_tool.py", line 104, in runTest
<= div>=C2=A0 =C2=A0 response_data['data']['additional_messag= es'])
=C2=A0 File "/System/Library/Frameworks/Pytho= n.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 80= 2, in assertIn
=C2=A0 =C2=A0 if member not in container:
TypeError: argument of type 'NoneType' is not iterable
=
-------------------------------------------------------= ---------------=C2=A0

Please provide some more details. Is this faili= ng for particular server version?
I am not getting any error with= this patch and without this patch on PY2 and PY3 with a single/multiple se= rvers.

Pytho= n 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are the pack= age versions in the venv:

alabaster=3D=3D0.7.= 10
alembic=3D=3D0.9.6
args=3D=3D0.1.0
Babel= =3D=3D2.3.4
backports.csv=3D=3D1.0.4
beautifulsoup4=3D= =3D4.4.1
blinker=3D=3D1.3
chromedriver-installer=3D=3D0= .0.6
click=3D=3D6.6
clint=3D=3D0.5.1
dateutil= s=3D=3D0.6.6
docutils=3D=3D0.13.1
extras=3D=3D1.0.0
fixtures=3D=3D3.0.0
Flask=3D=3D0.11.1
Flask-Babe= l=3D=3D0.11.1
Flask-Gravatar=3D=3D0.4.2
Flask-HTMLmin= =3D=3D1.2
Flask-Login=3D=3D0.3.2
Flask-Mail=3D=3D0.9.1<= /div>
Flask-Migrate=3D=3D2.0.3
Flask-Paranoid=3D=3D0.1.0
Flask-Principal=3D=3D0.4.0
Flask-Script=3D=3D2.0.6
Flask-Security=3D=3D1.7.5
Flask-SQLAlchemy=3D=3D2.1
F= lask-WTF=3D=3D0.12
funcsigs=3D=3D1.0.2
html5lib=3D=3D1.= 0b3
htmlmin=3D=3D0.1.11
imagesize=3D=3D0.7.1
= importlib=3D=3D1.0.3
itsdangerous=3D=3D0.24
Jinja2=3D= =3D2.7.3
linecache2=3D=3D1.0.0
Mako=3D=3D1.0.7
MarkupSafe=3D=3D0.23
minify=3D=3D0.1.4
mock=3D=3D2.0.= 0
passlib=3D=3D1.6.2
pbr=3D=3D3.1.1
pkginfo= =3D=3D1.4.1
psycopg2=3D=3D2.7.3.2
pycodestyle=3D=3D2.3.= 1
pycrypto=3D=3D2.6.1
Pygments=3D=3D2.2.0
pyp= erclip=3D=3D1.5.32
pyrsistent=3D=3D0.14.0
python-dateut= il=3D=3D2.5.0
python-editor=3D=3D1.0.3
python-mimeparse= =3D=3D1.6.0
pytz=3D=3D2014.10
requests=3D=3D2.13.0
requests-toolbelt=3D=3D0.7.1
selenium=3D=3D3.3.3
= simplejson=3D=3D3.6.5
six=3D=3D1.11.0
snowballstemmer= =3D=3D1.2.1
speaklater=3D=3D1.3
Sphinx=3D=3D1.5.3
=
SQLAlchemy=3D=3D1.0.14
sqlparse=3D=3D0.1.19
testsc= enarios=3D=3D0.5.0
testtools=3D=3D2.0.0
traceback2=3D= =3D1.4.0
unittest2=3D=3D1.1.0
Werkzeug=3D=3D0.9.6
=
WTForms=3D=3D2.0.2
yuicompressor=3D=3D2.4.8
=
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
<= br>EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enter= prise PostgreSQL Company



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company


--001a113d595a5dd7510566d619b5-- --001a113d595a5dd7590566d619b7 Content-Type: text/x-patch; charset="US-ASCII"; name="testcase_fix.patch" Content-Disposition: attachment; filename="testcase_fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jehdfe9r0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci91dGlscy90ZXN0cy90ZXN0 X3N0YXJ0X3J1bm5pbmdfcXVlcnkucHkgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdXRp bHMvdGVzdHMvdGVzdF9zdGFydF9ydW5uaW5nX3F1ZXJ5LnB5CmluZGV4IGI4ZTFlYzYuLmFjOWZh ZTQgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci91dGlscy90ZXN0cy90 ZXN0X3N0YXJ0X3J1bm5pbmdfcXVlcnkucHkKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRp dG9yL3V0aWxzL3Rlc3RzL3Rlc3Rfc3RhcnRfcnVubmluZ19xdWVyeS5weQpAQCAtNDEwLDYgKzQx MCw3IEBAIGNsYXNzIFN0YXJ0UnVubmluZ1F1ZXJ5VGVzdChCYXNlVGVzdEdlbmVyYXRvcik6CiAg ICAgICAgICAgICBTdGFydFJ1bm5pbmdRdWVyeS5pc19iZWdpbl9yZXF1aXJlZF9mb3Jfc3FsX3F1 ZXJ5ID0gTWFnaWNNb2NrKAogICAgICAgICAgICAgICAgIHJldHVybl92YWx1ZT1GYWxzZQogICAg ICAgICAgICAgKQorICAgICAgICBzZWxmLmlzX3JvbGxiYWNrX3N0YXRlbWVudF9yZXF1aXJlZCA9 IFN0YXJ0UnVubmluZ1F1ZXJ5LmlzX3JvbGxiYWNrX3N0YXRlbWVudF9yZXF1aXJlZAogICAgICAg ICBpZiBzZWxmLmlzX3JvbGxiYWNrX3JlcXVpcmVkOgogICAgICAgICAgICAgU3RhcnRSdW5uaW5n UXVlcnkuaXNfcm9sbGJhY2tfc3RhdGVtZW50X3JlcXVpcmVkID0gTWFnaWNNb2NrKAogICAgICAg ICAgICAgICAgIHJldHVybl92YWx1ZT1UcnVlCkBAIC01MTksMyArNTIwLDggQEAgY2xhc3MgU3Rh cnRSdW5uaW5nUXVlcnlUZXN0KEJhc2VUZXN0R2VuZXJhdG9yKToKICAgICAgICAgICAgIHNlbGYu Y29ubmVjdGlvbi5leGVjdXRlX3ZvaWQuYXNzZXJ0X2NhbGxlZF93aXRoKCdST0xMQkFDSzsnKQog ICAgICAgICBlbGlmIG5vdCBzZWxmLmlzX2JlZ2luX3JlcXVpcmVkOgogICAgICAgICAgICAgc2Vs Zi5jb25uZWN0aW9uLmV4ZWN1dGVfdm9pZC5hc3NlcnRfbm90X2NhbGxlZCgpCisKKyAgICBkZWYg dGVhckRvd24oc2VsZik6CisgICAgICAgICMgIFJlc2V0aW5nIHRvIHRoZSBvcmlnaW5hbCBzdGF0 ZSBhcyBpdCBhZmZlY3RzIG90aGVyIHRlc3QgY2FzZXMKKyAgICAgICAgU3RhcnRSdW5uaW5nUXVl cnkuaXNfcm9sbGJhY2tfc3RhdGVtZW50X3JlcXVpcmVkID0gXAorICAgICAgICAgICAgc2VsZi5p c19yb2xsYmFja19zdGF0ZW1lbnRfcmVxdWlyZWQK --001a113d595a5dd7590566d619b7--