public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][Patch] - RM #6828 - Search object: Issue with focus the searched object in the tree.
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch] - RM #6828 - Search object: Issue with focus the searched object in the tree.
@ 2021-10-07 06:56 Khushboo Vashi <[email protected]>
  2021-10-07 12:36 ` Re: [pgAdmin4][Patch] - RM #6828 - Search object: Issue with focus the searched object in the tree. Akshay Joshi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Khushboo Vashi @ 2021-10-07 06:56 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Please find the attached patch to fix the RM #6828 - Search object: Issue
with focus the searched object in the tree.

Note: Please commit this patch after release.

Thanks,
Khushboo


Attachments:

  [application/octet-stream] RM_6828.patch (1.5K, 3-RM_6828.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/tree/tree_init.tsx b/web/pgadmin/static/js/tree/tree_init.tsx
index 0587f1dc8..823428149 100644
--- a/web/pgadmin/static/js/tree/tree_init.tsx
+++ b/web/pgadmin/static/js/tree/tree_init.tsx
@@ -73,10 +73,11 @@ var initBrowserTree = async (pgBrowser) => {
 
   await treeModelX.root.ensureLoaded()
 
+  let tree_height = window.outerHeight - 300;
   // Render Browser Tree
   await render(
     <div>
-      <FileTreeX height={950} width={'100%'} model={treeModelX}
+      <FileTreeX height={tree_height} width={'100%'} model={treeModelX}
         onReady={itemHandle} create={create} remove={remove} update={update}/>
      </div>, document.getElementById('tree'));
 }
diff --git a/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js b/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js
index 62d37edc1..f8249a892 100644
--- a/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js
+++ b/web/pgadmin/tools/search_objects/static/js/search_objects_dialog_wrapper.js
@@ -288,7 +288,9 @@ export default class SearchObjectsDialogWrapper extends DialogWrapper {
       this.showMessage(gettext('Locating...'));
       tree.findNodeWithToggle(rowData.id_path)
         .then((treeItem)=>{
-          tree.select(treeItem, true);
+          setTimeout(() => {
+            tree.select(treeItem, true);
+          }, 100);
           this.showMessage(null);
         })
         .catch((error)=>{


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch] - RM #6828 - Search object: Issue with focus the searched object in the tree.
  2021-10-07 06:56 [pgAdmin4][Patch] - RM #6828 - Search object: Issue with focus the searched object in the tree. Khushboo Vashi <[email protected]>
@ 2021-10-07 12:36 ` Akshay Joshi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-10-07 12:36 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Thanks, the patch applied.

On Thu, Oct 7, 2021 at 12:27 PM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #6828 - Search object: Issue
> with focus the searched object in the tree.
>
> Note: Please commit this patch after release.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2021-10-07 12:36 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 06:56 [pgAdmin4][Patch] - RM #6828 - Search object: Issue with focus the searched object in the tree. Khushboo Vashi <[email protected]>
2021-10-07 12:36 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox