public inbox for [email protected]  

help / color / mirror / Atom feed
From: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Fixed an issue related to update the tree
Date: Tue, 26 Apr 2016 19:08:03 +0530
Message-ID: <CAFOhELeoGg6-5fb2WrxgqmmD+GS+3ysNZvMVcrGU79zWVv8GVw@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Fixed a minor bug related to update the tree in the node.js.
Due to this bug,  After updating the Node, if the response data is null
then it gives an error.

Please find the attached patch for the same.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_node_js.patch (768B, 3-pgAdmin4_node_js.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 23d559c..15d4c61 100644
--- a/web/pgadmin/browser/templates/browser/js/node.js
+++ b/web/pgadmin/browser/templates/browser/js/node.js
@@ -918,7 +918,7 @@ function($, _, S, pgAdmin, Menu, Backbone, Alertify, pgBrowser, Backform) {
           } else if (view.model.get('name')) {
             tree.setLabel(item, {label: view.model.get("name")});
             if (
-              view.model.get('data').icon && view.model.get('data').icon != ''
+              view.model.get('data') && view.model.get('data').icon && view.model.get('data').icon != ''
             )
               tree.addIcon(item, {icon: view.model.get('data').icon});
           }


reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: Fixed an issue related to update the tree
  In-Reply-To: <CAFOhELeoGg6-5fb2WrxgqmmD+GS+3ysNZvMVcrGU79zWVv8GVw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox