MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxoz0e8J6qGEzeGrQ6ViL17zpfZeRDFzudwP7A-Y1g14LzA@mail.gmail.com>
References: 
 <CAFOhELezaRVS+JbX0Xtsms8jWND9H1h8HW_WeB3rKVLT8kJ=Fg@mail.gmail.com>
 <CA+OCxoz0e8J6qGEzeGrQ6ViL17zpfZeRDFzudwP7A-Y1g14LzA@mail.gmail.com>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Thu, 14 Jun 2018 15:41:30 +0530
Message-ID: 
 <CAFOhELf-7ptoTa04oOGZSAVT7kS25p3GU7T-keNmJPkxtWUYvg@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application
 server could not be contacted
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000bbbbf5056e9752a5"
Precedence: bulk

--000000000000bbbbf5056e9752a5
Content-Type: text/plain; charset="UTF-8"

On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <dpage@pgadmin.org> wrote:

> Hi
>
> On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <
> khushboo.vashi@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the fix for #3411 - pgAdmin 4, Mac. The application server
>> could not be contacted
>>
>> The issue is with french translation which has been taken care in the
>> attached patch.
>>
>
> We've seen similar issues with translations before. How can we write a
> test (or tests) to validate them?
>
> One idea that springs to mind is to generate a new template against the
> app, then iterate through all the translation catalogs and attempt to
> translate each string that we find in the template we generated.
>
> We can also use our messages.pot file as a template and attempt to
translate each string that we find in it against all the translation
catalogs.

> Alternatively, just iterate the catalogs, and grab each of the source
> strings from them and attempt to translate using the same catalog.
>
> The former method would ensure that the current state of the application
> can be translated, but that of course might miss some strings in the
> catalogs. The latter would validate each catalog against itself, but might
> miss some strings that are in the application but haven't been merged yet
> (though, that doesn't seem like it would cause a problem).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--000000000000bbbbf5056e9752a5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <span dir=3D"ltr">&lt;<a hre=
f=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin.org</a>&gt;<=
/span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi<br><div=
 class=3D"gmail_extra"><br><div class=3D"gmail_quote"><span class=3D"">On T=
hu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <span dir=3D"ltr">&lt;<a href=
=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khushboo.vash=
i@enterprisedb.<wbr>com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please find the fix for #3411 =
-=C2=A0pgAdmin 4, Mac. The application server could not be contacted</div><=
div><br></div><div>The issue is with french translation which has been take=
n care in the attached patch.</div></div></blockquote><div><br></div></span=
><div>We&#39;ve seen similar issues with translations before. How can we wr=
ite a test (or tests) to validate them?</div><div><br></div><div>One idea t=
hat springs to mind is to generate a new template against the app, then ite=
rate through all the translation catalogs and attempt to translate each str=
ing that we find in the template we generated.</div><div><br></div></div></=
div></div></blockquote><div>We can also use our messages.pot file as a temp=
late and attempt to translate each string that we find in it against all th=
e translation catalogs.=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=
=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote"><div></div><=
div>Alternatively, just iterate the catalogs, and grab each of the source s=
trings from them and attempt to translate using the same catalog.</div><div=
><br></div><div>The former method would ensure that the current state of th=
e application can be translated, but that of course might miss some strings=
 in the catalogs. The latter would validate each catalog against itself, bu=
t might miss some strings that are in the application but haven&#39;t been =
merged yet (though, that doesn&#39;t seem like it would cause a problem).</=
div></div><span class=3D"HOEnZb"><font color=3D"#888888"><div><br></div>-- =
<br><div class=3D"m_4480197815972660058gmail_signature" data-smartmail=3D"g=
mail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" =
target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><=
br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blan=
k">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br>=
</div>
</font></span></div></div>
</blockquote></div><br></div></div>

--000000000000bbbbf5056e9752a5--