Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1golYq-0002H9-LS for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 08:49:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1golYo-0000Fz-Sh for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 08:49:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1golYo-0000DP-D4 for pgadmin-hackers@lists.postgresql.org; Wed, 30 Jan 2019 08:49:30 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1golYk-0004N6-5K for pgadmin-hackers@postgresql.org; Wed, 30 Jan 2019 08:49:28 +0000 Received: by mail-ot1-x342.google.com with SMTP id t5so20480679otk.1 for ; Wed, 30 Jan 2019 00:49:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nR8VIaedSI3P3+dK4XPtlyfB1DfSpQeRMsNh8zKpco8=; b=BnWB6dl7uXgXX0uik7dnXhlTgcpmaAYitjV3AQl9yguvEv6pRzJUXvnM6o2RMtgGhq SWLKJh5xJAetzFPncoCmR5182jTstFrd4k9orKtiVXL+vSKrnKLXrv4/Lv05ARTPGinF R5O8OKzoLDkiS67iES6e/1lZRoUleGVij1DtkTYU0Qk7KDa1oalE9dZOv0irzJqZC3WH XbSStvwoymjia10DNrs2lMFk7qqYgU4Glkz8i30JRHnG4xDDH9G4faiUnXJg7wGfCKFW INc77IOg8B7nVmTLBZ3syQ2jmJSebIL3PFysUa4IDqzol2f+7NO1cU9+ONfMQ4MLUmql /w1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nR8VIaedSI3P3+dK4XPtlyfB1DfSpQeRMsNh8zKpco8=; b=UWzUK46IHmO0sIuhJDIhOEJC4t4QTH9T9X6wrxkn7dsflR/yFpKiXswkZtj2gVug9L Bdu5C/otNFYmEOBb9AVImcXimBQT2NSLOv2Oe/Luh8O3mn4s0dX1vY0vxWKxtPbxKHi6 9a1YaVGbs3GzgPvkbWEHCLmHxc708Oqk9mjXJK34nXJZlM9eL8HSoG4kLRJEUJp02VC6 Hw2GPj6oCJMr6zqiEVFs6pMnmjoXtQKSpXLSsgmog6IWoaVIK1Wdetk3vE0l+gYQ3JCe 27gq7oZXDW3ceGnWdws0/ZG1M4mYqS76ChJuOdQZbuK7KF9K1UgdvtONoZGFMnNwRh79 rt1g== X-Gm-Message-State: AJcUukc7lu49wk/P7ASpQVzQmgZHBBFa4kLaju0HPeroqth0a+PzlZbC 5nP480sjIPWGNXnvHpQZQnxwNwqqchaQt8r8WwJS7g== X-Google-Smtp-Source: ALg8bN6DR2oMTt2/xq/+j+uAYOKb9/FaYx6pd+hRhgOnVbI0KQeJsrJtjdDhb2j0sjsA/4/v+UQ3fdDX6vje0/uzHIE= X-Received: by 2002:a9d:1d65:: with SMTP id m92mr22538507otm.65.1548838165354; Wed, 30 Jan 2019 00:49:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Wed, 30 Jan 2019 14:19:14 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a931b40580a8fc89" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a931b40580a8fc89 Content-Type: text/plain; charset="UTF-8" The patch looks good to me. On Wed, Jan 30, 2019 at 1:05 PM Akshay Joshi wrote: > Hi Khushboo > > On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Akshay, >> >> The issue has been fixed with this patch but I feel we need code >> refactoring of the existing code especially the loop in which we find the >> required string. >> What's your thought? >> > > Attached is the updated patch. Please review it. > >> >> Also, please remove the datagrid/__init__.py file from the patch which I >> assume you have sent by mistake. >> > > No that file contains fix to cancel the transaction of Query Tool. By > mistake that line is commented out. > >> >> Thanks, >> Khushboo >> >> >> On Tue, Jan 29, 2019 at 4:49 PM Dave Page wrote: >> >>> Khushboo, can you review this please? If you're happy with it, Akshay >>> can commit. >>> >>> Thanks. >>> >>> On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi >>> wrote: >>> > >>> > Hi Hackers, >>> > >>> > Attached is the patch to fix RM 3927 "Unable to debug the procedure >>> inside package". Problem with the existing code is we assume that >>> "PLDBGBREAK" will be always found in the first element of the notification >>> list. >>> > >>> > In this patch we loop through the list and found the string. Apart >>> from that patch contains small fix to cancel the transaction of Query Tool >>> when panel is closed. >>> > >>> > Please review it. >>> > >>> > -- >>> > Akshay Joshi >>> > Sr. Software Architect >>> > >>> > >>> > Phone: +91 20-3058-9517 >>> > Mobile: +91 976-788-8246 >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --000000000000a931b40580a8fc89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The patch looks good to me.

On Wed, Jan 30, 2019 at 1:= 05 PM Akshay Joshi <aks= hay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Khushbo= o

On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi <khushboo.vashi@enterprisedb.= com> wrote:
Hi Akshay,

The issue has been fixed = with this patch but I feel we need code refactoring of the existing code es= pecially the loop in which we find the required string.
What'= s your thought?

=C2=A0 =C2=A0 A= ttached is the updated patch. Please review it.=C2=A0

Also= , please remove the datagrid/__init__.py file from the patch which I assume= you have sent by mistake.

=C2= =A0 =C2=A0 No that file contains fix to cancel the transaction of Query Too= l. By mistake that line is commented out.=C2=A0

Thanks,
Khushboo
=C2=A0

On Tue, Jan 29, 2019 at 4:49 PM Dave= Page <dpage@pgad= min.org> wrote:
Khushboo, can you review this please? If you're happy with it, A= kshay
can commit.

Thanks.

On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi
<aksh= ay.joshi@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM 3927 "Unable to debug the procedu= re inside package". Problem with the existing code is we assume that &= quot;PLDBGBREAK" will be always found in the first element of the noti= fication list.
>
> In this patch we loop through the list and found the string. Apart fro= m that patch contains small fix to cancel the transaction of Query Tool whe= n panel is closed.
>
> Please review it.
>
> --
> Akshay Joshi
> Sr. Software Architect
>
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sr. Software Architect


Phone: +91 20-3058-9517
Mobil= e: +91 976-788-8246
--000000000000a931b40580a8fc89--