Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgadmin-hackers-owner+archive@lists.postgresql.org>)
	id 1mcLvV-0007qm-I5
	for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Oct 2021 06:15:13 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgadmin-hackers-owner+archive@lists.postgresql.org>)
	id 1mcLvU-000275-H6
	for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Oct 2021 06:15:12 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <khushboo.vashi@enterprisedb.com>)
	id 1mcLvT-00026u-Vg
	for pgadmin-hackers@lists.postgresql.org; Mon, 18 Oct 2021 06:15:12 +0000
Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <khushboo.vashi@enterprisedb.com>)
	id 1mcLvR-0003PE-18
	for pgadmin-hackers@postgresql.org; Mon, 18 Oct 2021 06:15:11 +0000
Received: by mail-lf1-x135.google.com with SMTP id i24so63938896lfj.13
        for <pgadmin-hackers@postgresql.org>;
 Sun, 17 Oct 2021 23:15:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=enterprisedb.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Y7Wt1lXJe9nsoFinY0IMCHWJiYoRLlyZhSBILdAyhKw=;
        b=lQHTpl41jiPDO7GchxtlXnN2pgdZC0detq5GK6r85A0qXvZ78xlwbbQpsDxH0Y9u4r
         JYUREZaxuszsChHxQqIlZ/9IjkexnlNzGihV1OCVp12Mc95v8lsxPznisj80gIKqdMav
         pvu7u8KxnX+amT1TLGV6uDIWwdP5A7WHZgq/j/xXYVjdvqP36OeBXGc1EB10D6GoLYxf
         4orNx+aSSZAG8KrTsOkd1jJriLsIxMyCcbJ2uMCGe3Fs38jCqShuU2ofiSffFZzte9jJ
         2zhCYacxtit7BqiRhNELvr0b5YhQnN155sxWGmU+xdT/j7ncymOinmYolVSlbzJcRNai
         RGRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Y7Wt1lXJe9nsoFinY0IMCHWJiYoRLlyZhSBILdAyhKw=;
        b=P2MR1I3pfwx0qg7fo+zjqzh/qRPidGZ6yufT6cwQkceg1b/uwAcAO5bMS/589pr3gu
         ogl+m1f9kMREgI4bqHOFBQyF94LES1JetwHo7WSKpiQDCkdt1xZiao/UMG1TUaUirUKS
         lYeJ+lFjjcIHi3/M+v2vLgUDw9z699JPKDL4oB902lfXeH38BWLkKhubD1wQt8vKMn9C
         YZZ2qtMa286VYzzkT0cwjauz8POC+aTbVdBTmb4DYQEgCSf0kz0p6Cz6V51ENtJvrdrZ
         TKK49pyTtHiNQo1JgU25zqDSxYeff57uvQY5g+G9jiwFFjEOsCX1cIUabAp3lhoFCRjH
         i8RQ==
X-Gm-Message-State: AOAM532vmhRoZGq3SHdQKLgm+uuXvVuU3zRau5tRYs/fqZAqib2Nqvbl
	thw6Bh26yBJB2WqYcJlj4UnLy+F2nomii0SxP5C//OVQbfFTnNlEauraMaBe3G/H50+MvmiRl+Y
	L9Ohp60UDN+5I0g5+wzxK+d4bTK4VBhXNXACADq44wPNbur8Zf4SgK4cX6uGEwgE6N7Cyoc3JPq
	TvvfbAZUEGF39oBDKtnIJYiz0W0T5TOWbjg77sxq2IzwPUnUpKyuzyjI/2u46wNzj0Qg==
X-Google-Smtp-Source: 
 ABdhPJxVmyvjxpjEyhnUAisAR5rO1wgBbgO/W/4nt4bQjqUYVKuKWPuPTJGhg8lCISbdK7Y7ZLgdHijPqlHYt88F8ds=
X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr26682858lfq.520.1634537707665;
 Sun, 17 Oct 2021 23:15:07 -0700 (PDT)
MIME-Version: 1.0
References: <2d34bb53-0614-c31e-d2e1-dcdc5723a70d@posteo.de>
In-Reply-To: <2d34bb53-0614-c31e-d2e1-dcdc5723a70d@posteo.de>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Mon, 18 Oct 2021 11:44:56 +0530
Message-ID: 
 <CAFOhELf8Kq0SWs3+1Jf+wVAzKXcB_es+5LByThCiBeF30oNrfA@mail.gmail.com>
Subject: Re: Patch for Bug #6832
To: Florian Sabonchi <sabonchi@posteo.de>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000007011fa05ce9a77e8"
X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor
X-CLOUD-SEC-AV-Sent: true
X-Gm-Spam: 0
X-Gm-Phishy: 0
List-Id: <pgadmin-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgadmin-hackers@lists.postgresql.org>
List-Owner: <mailto:pgadmin-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgadmin-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CAFOhELf8Kq0SWs3%2B1Jf%2BwVAzKXcB_es%2B5LByThCiBeF30oNrfA%40mail.gmail.com>
Precedence: bulk

--0000000000007011fa05ce9a77e8
Content-Type: text/plain; charset="UTF-8"

Hi Florian,

The patch will fail if we have AUTHENTICATION_SOURCES = ['ldap', 'oauth2']
settings.
Also, please rebase your patch.

Thanks,
Khushboo



On Wed, Oct 13, 2021 at 4:03 PM Florian Sabonchi <sabonchi@posteo.de> wrote:

> Hello I have written a patch for the bug #6832
>
>

--0000000000007011fa05ce9a77e8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><font face=3D"arial, sans-serif" color=3D"#000000">Hi Flor=
ian,</font><div><font face=3D"arial, sans-serif" color=3D"#000000"><br></fo=
nt></div><div><font face=3D"arial, sans-serif" color=3D"#000000">The patch =
will fail if we have=C2=A0AUTHENTICATION_SOURCES =3D [<span style=3D"font-w=
eight:bold">&#39;ldap&#39;</span>, <span style=3D"font-weight:bold">&#39;oa=
uth2&#39;</span>] settings.</font></div><div><font face=3D"arial, sans-seri=
f" color=3D"#000000">Also, please rebase your patch.</font></div><div><font=
 face=3D"arial, sans-serif" color=3D"#000000"><br></font></div><div><font f=
ace=3D"arial, sans-serif" color=3D"#000000">Thanks,</font></div><div><font =
face=3D"arial, sans-serif" color=3D"#000000">Khushboo<br></font><div><br></=
div><div><br></div></div></div><br><div class=3D"gmail_quote"><div dir=3D"l=
tr" class=3D"gmail_attr">On Wed, Oct 13, 2021 at 4:03 PM Florian Sabonchi &=
lt;<a href=3D"mailto:sabonchi@posteo.de">sabonchi@posteo.de</a>&gt; wrote:<=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello I have wri=
tten a patch for the bug #6832<br>
<br>
</blockquote></div>

--0000000000007011fa05ce9a77e8--