Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ag7oy-0002tO-OK for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Mar 2016 09:32:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ag7oy-0002Yh-5g for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Mar 2016 09:32:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ag7ok-0002Jx-9R for pgadmin-hackers@postgresql.org; Wed, 16 Mar 2016 09:32:38 +0000 Received: from mail-lf0-x235.google.com ([2a00:1450:4010:c07::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ag7og-0002VB-K4 for pgadmin-hackers@postgresql.org; Wed, 16 Mar 2016 09:32:36 +0000 Received: by mail-lf0-x235.google.com with SMTP id e138so14055598lfe.1 for ; Wed, 16 Mar 2016 02:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=znZTDC0qsxTetU56Rk1rqGoOjepSNQxYIY6RsmGle2Q=; b=ag1Wbsna+Las5SJ+sf4B81JRMr0JvgdnbCqMF+fw8crmc3MZ79LqgDzgGdlIlV36uG nMregs8CXaiga0KXOh6hoDnacCplegtG/kBedFPaEa0Z2YlOZcgTdI24WVbwuJtiYAml +VR1zlBHeMSfBGXWxIAtvZvlC1UdNxJf1TKm6RmSFMPsE2fCe5hVBF79vCo+xzTPsU/T ww5wZrqL3LqHRTEcVpKJaRdo8opd6DjaPrFWiSRlWI6nUYktBPJtgTO29ovcbWPmVG37 k4CRBGLDE49Be7zqvzMjMpPkNlcP9WNcbi90pigdc7Cu5BEPPR4yMs/ktzLumwcHLkvW uKCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=znZTDC0qsxTetU56Rk1rqGoOjepSNQxYIY6RsmGle2Q=; b=ktH3Oj8T/eAr7GI2tQ2ovoaYTZfMFuRnQ6zidkC+k5eioAKY6hsKeB3CTpefsOPAIo ExXdQJDKH+qG43ZHVjXLZsNiujhx8fKV1ULSISczAcVJzqby0z+/98lqNxFwQxzeoR6j 5Tmf6nJWV+uvXkzzddaJugm82jgXzQ+XUoPgzg0iVeCJEvXiDaXkwziZBK5g/Wa9yfh7 dW2xpYLlMGWImJS9NqyJphpbeyyEXHTO+JlonoIWXodMS7Z+no7He+e5JeeBBHv+8XaW X5aco1qTVIdvzJ0dDmmCKCTA36yb1MzDmH3yoQm7LHSgfRTh3C0SMAqfTyomGqeFHhjH jfjQ== X-Gm-Message-State: AD7BkJLN2HYKJt3mFqnvxPpNMfVNPAp8Xuxq0Otop0m8yWO4CUNTraQfI2/ZIm0h1olQKmYDEi8oe/Wf+wMsmXyE MIME-Version: 1.0 X-Received: by 10.25.211.75 with SMTP id k72mr978714lfg.45.1458120752566; Wed, 16 Mar 2016 02:32:32 -0700 (PDT) Received: by 10.25.159.85 with HTTP; Wed, 16 Mar 2016 02:32:32 -0700 (PDT) In-Reply-To: References: Date: Wed, 16 Mar 2016 15:02:32 +0530 Message-ID: Subject: Re: pgAdmin4 PATCH: Domain Module From: Khushboo Vashi To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1141176a7f2974052e273107 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1141176a7f2974052e273107 Content-Type: text/plain; charset=UTF-8 Hi, On Wed, Mar 16, 2016 at 2:55 PM, Dave Page wrote: > Hi > > On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi > wrote: > > > >>> - Owner and schema should be allowed to be left blank (and then default > >>> to the current user/schema) > > > > Done > > Oh, sorry - that design changed a while back, and I've updated all the > existing nodes already. I thought I'd mentioned that. All we do now is > pre-set the default values for those two fields. > I have done in this way only. Sorry for the misunderstanding. > >>> - When adding constraints, I should be able to type directly into the > >>> grid. Expanding the row should be optional. > > > > I have made the grid non-editable explicitly as the Check constraint > control > > is multi-line control and right now there is no support in the grid for > the > > multi-line control. > > Not sure I follow - the mockup design you sent months ago allowed you > to type into the grid, and expand a row to show all fields if you > wanted. That is an *absolutely essential* feature enhancement for > pgAdmin 4 - it's required by the table design (though this will change > a little in other ways, like positioning of the expand row button), > and should be used here: > > https://www.lucidchart.com/documents/edit/610ce42d-c397-48ff-a5e7-bd92c4995715/0 > > All other controls other than text-area are supported in back-grid. I will try to incorporate text-area as well, so we can directly type into the grid for this control also. > >>> - The comment column on the constraints grid expands when the text > >>> reaches ~50% of the width. It should be a fixed size (and use 100% of > the > >>> space available, less appropriate margins) > > > > I have applied the size for the each header of the grid, but if the given > > input will be without space in the grid then it will expand. For this, we > > can make table layout fixed. So, please suggest, should I do that or not? > > Yes, I think it should be fixed. If the grid row is expanded, > presumably it'll show in a multi-line field anyway? Plus the > properties will use a multi-line field as well. > > Okay. > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1141176a7f2974052e273107 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

On Wed, Mar 16, 2016 at 2:55 PM, Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:
Hi

On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi
<khushboo.vashi@enter= prisedb.com> wrote:
>
>>> - Owner and schema should be allowed to be left blank (and the= n default
>>> to the current user/schema)
>
> Done

Oh, sorry - that design changed a while back, and I've updated a= ll the
existing nodes already. I thought I'd mentioned that. All we do now is<= br> pre-set the default values for those two fields.
I have done in this w= ay only. Sorry for the misunderstanding.
>>> - When adding constraints, I should be able to type directly i= nto the
>>> grid. Expanding the row should be optional.
>
> I have made the grid non-editable explicitly as the Check constraint c= ontrol
> is multi-line control and right now there is no support in the grid fo= r the
> multi-line control.

Not sure I follow - the mockup design you sent months ago allowed yo= u
to type into the grid, and expand a row to show all fields if you
wanted. That is an *absolutely essential* feature enhancement for
pgAdmin 4 - it's required by the table design (though this will change<= br> a little in other ways, like positioning of the expand row button),
and should be used here:
https://www.lucidcha= rt.com/documents/edit/610ce42d-c397-48ff-a5e7-bd92c4995715/0

All other controls other than text-area are supported in back-grid. <= br>
I will try to incor= porate text-area as well, so we can directly type into the grid for this co= ntrol also.
=C2=A0
>>> - The comment column on the constraints grid expands when the = text
>>> reaches ~50% of the width. It should be a fixed size (and use = 100% of the
>>> space available, less appropriate margins)
>
> I have applied the size for the each header of the grid, but if the gi= ven
> input will be without space in the grid then it will expand. For this,= we
> can make table layout fixed. So, please suggest, should I do that or n= ot?

Yes, I think it should be fixed. If the grid row is expanded,
presumably it'll show in a multi-line field anyway? Plus the
properties will use a multi-line field as well.

<= span style=3D"color:rgb(0,0,255)">Okay.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1141176a7f2974052e273107--