Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2X1I-0003u9-Ki for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 10:16:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2X1H-00088W-Ie for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 10:16:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2X1H-00088P-56 for pgadmin-hackers@lists.postgresql.org; Thu, 21 Jan 2021 10:16:51 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2X1E-0006xN-9V for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2021 10:16:50 +0000 Received: by mail-lf1-x12f.google.com with SMTP id q8so1736575lfm.10 for ; Thu, 21 Jan 2021 02:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8Q1nzeReV4n81loZ84nPso6hHxHo5OWEXcbK9VWi2ko=; b=WN4b/FIZe3QqnEywJxPH9CYoCpcWx9aL8weRrQZ7UoluFmz1gM9huW+eUdk/wkKosG +t6eibgYaYf/A8kvfQPDNHTS4QE6vWjkMpZAFfLEC+yLJF9mROZCEAySK9BvQggt9R63 mFmmDNOWiqyX3tcsPllGiDNPzHKhP/d0n7Cnf/2D/mpKyyKewHS1sRq8n7EGOq2PHYGg rSJzPOjefn7RE7ptjexDohJe9vBp9PxO/h2hM0ZkJPjo35xXRshYs3ja2lS3A5ba2N2+ AJhQ1BLPKBLUDPQqgmYmSlws9is/42Y34SzVLlLa4Vf2X17vFrg96aoJUD5lG2xGyPCz 5Z0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8Q1nzeReV4n81loZ84nPso6hHxHo5OWEXcbK9VWi2ko=; b=nP1J69igOdPhGwysLaGomgbWA33AMh7ppUCbFsUCytg9M2Ra+7Yv6yb+/cIRqaaC1C kcf8bl/1U5kcP0uHymt3bY6Xj/CiQOlvRlvbVezZ/V4mXg7bvW7DMDA7HACRvvbpWF2J dWK3J97nbzyDQf5mDmAX8bHVL7B+4Pdje8ChNh8pLE8yzXYdPHlvB6X6BoEjgObOl3x1 JyM+daYj9OreqZdxnVS4ZMNrQxxtaPF6R4ef13h39DnkOp91yRgVk9NtzDE1qnAz+hnR FA+F8aHmRg6fxFeSHtYA+wWql5BUyYopLIjDGFUtAy92W6oThgZuQxQRmKeA56WCgEwS 6wZA== X-Gm-Message-State: AOAM531Pbpni4dQNHRKF1sZCvpLL6lqhTOfSkG3dInk1Y5iDG2TbO7do UdpFi4bktg/ORkJJAbAbbxW59vIKXj8S4mE9L+uhE7UEDpYq2rX3+673gc96YWsylbUWkLU88t6 s4pNs3ksUDAMGyASMxzZgkkjcoPhFRk3iQyNzLCGe8wrVP/rO3fBPFMjWBaeDz5ajLSgWF6VuXv 39WbAA4ftmzxYw9bdqsZ8LirahQfy/Qu75AHjkcX7U5pZ6P0Mgk2j0CSeB4Q== X-Google-Smtp-Source: ABdhPJwNxiuG+XdIEWGSed1M+uBub6iL0AFNclS8Fleua7KB3zolW1BkTEfPbVwpGxqRQYSMye2Gbqqcq3+HrtSPN30= X-Received: by 2002:a19:7f4d:: with SMTP id a74mr47114lfd.618.1611224206345; Thu, 21 Jan 2021 02:16:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Thu, 21 Jan 2021 15:46:44 +0530 Message-ID: Subject: Re: [pgAmin4][Patch] - Kerberos support for Windows Installer To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000792a7a05b9665e91" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000792a7a05b9665e91 Content-Type: multipart/alternative; boundary="000000000000792a7805b9665e8f" --000000000000792a7805b9665e8f Content-Type: text/plain; charset="UTF-8" Hi Dave, Please find the attached updated patch. Thanks, Khushbo On Thu, Jan 21, 2021 at 3:17 PM Dave Page wrote: > Hi > > On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to add the Kerberos support in the Windows >> installer script. >> > > A couple of comments: > > - The file names should be in lower case in the COPY lines. It will still > work of course, but for consistency and style... > Fixed. > - There's no check that the environment variable is set to a valid value. > For others, we have code block like: > > Fixed. > IF NOT EXIST "%PGADMIN_QT_DIR%" ( > ECHO !PGADMIN_QT_DIR! does not exist. > ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable. > EXIT /B 1 > ) > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > --000000000000792a7805b9665e8f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

Please find the att= ached updated=C2=A0patch.

Thanks,
Khushb= o

On Thu, Jan 21, 2021 at 3:17 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jan 2= 1, 2021 at 7:11 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wro= te:
Hi,

Please find the attached patch to add the Kerbe= ros support in the Windows installer script.
<= br>
A couple of comments:

- The file nam= es should be in lower case in the COPY lines. It will still work of course,= but for consistency and style...
Fixed.= =C2=A0
- There's no check that the environ= ment variable is set to a valid value. For others, we have code block like:=

Fixed.=C2=A0
IF NOT EXIST "%PGADMIN_QT_DIR%" (
 =
   ECHO !PGADMIN_QT_DIR! does not exist.
    ECHO=
 Please install Qt and set the=
 PGADMIN_QT_DIR environment variable.
    EXIT /B 1
)
=C2=A0
-- <= br>
Dave Page
Blog: http://pgsnake.blogspot.com
T= witter: @pgsnake

EDB: http://www.enterprisedb.com

--000000000000792a7805b9665e8f-- --000000000000792a7a05b9665e91 Content-Type: application/octet-stream; name="kerberos_win_dep_ver1.patch" Content-Disposition: attachment; filename="kerberos_win_dep_ver1.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kk6p9iie0 ZGlmZiAtLWdpdCBhL01ha2UuYmF0IGIvTWFrZS5iYXQKaW5kZXggYjVkMjkwMWMxLi5kNmIxM2Zm ZjggMTAwNjQ0Ci0tLSBhL01ha2UuYmF0CisrKyBiL01ha2UuYmF0CkBAIC01NSw2ICs1NSw3IEBA IFJFTSBNYWluIGJ1aWxkIHNlcXVlbmNlIEVuZHMKICAgICBFQ0hPIENvbmZpZ3VyaW5nIHRoZSBl bnZpcm9ubWVudC4uLg0KICAgICBJRiAiJVBHQURNSU5fUFlUSE9OX0RJUiUiID09ICIiICAgU0VU ICJQR0FETUlOX1BZVEhPTl9ESVI9QzpcUHl0aG9uMzgiDQogICAgIElGICIlUEdBRE1JTl9RVF9E SVIlIiA9PSAiIiAgICAgICBTRVQgIlBHQURNSU5fUVRfRElSPUM6XFF0XDUuMTQuMlxtc3ZjMjAx N182NCINCisgICAgSUYgIiVQR0FETUlOX0tSQjVfRElSJSIgPT0gIiIgICAgIFNFVCAiUEdBRE1J Tl9LUkI1X0RJUj1DOlxQcm9ncmFtIEZpbGVzXE1JVFxLZXJiZXJvcyINCiAgICAgSUYgIiVQR0FE TUlOX1BPU1RHUkVTX0RJUiUiID09ICIiIFNFVCAiUEdBRE1JTl9QT1NUR1JFU19ESVI9QzpcUHJv Z3JhbSBGaWxlcyAoeDg2KVxQb3N0Z3JlU1FMXDEyIg0KICAgICBJRiAiJVBHQURNSU5fSU5OT1RP T0xfRElSJSIgPT0gIiIgU0VUICJQR0FETUlOX0lOTk9UT09MX0RJUj1DOlxQcm9ncmFtIEZpbGVz ICh4ODYpXElubm8gU2V0dXAgNiINCiAgICAgSUYgIiVQR0FETUlOX1ZDUkVESVNUX0RJUiUiID09 ICIiIFNFVCAiUEdBRE1JTl9WQ1JFRElTVF9ESVI9QzpcUHJvZ3JhbSBGaWxlcyAoeDg2KVxNaWNy b3NvZnQgVmlzdWFsIFN0dWRpb1wyMDE3XFByb2Zlc3Npb25hbFxWQ1xSZWRpc3RcTVNWQ1wxNC4x Ni4yNzAxMiINCkBAIC05Nyw2ICs5OCw3IEBAIFJFTSBNYWluIGJ1aWxkIHNlcXVlbmNlIEVuZHMK ICAgICBFQ0hPIFB5dGhvbiB2ZXJzaW9uOiAgICAgICAgICAgICVQWVRIT05fTUFKT1IlLiVQWVRI T05fTUlOT1IlDQogICAgIEVDSE8uDQogICAgIEVDSE8gUXQgZGlyZWN0b3J5OiAgICAgICAgICAg ICAgJVBHQURNSU5fUVRfRElSJQ0KKyAgICBFQ0hPIEtSQjUgZGlyZWN0b3J5OiAgICAgICAgICAg ICVQR0FETUlOX0tSQjVfRElSJQ0KICAgICBFQ0hPIFBvc3RncmVTUUwgZGlyZWN0b3J5OiAgICAg ICVQR0FETUlOX1BPU1RHUkVTX0RJUiUNCiAgICAgRUNITy4NCiAgICAgRUNITyBWQysrIHJlZGlz dCBkaXJlY3Rvcnk6ICAgICAlUEdBRE1JTl9WQ1JFRElTVF9ESVIlDQpAQCAtMTI5LDYgKzEzMSwx MiBAQCBSRU0gTWFpbiBidWlsZCBzZXF1ZW5jZSBFbmRzCiAgICAgICAgIEVYSVQgL0IgMQ0KICAg ICApDQogDQorICAgIElGIE5PVCBFWElTVCAiJVBHQURNSU5fS1JCNV9ESVIlIiAoDQorICAgICAg ICBFQ0hPICFQR0FETUlOX0tSQjVfRElSISBkb2VzIG5vdCBleGlzdC4NCisgICAgICAgIEVDSE8g UGxlYXNlIGluc3RhbGwgS2Z3IChLZXJiZXJvcykgYW5kIHNldCB0aGUgUEdBRE1JTl9LUkI1X0RJ UiBlbnZpcm9ubWVudCB2YXJpYWJsZS4NCisgICAgICAgIEVYSVQgL0IgMQ0KKyAgICApDQorDQog ICAgIElGIE5PVCBFWElTVCAiJVBHQURNSU5fUVRfRElSJVxiaW5ccW1ha2UuZXhlIiAoDQogICAg ICAgICBFQ0hPICFRTUFLRSEgZG9lcyBub3QgZXhpc3QuDQogICAgICAgICBFQ0hPIFBsZWFzZSBp bnN0YWxsIFF0IGFuZCBzZXQgdGhlIFBHQURNSU5fUVRfRElSIGVudmlyb25tZW50IHZhcmlhYmxl Lg0KQEAgLTI2OCw2ICsyNzYsMTUgQEAgUkVNIE1haW4gYnVpbGQgc2VxdWVuY2UgRW5kcwogICAg IEVDSE8gW1BhdGhzXSA+ICIlQlVJTERST09UJVxydW50aW1lXHF0LmNvbmYiDQogICAgIEVDSE8g UGx1Z2lucz1wbHVnaW5zID4+ICIlQlVJTERST09UJVxydW50aW1lXHF0LmNvbmYiDQogDQorICAg IEVDSE8gU3RhZ2luZyBLZXJiZXJvcyBjb21wb25lbnRzLi4uDQorICAgIElGICIlQVJDSElURUNU VVJFJSIgPT0gIng2NCIgKA0KKyAgICAgICAgQ09QWSAiJVBHQURNSU5fS1JCNV9ESVIlXGJpblxr aW5pdC5leGUiICIlQlVJTERST09UJVxydW50aW1lIiA+IG51bCB8fCBFWElUIC9CIDENCisgICAg ICAgIENPUFkgIiVQR0FETUlOX0tSQjVfRElSJVxiaW5ca3JiNV82NC5kbGwiICIlQlVJTERST09U JVxydW50aW1lIiA+IG51bCB8fCBFWElUIC9CIDENCisgICAgICAgIENPUFkgIiVQR0FETUlOX0tS QjVfRElSJVxiaW5cY29tZXJyNjQuZGxsIiAiJUJVSUxEUk9PVCVccnVudGltZSIgPiBudWwgfHwg RVhJVCAvQiAxDQorICAgICAgICBDT1BZICIlUEdBRE1JTl9LUkI1X0RJUiVcYmluXGs1c3BydDY0 LmRsbCIgIiVCVUlMRFJPT1QlXHJ1bnRpbWUiID4gbnVsIHx8IEVYSVQgL0IgMQ0KKyAgICAgICAg Q09QWSAiJVBHQURNSU5fS1JCNV9ESVIlXGJpblxnc3NhcGk2NC5kbGwiICIlQlVJTERST09UJVxy dW50aW1lIiA+IG51bCB8fCBFWElUIC9CIDENCisgICAgKQ0KKw0KICAgICBFQ0hPIFN0YWdpbmcg UG9zdGdyZVNRTCBjb21wb25lbnRzLi4uDQogICAgIENPUFkgIiVQR0FETUlOX1BPU1RHUkVTX0RJ UiVcYmluXGxpYnBxLmRsbCIgIiVCVUlMRFJPT1QlXHJ1bnRpbWUiID4gbnVsIHx8IEVYSVQgL0Ig MQ0KICAgICBJRiAiJUFSQ0hJVEVDVFVSRSUiID09ICJ4NjQiICgNCg== --000000000000792a7a05b9665e91--