Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jE9Ow-0008RQ-Au for pgadmin-hackers@arkaria.postgresql.org; Tue, 17 Mar 2020 10:24:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jE9Ov-0006l6-5P for pgadmin-hackers@arkaria.postgresql.org; Tue, 17 Mar 2020 10:24:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jE9Ou-0006kz-Qj for pgadmin-hackers@lists.postgresql.org; Tue, 17 Mar 2020 10:24:44 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jE9Or-0001eK-MC for pgadmin-hackers@postgresql.org; Tue, 17 Mar 2020 10:24:43 +0000 Received: by mail-lj1-x229.google.com with SMTP id f13so22162158ljp.0 for ; Tue, 17 Mar 2020 03:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kRA5ERhQN12x/7qvJX/JPPH3tY8oNmCr/Kmc5K4/NJc=; b=aNCDQA6qVD/tQZuP50kO0Js74v9rz/PoeowEMnYwgOOHc93aRFaeet9TPMJn8/fkyv mpFUxA0xea3v3/RqJCI0TqdVoICRjp6jcR6DJo+LH/RWyKX03xmvuK7Z8lR7PQ20Eymi vXfovR1sbgw9v0BQ9qyxf77/LHEPrg21xvtORV8Oc8NhjTga4kYh0dguVroXZ6x494UU vQd35D/OJmdwhA9sslqfK3A/q4fuUcVd4wCNWNm3FJPF1RJH1bYnqlmtm/qFDI+bawJy Nr0GcoX3VvAj9iCNA6kE3I9txDeFGNBUZVIDXZLqGa7JLSYz54Hm8w2o0VPOVxu3lChX P0Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kRA5ERhQN12x/7qvJX/JPPH3tY8oNmCr/Kmc5K4/NJc=; b=Us/nbiVITGN0fIsp7cNGxqXu0n3dHSe3GNTgQlQ/CyMu4m5FCljbOGlHeVetwcRKtR nMFdpEOFCZd0TfwRnwl8G5BinHl0ebPN1VvvJMXh+ioHcbVOLm966P0BexB+CQ1s8nN1 vJhiYFPJ3KW0fbRFbh+wxLmt/9HTMR1rOzA0pYZ+1hkK4JOCURaH4+KxCrFcGaGerH7p LUS3dnUuchCV6MmII64sw5hfSq6z3jAB+9rNK54nYsJO8rh958lmVbki7MF14EV7dv8A nIimX6j+XYv60ETQX9LlhRLSRCz+Me41nxqAxBL1WkUME0OJXqy3unbKMm9xC1UzFCnQ KSwA== X-Gm-Message-State: ANhLgQ0c4T/UFIuWDwgGIW8MIdlHeKv4tKwkXDWkuihWR+0CxzKpzT2S Y1/NTH5dCBpuJxKjTdEihGbpaDX5zM4qAOcvsPixWFvU4iJiQ/QYqVXnS3I33RJXsV5QWmiflJe LAGVNFsH42T2YlWNlFgz1otqbX+AGzEag4WG+kRyY+LQ8aBft/1Ys1C2IFn3zFUjPGRk3Bs/5Ov X6GqmNdFnBeQEbdv2cM2vqZ3m2DKezndhzahvj+OU/E6g9HYArNns= X-Google-Smtp-Source: ADFU+vtPHQrVb2r3HBb8UyFKY76SEEEt+uf9cvv9KshDMiArIwK+6nIyVxuJS6NqhnwgN7MGpadH86vXcYPVdDn62CI= X-Received: by 2002:a2e:95c8:: with SMTP id y8mr2333199ljh.153.1584440679724; Tue, 17 Mar 2020 03:24:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Tue, 17 Mar 2020 15:54:32 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP] To: navnath gadakh Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e2165305a10a5783" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e2165305a10a5783 Content-Type: text/plain; charset="UTF-8" Hi Navnath, On Tue, Mar 17, 2020 at 3:37 PM navnath gadakh < navnath.gadakh@enterprisedb.com> wrote: > Hi Khushboo, > I think there is no use of > > + if app is not None: > + AuthSourceRegistry.load_auth_sources() > + > > in get_auth_sources() function. > > Thanks for the review, I will look into it. Thanks, Khushboo > > On Tue, Mar 17, 2020 at 2:25 PM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to support LDAP Authentication in Server >> mode. >> To test the patch, config_auth.py needs to be configured for LDAP >> configurations. The config settings are explained in this file in detail. >> After configuring the parameters, start the pgadmin server in Server mode >> and connect with LDAP server with the valid user via login page. >> >> I have tested this patch with ldap and ldap + ssl/tls. With the TLS, I >> have used the default config of ldap3 without certificates. >> >> @Dave, can you please review this patch, as you have a better >> understanding of LDAP and you can easily pointed out if I have missed >> anything. >> >> Note: For the document update I will create the task and assign to Nidhi >> for the same. >> >> Thanks, >> Khushboo >> > > > -- > *-- Navnath* > --000000000000e2165305a10a5783 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Navnath,

On Tue, Mar 17, 2020 at 3:37 PM navnath ga= dakh <navnath.gadakh@= enterprisedb.com> wrote:
Hi Khushboo,
=C2=A0 = =C2=A0 =C2=A0 =C2=A0I think there is no use of=C2=A0

+ =C2=A0 =C2=A0if app is not None:
+ =C2=A0 =C2=A0 =C2= =A0 =C2=A0AuthSourceRegistry.load_auth_sources()
+

=
in=C2=A0get_auth_sources() function.

=
Thanks for the review, I will look into it.

Thanks,
Khushboo=C2=A0

=
On Tue, Mar 17, 2020 at 2:25 PM Khush= boo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

<= div>Please find the attached patch to support LDAP Authentication in Server= mode.
To test the patch, config_auth.py needs to be configured f= or LDAP configurations. The config settings are explained in this file in d= etail. After configuring the parameters, start the pgadmin server in Server= mode and connect with LDAP server with the valid user via login page.

I have tested this patch with ldap and ldap=C2=A0+ ssl= /tls. With the TLS, I have used the default config of ldap3 without certifi= cates.

@Dave, can you please review this patch, as= you have a better understanding of LDAP and you can easily pointed out if = I have missed anything.

Note: For the document upd= ate I will create the task and assign to Nidhi for the same.

Thanks,
Khushboo


--
<= div dir=3D"ltr">
-- Navnath
=
--000000000000e2165305a10a5783--