MIME-Version: 1.0
References: 
 <CANxoLDcU_NqABtQA2H5zsFjK6Pb8evdGOBoNGxekvx9KroRmow@mail.gmail.com>
In-Reply-To: 
 <CANxoLDcU_NqABtQA2H5zsFjK6Pb8evdGOBoNGxekvx9KroRmow@mail.gmail.com>
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Date: Mon, 6 Jan 2020 12:01:24 +0530
Message-ID: 
 <CAFOhELfN6FvKObhO_Qe8OdkjgbjHzz3R03Jf5Rv-LBghPfq0QQ@mail.gmail.com>
Subject: Re: [pgAdmin][RM4633] Bad view in partitioned tables
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000007a10b5059b72cfc5"
Precedence: bulk

--0000000000007a10b5059b72cfc5
Content-Type: text/plain; charset="UTF-8"

Hi Akshay,

On Fri, Jan 3, 2020 at 4:58 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Hackers
>
> Attached is the patch to support the view part of the multilevel
> partitions. Users can perform all the operations except creating the
> partitions as a partitioned table. Users can create a partition table
> separately and attach it as a partition of another partition table.
>
Multilevel partitions are now manageable through the tree view except
creating a partition table of existing partition (which you already
mentioned).
One more problem that we already discussed that automatic tree refresh of
the multilevel partitions is not working due to our structure which is
going to be handled by the new RM.

Some of the minor review comments.
- _get_children_nodes name can be changed as it more like private method
but we are using it outside of the class itself.
- Stats of partition table is not displayed, but I think that is not
related to this patch, so can be fixed later.

Thanks,
Khushboo

>
> There are two problems mentioned in the RM. I have fixed the first one and
> we won't fix the second problem as by design we decided to show Partitions
> like Schema->Table->Partitions
>
> Please review it.
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--0000000000007a10b5059b72cfc5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Akshay,</div><br><div class=3D"gmail_quote"><div d=
ir=3D"ltr" class=3D"gmail_attr">On Fri, Jan 3, 2020 at 4:58 PM Akshay Joshi=
 &lt;<a href=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterpri=
sedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D=
"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-le=
ft:1ex"><div dir=3D"ltr">Hi Hackers<div><br></div><div>Attached=C2=A0is the=
 patch to support the view part of the multilevel partitions. Users can per=
form all the operations except creating the partitions as a partitioned tab=
le. Users can create a partition table separately and attach it as a partit=
ion of another partition table.=C2=A0</div></div></blockquote><div><font co=
lor=3D"#000000">Multilevel partitions are now manageable through the tree v=
iew except creating a partition table of existing partition (which you alre=
ady mentioned).</font></div><div><font color=3D"#000000">One more problem t=
hat we already discussed that automatic tree refresh of the multilevel part=
itions is not working due to our structure which is going to be handled by =
the new RM.=C2=A0=C2=A0</font></div><div><br></div><div>Some of the minor r=
eview comments.</div><div><font face=3D"arial, sans-serif" color=3D"#000000=
">-=C2=A0_get_children_nodes name can be changed as it more like private me=
thod but we are using it outside of the class itself.</font></div><div><fon=
t face=3D"arial, sans-serif" color=3D"#000000">- Stats of partition table i=
s not displayed, but I think that is not related to this patch, so can be f=
ixed later.</font></div><div><font face=3D"arial, sans-serif" color=3D"#000=
000"><br></font></div><div><font face=3D"arial, sans-serif" color=3D"#00000=
0">Thanks,</font></div><div><font face=3D"arial, sans-serif" style=3D"" col=
or=3D"#000000">Khushboo</font></div>


<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div><br=
></div><div>There are two problems mentioned in the RM. I have fixed the fi=
rst one and we won&#39;t fix the second problem as by design we decided to =
show Partitions like Schema-&gt;Table-&gt;Partitions</div><div><br></div><d=
iv>Please review it.</div><div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><di=
v><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">=
<div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family=
:arial,sans-serif;font-size:13px;border-collapse:collapse">Thanks &amp; Reg=
ards</span></b></font></div><div><font color=3D"#3333FF"><b><span style=3D"=
color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collaps=
e:collapse">Akshay Joshi</span></b></font></div><div><font color=3D"#3333FF=
"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size=
:13px;border-collapse:collapse">Sr. Software Architect<br></span></b></font=
></div><div><span style=3D"border-collapse:collapse"><font color=3D"#000000=
" face=3D"arial, sans-serif"><b>EnterpriseDB Software India Private Limited=
</b></font><br></span></div><div><b style=3D"color:rgb(51,51,255)"><span st=
yle=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-=
collapse:collapse">Mobile: +91 976-788-8246</span></b><br></div></div></div=
></div></div></div></div></div></div></div></div>
</blockquote></div></div>

--0000000000007a10b5059b72cfc5--