public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][Patch]: Fixed RM 1470
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][Patch]: Fixed RM 1470
@ 2016-08-03 12:01 Khushboo Vashi <[email protected]>
  2016-08-03 14:44 ` Re: [pgAdmin][Patch]: Fixed RM 1470 Dave Page <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Khushboo Vashi @ 2016-08-03 12:01 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Please find the attached patch for the RM 1470: [Desktop Runtime
Application] User can not drop domain.

The issue was produced because of execute_2darray function change. Now I
have changed the way of variable assignment to fix this issue.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] RM_1470.patch (730B, 3-RM_1470.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/domains/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/domains/__init__.py
index 076e288..c94525a 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/domains/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/domains/__init__.py
@@ -578,7 +578,8 @@ AND relkind != 'c'))"""
                     )
                 )
 
-            name, basensp = res['rows'][0]
+            name  = res['rows'][0]['name']
+            basensp = res['rows'][0]['basensp']
 
             SQL = render_template("/".join([self.template_path,
                                             'delete.sql']),


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][Patch]: Fixed RM 1470
  2016-08-03 12:01 [pgAdmin][Patch]: Fixed RM 1470 Khushboo Vashi <[email protected]>
@ 2016-08-03 14:44 ` Dave Page <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-08-03 14:44 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Wed, Aug 3, 2016 at 1:01 PM, Khushboo Vashi
<[email protected]> wrote:
> Hi,
>
> Please find the attached patch for the RM 1470: [Desktop Runtime
> Application] User can not drop domain.
>
> The issue was produced because of execute_2darray function change. Now I
> have changed the way of variable assignment to fix this issue.
>
> Thanks,
> Khushboo
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-08-03 14:44 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 12:01 [pgAdmin][Patch]: Fixed RM 1470 Khushboo Vashi <[email protected]>
2016-08-03 14:44 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox