MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxoz+LZ-PO--N6B-y6cecJ3QhCF9pOo7V-wJg_AUc9jcHUw@mail.gmail.com>
References: 
 <CAFOhELeqEBG3qd+Fe8nLfpc1SuJpkJzuzPmy1-jogD0220WiLw@mail.gmail.com>
	<CAFOhELfm9y9jQLLzvnQpKey5TX=yZkL+qaF=6g+CsvuWKFDh2w@mail.gmail.com>
	<CAFOhELekGKVKaMQt9L_itJw2WGdG69yVdiJDfq=1BPz3OjRJiw@mail.gmail.com>
	<CACCA4P0Q_9DBt43asNze9OjkJ+xya_m_cmf3DMoZB3HKWLKidw@mail.gmail.com>
	<CAFOhELf1EwMw5dgPTfTp+50C5GOWmrC0bOmbYqZBCUKNay83VA@mail.gmail.com>
	<CA+OCxoz+LZ-PO--N6B-y6cecJ3QhCF9pOo7V-wJg_AUc9jcHUw@mail.gmail.com>
Date: Wed, 4 May 2016 16:49:38 +0530
Message-ID: 
 <CAFOhELfY2HsJ25-KQ4eNmJpKHi8n91CDxAM_zdV=05R2DpTowg@mail.gmail.com>
Subject: Re: [pgAdmin4] [Patch]: Foreign Table Module
From: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
To: Dave Page <dave.page@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a11401516b6be9f05320266dc
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a11401516b6be9f05320266dc
Content-Type: text/plain; charset=UTF-8

Hi,

On Wed, May 4, 2016 at 4:37 PM, Dave Page <dave.page@enterprisedb.com>
wrote:

> Hi
>
> On Wed, May 4, 2016 at 7:51 AM, Khushboo Vashi
> <khushboo.vashi@enterprisedb.com> wrote:
> > Hi Dave,
> >
> > In PG 9.5, for Foreign Table Editing, below new functionalities are
> added:
> >
> > ALTER [ COLUMN ] column_name SET STORAGE { PLAIN | EXTERNAL | EXTENDED |
> > MAIN }
> > DISABLE TRIGGER [ trigger_name | ALL | USER ]
> > ENABLE TRIGGER [ trigger_name | ALL | USER ]
> > ENABLE REPLICA TRIGGER trigger_name
> > ENABLE ALWAYS TRIGGER trigger_name
> > SET WITH OIDS
> > SET WITHOUT OIDS
> >
> > As per our conversation yesterday, we need to incorporate these
> > functionalities into pgAdmin4. Here I have some queries regarding the
> > implementation. Under the Foreign Table Node, we don't have separate
> nodes
> > for columns, triggers and constraints as table. So in order to add above
> > Trigger related functionalities, we will have to add Trigger Node under
> the
> > Foreign Table. And If we add Triggers, then Do we need to add Columns and
> > Constraints as separate nodes under the Foreign Table?
>
> Following discussion with Ashesh and some further thought, please put
> these enhancements on hold. We'll add them in a future release, as
> it's just too much work to do right now.
>
> Okay.


> Please add a TODO file to the root directory of pgAdmin 4, and add
> these as items for later completion.
>
> Sure. I will do that.


> Thanks.
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>

--001a11401516b6be9f05320266dc
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><div><div class=3D"gmail_extra"><br><div class=3D"g=
mail_quote">On Wed, May 4, 2016 at 4:37 PM, Dave Page <span dir=3D"ltr">&lt=
;<a href=3D"mailto:dave.page@enterprisedb.com" target=3D"_blank">dave.page@=
enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote"=
 style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi=
<br>
<span class=3D""><br>
On Wed, May 4, 2016 at 7:51 AM, Khushboo Vashi<br>
&lt;<a href=3D"mailto:khushboo.vashi@enterprisedb.com">khushboo.vashi@enter=
prisedb.com</a>&gt; wrote:<br>
&gt; Hi Dave,<br>
&gt;<br>
&gt; In PG 9.5, for Foreign Table Editing, below new functionalities are ad=
ded:<br>
&gt;<br>
&gt; ALTER [ COLUMN ] column_name SET STORAGE { PLAIN | EXTERNAL | EXTENDED=
 |<br>
&gt; MAIN }<br>
&gt; DISABLE TRIGGER [ trigger_name | ALL | USER ]<br>
&gt; ENABLE TRIGGER [ trigger_name | ALL | USER ]<br>
&gt; ENABLE REPLICA TRIGGER trigger_name<br>
&gt; ENABLE ALWAYS TRIGGER trigger_name<br>
&gt; SET WITH OIDS<br>
&gt; SET WITHOUT OIDS<br>
&gt;<br>
&gt; As per our conversation yesterday, we need to incorporate these<br>
&gt; functionalities into pgAdmin4. Here I have some queries regarding the<=
br>
&gt; implementation. Under the Foreign Table Node, we don&#39;t have separa=
te nodes<br>
&gt; for columns, triggers and constraints as table. So in order to add abo=
ve<br>
&gt; Trigger related functionalities, we will have to add Trigger Node unde=
r the<br>
&gt; Foreign Table. And If we add Triggers, then Do we need to add Columns =
and<br>
&gt; Constraints as separate nodes under the Foreign Table?<br>
<br>
</span>Following discussion with Ashesh and some further thought, please pu=
t<br>
these enhancements on hold. We&#39;ll add them in a future release, as<br>
it&#39;s just too much work to do right now.<br>
<br></blockquote><div><span style=3D"color:rgb(0,0,255)">Okay</span>.<br>=
=C2=A0<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8e=
x;border-left:1px #ccc solid;padding-left:1ex">
Please add a TODO file to the root directory of pgAdmin 4, and add<br>
these as items for later completion.<br>
<br></blockquote><div><span style=3D"color:rgb(0,0,255)">Sure. I will do th=
at.</span><br>=C2=A0<br></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks.<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
Dave Page<br>
VP, Chief Architect, Tools &amp; Installers<br>
EnterpriseDB: <a href=3D"http://www.enterprisedb.com" rel=3D"noreferrer" ta=
rget=3D"_blank">http://www.enterprisedb.com</a><br>
The Enterprise PostgreSQL Company<br>
<br>
Blog: <a href=3D"http://pgsnake.blogspot.com" rel=3D"noreferrer" target=3D"=
_blank">http://pgsnake.blogspot.com</a><br>
Twitter: @pgsnake<br>
</font></span></blockquote></div><br></div></div></div>

--001a11401516b6be9f05320266dc--