public inbox for [email protected]
help / color / mirror / Atom feedFrom: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.
Date: Tue, 6 Jun 2017 18:45:00 +0530
Message-ID: <CAFOhELfZmHJC=FoB5GXwrTaepxD1wQSrX9SyfKkK-Qt4Fs93hQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxow4oGzbgVuXZVFfq56GNyVwR4F63YGpg=71Mamv+n96fQ@mail.gmail.com>
References: <CAFOhELd8B=ALRSiZwEb0dVZwN8iGyCYu1=Tzk46A=MA3XTfu3w@mail.gmail.com>
<CAKKotZTUdfgBftsznMamYuLZB8SbK24FviwfQJ-7Hoqk_fnyhQ@mail.gmail.com>
<CAFOhELeXLioibqoyEGeB4EwGk=FC5D0DQqnX2ZnHiWYFrt4YuA@mail.gmail.com>
<CAKKotZSeqiwB8Jo8Hx_wBtp92q0kDF4Z_SN7oCt8abU76zjL9A@mail.gmail.com>
<CAFOhELe-Bmq9Ah=KWBP_2pPfqiYrpAUaP_hKp3-i-8CODEtoqQ@mail.gmail.com>
<CA+OCxoy6mynKBRDGf4LHXXj9mQHpcq0tP-QRqwzxSrEQWUhM2A@mail.gmail.com>
<CAFOhELdfX3u4PzOxmv5-e1E3kjqWZNTCh=7faGzxB-1=J1JRqA@mail.gmail.com>
<CA+OCxow4oGzbgVuXZVFfq56GNyVwR4F63YGpg=71Mamv+n96fQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On 6 Jun 2017 18:36, "Dave Page" <[email protected]> wrote:
On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.
com> wrote:
>
>
> On 6 Jun 2017 17:42, "Dave Page" <[email protected]> wrote:
>
> Hi
>
> The table and column dialogues seem to have related problems. For example,
> the table dialogue shows the length of the geometry field in the test case
> as 847,380, whilst the column dialogue shows no length at all.
>
> What should be there in length and precision fields in this case?
>
I have no idea :-). What did pgAdmin 3 do here? I assume there's some way
to decode the typmod into the desired values, and map them back to
appropriate SQL.
I will try to figure out the way.
pgAdmin 3 has the same issue, so I have asked for the suggestion.
> Also, I there should be a space between the , and value in the_geom
> geometry(MultiPolygon,3310).
>
> Thanks.
>
> On Mon, Jun 5, 2017 at 8:32 AM, Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> Fixed PostGIS datatype on SQL tab for Table, column, Foreign Table and
>> Type node.
>>
>> Please find the attached updated patch.
>>
>>
>> Thanks,
>> Khushboo
>>
>> On Thu, Jun 1, 2017 at 6:36 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>>
>>> On Thu, Jun 1, 2017 at 5:27 PM, Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>>
>>>> On Thu, Jun 1, 2017 at 4:57 PM, Murtuza Zabuawala <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> Please include Type node and Foreign Table node in your fix :-)
>>>>>
>>>>> I don't think Type node requires this change.
>>>>
>>>> Yes, It do require because user can create composite type from existing
>>> types.
>>> [image: Inline image 1]
>>>
>>>> Foreign table changes added in the attached updated patch.
>>>>
>>>>> --
>>>>>
>>>> Thanks Murtuza for pointing this out.
>>
>>
>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>> On Thu, Jun 1, 2017 at 3:23 PM, Khushboo Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch to fix RM #2324 : PostGIS datatypes
>>>>>> not showing up properly on SQL tab.
>>>>>>
>>>>>> Thanks,
>>>>>> Khushboo
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent via pgadmin-hackers mailing list ([email protected]
>>>>>> )
>>>>>> To make changes to your subscription:
>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] image.png (71.5K, 3-image.png)
download | view image
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.
In-Reply-To: <CAFOhELfZmHJC=FoB5GXwrTaepxD1wQSrX9SyfKkK-Qt4Fs93hQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox