Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qW7zU-002DZm-4k for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Aug 2023 04:18:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qW7zS-002nFB-RP for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Aug 2023 04:18:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qW7zS-002nF3-Ii for pgadmin-hackers@lists.postgresql.org; Wed, 16 Aug 2023 04:18:38 +0000 Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qW7zO-000PFo-P1 for pgadmin-hackers@postgresql.org; Wed, 16 Aug 2023 04:18:37 +0000 Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-589c7801d1cso49607517b3.0 for ; Tue, 15 Aug 2023 21:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1692159512; x=1692764312; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fp64G9yMcXYoo3tRA0/TeFi10BwghWVeZK3jGEz7yQ4=; b=KlynjdTN2AeHCym0ylTYa23DoGxZvKFmI8zFb1VaYYGmCz1rdUWWda7Fr8gInS71pn 5S0P96NruoAlgrOYYcVJOlZqxAgHSmslVRwVXCcje/9xR/p57iG4k40asstBeV+rc7P2 xgOOBBkKEcdD2MxfMQrgnhHl0o50JAqchUJHAxST/JJQXPDtt9yu49iYAfN3m6rXwa7O 8JTsM3R+90JTo0ik63mYpDr/uo0PBV1CgXAzVWhXI9/sRAKnRvC6tYaoCjqyVSv5C7bu C/w72Hlnbwe3poZG2sIUeJ2T8vyV+q3yT7cRfRreke4E09pQMQ8l6p8PqGliCUPJA8Gp HYMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692159512; x=1692764312; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fp64G9yMcXYoo3tRA0/TeFi10BwghWVeZK3jGEz7yQ4=; b=EMiipww+SmYQXol22fpasRheidDPXCTRlOzkXAEi5QIDYjAYMQohRl5lGF5SjCcu2d SXY+P7bw82EpSmCumHIL0uRergVlPwiWTboF3MeWH59j1yu6DVX4VXvB++/2NxLXKE0E rQQNjdhFPq2LKDL02L6wZqrB0luX6DuRW9io7k0BfKYmHMtWKpADdlhINnQsE/FwEE4D oFwSY5gwWAfWcuXuBdqbJy4fp9Ol1vh//1KnuCU4XXvGz54/gEgqXpRZ31e6JEiFqmVL Vgs76vrNuOva1MeSEPh3ao49YoP5VPlbViS677F1QZqVJOCDSuw38kh6QpV4fq7st4ra SIyA== X-Gm-Message-State: AOJu0Yy3f5FP/dONdjUtBP1xYM9wPM/JlfoCxritr3885rg1ko3fAfzy AujAMJIcuFlNssLv1GnLt4mgiI915D0IMYfMTIJp8Q== X-Google-Smtp-Source: AGHT+IGIFIglH1uU92gw9PhsmwzSrReEyxo6nZsxf+pH+TTT/XtwXmDztx437e6yGw+3l2tVho0WzZTgdwF4uorjsu0= X-Received: by 2002:a0d:e305:0:b0:57a:8de9:16a3 with SMTP id m5-20020a0de305000000b0057a8de916a3mr612466ywe.8.1692159512392; Tue, 15 Aug 2023 21:18:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Wed, 16 Aug 2023 09:48:21 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Sahil Harpal Cc: Aditya Toshniwal , pgadmin-hackers@postgresql.org, Ashesh Vashi , Dave Page , Akshay Joshi Content-Type: multipart/alternative; boundary="000000000000a3df6306030296ef" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000a3df6306030296ef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Can you please rebase the patch and send it again? On Thu, Aug 10, 2023 at 12:37=E2=80=AFAM Sahil Harpal wrote: > Hi all, > > I have attached the updated patch with recent changes. > > New changes: > > 1. Displayed the appropriate message If the System Stat extension does > not exist. > 2. Provided option to configure refresh rates for the API calls > (Preferences settings > Dashboards > Refresh rates). > 3. Added I/O analysis of block devices under the storage tab. > 4. Fixed PEP-8 errors. > 5. Fixed the linter errors. > 6. Moved all the system stats related .jsx files under a > seperate folder "dashboard/static/js/SystemStats". > 7. Added formatter to convert disk sizes (in bytes) to human readable > format. > > Pending Work: > > 1. Process information - > - Issue: The pg_sys_process_info() query takes much longer (more > than 2 mins) to execute and prevents the updation of other graphs a= nd > tables. > 2. Disk information - > - Issue: The pg_sys_disk_info() query returns NULL value for some > of the drive letters. > 3. StreamingChart - > - Issue: Graph shifting glitch. For the first time, graphs start > from the opposite side, and after the following API call or a few s= econds > later, those get adjusted. > > I need suggestions for labels for different tables and charts. Also, coul= d > you please clarify the use of the counterData variable, which is used for > some of the charts (tps_stats, ti_stats, to_stats, and bio_stats)? > > Thank you, > Sahil > > --000000000000a3df6306030296ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Can you please rebase the patch and send it again?
On = Thu, Aug 10, 2023 at 12:37=E2=80=AFAM Sahil Harpal <sahilharpal1234@gmail.com> wrote:
=
Hi all,<= div>
I have attached the updated patch with recent=C2=A0chang= es.

New changes:
  1. Displayed the a= ppropriate message If the System Stat extension does not exist.
  2. Pro= vided option to configure refresh rates for the API calls (Preferences sett= ings > Dashboards > Refresh rates).
  3. Added I/O analysis of blo= ck devices under the storage tab.
  4. Fixed PEP-8 errors.
  5. Fixed= the linter errors.
  6. Moved all the system stats related .jsx files u= nder a seperate=C2=A0folder "dashboard/static/js/SystemStats".
  7. Added formatter=C2=A0t= o convert disk sizes (in bytes) to human readable format.
<= /div>Pending Work:
  1. Process information -
    • Issue: The= pg_sys_process_info() query takes much longer (more than 2 mins) to execut= e and prevents the updation of other graphs and tables.=C2=A0
  2. = Disk information -
    • Issue: The=C2=A0pg_sys_disk_info() query ret= urns NULL value for some of the drive letters.
  3. StreamingChart = -=C2=A0
    • Issue: Graph shifting=C2=A0glitch.=C2=A0For the first time, graphs start fro= m the opposite side, and after the following API call or a few seconds late= r, those get adjusted.
I need suggestions for labels for= different tables and charts. Also, could you please clarify the use of the= counterData variable, which is used for some of the charts (tps_stats, ti_= stats, to_stats, and bio_stats)?

Thank y= ou,
Sahil

3D""
--000000000000a3df6306030296ef--