public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect
@ 2016-10-07 11:28 Khushboo Vashi <[email protected]>
2016-10-07 11:57 ` Re: [pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect Dave Page <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Khushboo Vashi @ 2016-10-07 11:28 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
Please find the attached patch to fix the RM 1785: PPAS Servers are
consider to be PostgreSQL until after the first disconnect/reconnect
Issue:
After creating a new server, the icon and the server type were not set
properly in the response, so fixed both in the response.
Thanks,
Khushboo
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/x-patch] RM_1785.patch (1.1K, 3-RM_1785.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py
index a6fe620..a128f2b 100644
--- a/web/pgadmin/browser/server_groups/servers/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/__init__.py
@@ -623,18 +623,17 @@ class ServerNode(PGChildNodeView):
user = manager.user_info
connected = True
- icon = "icon-pg"
return jsonify(
node=self.blueprint.generate_browser_node(
"%d" % server.id, server.servergroup_id,
server.name,
- icon,
+ 'icon-{0}'.format(manager.server_type) if manager.server_type else "icon-pg",
True,
self.node_type,
user=user,
connected=connected,
- server_type='pg' # Default server type
+ server_type=manager.server_type if manager.server_type else 'pg'
)
)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect
2016-10-07 11:28 [pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect Khushboo Vashi <[email protected]>
@ 2016-10-07 11:57 ` Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-10-07 11:57 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Fri, Oct 7, 2016 at 12:28 PM, Khushboo Vashi
<[email protected]> wrote:
> Hi,
>
> Please find the attached patch to fix the RM 1785: PPAS Servers are
> consider to be PostgreSQL until after the first disconnect/reconnect
>
> Issue:
> After creating a new server, the icon and the server type were not set
> properly in the response, so fixed both in the response.
>
> Thanks,
> Khushboo
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-10-07 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-10-07 11:28 [pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect Khushboo Vashi <[email protected]>
2016-10-07 11:57 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox