public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
To: Joao Pedro De Almeida Pereira <[email protected]>
To: [email protected]
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t
Date: Wed, 14 Mar 2018 20:07:10 +0530
Message-ID: <CAFOhELfb1KY7zhzSOYvtn3R7FYmTXN6RcZ82NsgFNAeTXuv-hQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi Joao/Victoria,

I am getting an error while editing the server properties. Please refer the
attached screen-shot for the same.

Thanks,
Khushboo

On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <[email protected]> wrote:

> Refactor server dialogue validation for better unit testing.
>
> Victoria & Joao @ Pivotal.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 6b03cb78af607b04c75de44d635bf201babb4c5a
> Author: Victoria Henry <[email protected]>
>
> Modified Files
> --------------
> web/package.json                                   |   3 +-
> .../server_groups/servers/static/js/server.js      | 113
> ++-------------------
> web/pgadmin/static/bundle/browser.js               |   2 +-
> web/pgadmin/static/js/browser/index.js             |  10 ++
> .../static/js/browser/server_groups/index.js       |  10 ++
> .../server_groups/servers/databases/index.js       |  10 ++
> .../js/browser/server_groups/servers/index.js      |  11 ++
> .../server_groups/servers/model_validation.js      | 104
> +++++++++++++++++++
> .../server_groups/servers/model_validation_spec.js | 101
> ++++++++++++++++++
> web/yarn.lock                                      |  46 ++++++++-
> 10 files changed, 299 insertions(+), 111 deletions(-)
>
>


Attachments:

  [image/png] Screen Shot 2018-03-14 at 8.01.46 pm.png (474.1K, 3-Screen%20Shot%202018-03-14%20at%208.01.46%20pm.png)
  download | view image

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t
  In-Reply-To: <CAFOhELfb1KY7zhzSOYvtn3R7FYmTXN6RcZ82NsgFNAeTXuv-hQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox