Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQPjw-0004HO-Pa for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jun 2018 04:08:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQPju-0000Hw-Uq for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jun 2018 04:08:02 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQPju-0000Hk-4q for pgadmin-hackers@lists.postgresql.org; Wed, 06 Jun 2018 04:08:02 +0000 Received: from mail-ot0-x244.google.com ([2607:f8b0:4003:c0f::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQPjl-0000yi-8q for pgadmin-hackers@postgresql.org; Wed, 06 Jun 2018 04:08:00 +0000 Received: by mail-ot0-x244.google.com with SMTP id i19-v6so5528385otk.10 for ; Tue, 05 Jun 2018 21:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0FHmyhPOigLYbcL0Um4Ds9Ku7dJUX7vsuhBVu4K/W/Y=; b=bdgD0WHxm5NIAoNS2Wn5ZfmwJIdWh5vpZ273f65F+Z+u53DDh139pWJXZvgvCZm2dP GYFv5FfQPOVrpGsQRM4SYbBzHF7qE16/ZENkqe6NhoxQq4iWIuS5ZK3m4wlaS2FdsIq6 pvVqBqJggd1eW5lEN8sUuq8VAw9ig9xII3QuOMMzrnEaJPtIvfok7S7Csk1DDFwITV+g rP+o/xB9lbzEt9esy2MnB+pz4/StMY01mBcGQs/zsi0u7BUHy0OEwDu/Bx9M6jOWgDXu 9o53Maa2SQ3inN2Xi1TOBohFrAd+ko+MPw1e/6ICkCB4pSKr6GCTggeH+UI9raBxZ8bK snow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0FHmyhPOigLYbcL0Um4Ds9Ku7dJUX7vsuhBVu4K/W/Y=; b=HsGjtDyJUBfc5g2ChhWfaxEeHMNSEefTY25ODVH+0vvvAC2SaeNAS33Zx1qlgmFdzY 0EJiupzkaEeVIO8q96i1YxpXjpD4+PM20oip5EELvADLMKKgt9xIjegTgmgHi1rzlPQV OelrJhoZb8klQkcBvJnBAoZz1oICW1o/i/KSndyjwG6EthgTQYqVcZrutVr7NUDahch6 f7tJ8M9VDibyV8zEhAhCcvPgYliJEoMCEVXs7lqfuHco3BmeUfaSUdH5q4wGQJX0wukD WGy0FnhWeRb3YuGE+2HVgQk0/acAlPImtFpU9gpbYYe+NobfXscdHkmKoyVFUGL2Vgts /jOg== X-Gm-Message-State: APt69E1yH5nEaXijxKz7qEcgiPmieVJaefeU/l8pHFoVJ2XDXROOt2Y+ dcYu6G5fqJbtvp0pwZPeL3bvBCfew10NkZkf+c+ZkQ== X-Google-Smtp-Source: ADUXVKIAUvp+rv0qgy7o6pKmJPIAPC2vDHR9mohJQaCXq2s8j63aA6HkP/BJcfedJBKVN0E59Y9ZmpKAVYzo3jswn4A= X-Received: by 2002:a9d:428c:: with SMTP id r12-v6mr872926ote.296.1528258072032; Tue, 05 Jun 2018 21:07:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:4081:0:0:0:0:0 with HTTP; Tue, 5 Jun 2018 21:07:51 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Wed, 6 Jun 2018 09:37:51 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: Test cases for the backup module To: Victoria Henry Cc: Dave Page , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000824c52056df14fd5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000824c52056df14fd5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Victoria, As per the logs, Restore job is failing only for GPDB. As I don't have setup for the greenplum database, can you please check this functionality works well in pgAdmin4 with GPDB? Thanks, Khushboo On Wed, Jun 6, 2018 at 5:13 AM, Victoria Henry wrote: > Hi Khushboo > > The tests are still failing and seems flaky: > https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/ > pipelines/pgadmin-patch/jobs/run-tests/builds/113 > > Sincerely, > > Victoria > > On Tue, Jun 5, 2018 at 4:50 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Tue, Jun 5, 2018 at 2:09 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Jun 5, 2018 at 9:37 AM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Tue, Jun 5, 2018 at 1:36 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < >>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>> >>>>>>> Hi Khushboo, >>>>>>> >>>>>>> Some tests are failing in greenplum: >>>>>>> https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/ >>>>>>> pipelines/pgadmin-patch/jobs/run-tests/builds/108 >>>>>>> The piece of code responsible for the error is: >>>>>>> >>>>>>> if server['default_binary_paths'] is not None: >>>>>>> test_utils.set_preference(server['default_binary_paths']) >>>>>>> >>>>>>> config.DEFAULT_BINARY_PATHS =3D { >>>>>>> "pg": str(server['default_binary_paths']['pg']), >>>>>>> "ppas": str(server['default_binary_paths']['ppas']), >>>>>>> "gpdb": "" >>>>>>> } >>>>>>> >>>>>>> >>>>>>> Can you send me the test_config.json file? The above code sets the >>>>>> paths to the SQLite database and through the logs couldn't figure ou= t the >>>>>> exact failure. >>>>>> >>>>> >>>>> It seems clear from the code shown that it's not setting the binary >>>>> paths for gpdb database servers. Shouldn't it be something like: >>>>> >>>>> config.DEFAULT_BINARY_PATHS =3D { >>>>> "pg": str(server['default_binary_paths']['pg']), >>>>> "ppas": str(server['default_binary_paths']['ppas']), >>>>> "gpdb": str(server['default_binary_paths']['gpdb']) >>>>> } >>>>> >>>>> Without this code, the test cases should work as I already set paths >>>> through below code. >>>> >>>> test_utils.set_preference(server['default_binary_paths']) >>>> >>>> >>> In that case, why is the code above required at all? >>> >>> My bad. Removed this code and also updated set_preference function for >> greenplum database. >> Please find the attached updated patch. >> >>> >>> >>>> >>>>> >>>>>> test_backup_utils.py file name is misleading, these are not tests, >>>>>>> are helpers. >>>>>>> =E2=80=8B >>>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> Victoria & Joao >>>>>>> >>>>>>> On Mon, Jun 4, 2018 at 1:36 AM Khushboo Vashi < >>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Sat, Jun 2, 2018 at 3:01 AM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> This looks good, except that it's leaving the >>>>>>>>> test_restore_database behind. Can we clean that up please? >>>>>>>>> >>>>>>>>> PFA updated patch. >>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> On Fri, Jun 1, 2018 at 7:06 AM, Khushboo Vashi < >>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Victoria, >>>>>>>>>> >>>>>>>>>> Thanks for reviewing the patch. >>>>>>>>>> The tests were failing due to the latest commit # >>>>>>>>>> 2b4605a9d390cb44e5dfe9967c3adf2b28d04f1f - Ensure >>>>>>>>>> backup/restore/maintenance work via SSH tunnels. Fixes #3355 >>>>>>>>>> >>>>>>>>>> I have fixed the issues and attached the updated patch. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Khushboo >>>>>>>>>> >>>>>>>>>> On Thu, May 31, 2018 at 10:00 PM, Victoria Henry < >>>>>>>>>> vhenry@pivotal.io> wrote: >>>>>>>>>> >>>>>>>>>>> Hi there, >>>>>>>>>>> >>>>>>>>>>> We've been noticing some issues with the tests on both our CI >>>>>>>>>>> and local Mac workstations. >>>>>>>>>>> >>>>>>>>>>> 1. When the following code blocks are invoked - we get >>>>>>>>>>> plenty of app.context() issues. It must not be valid when >>>>>>>>>>> running tests. >>>>>>>>>>> >>>>>>>>>>> =E2=80=8B >>>>>>>>>>> >>>>>>>>>>> from pgadmin.utils.driver import get_driver >>>>>>>>>>> driver =3D get_driver(PG_DEFAULT_DRIVER) >>>>>>>>>>> manager =3D driver.connection_manager(self.sid) >>>>>>>>>>> >>>>>>>>>>> host =3D manager.local_bind_host if manager.use_ssh_tunnel else= s.host >>>>>>>>>>> port =3D manager.local_bind_port if manager.use_ssh_tunnel else= s.port >>>>>>>>>>> >>>>>>>>>>> 2. When we finally enable >>>>>>>>>>> >>>>>>>>>>> "default_binary_paths": { >>>>>>>>>>> >>>>>>>>>>> in our test_config, we get more failing tests that look like: >>>>>>>>>>> >>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>> FAIL: runTest (pgadmin.tools.restore.tests.test_restore_create_= job_unit_test.RestoreCreateJobTest) >>>>>>>>>>> When restore object with option - Miscellaneous >>>>>>>>>>> ---------------------------------------------------------------= ------- >>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>> File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/unit= test/mock.py", line 1179, in patched >>>>>>>>>>> return func(*args, **keywargs) >>>>>>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/res= tore/tests/test_restore_create_job_unit_test.py", line 295, in runTest >>>>>>>>>>> self.assertEquals(response.status_code, 200) >>>>>>>>>>> AssertionError: 410 !=3D 200 >>>>>>>>>>> >>>>>>>>>>> And >>>>>>>>>>> >>>>>>>>>>> When restore object with the sections options ... 2018-05-31 12= :24:42,988: ERROR pgadmin: illegal environment variable name >>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/res= tore/__init__.py", line 352, in create_restore_job >>>>>>>>>>> manager.export_password_env(p.id) >>>>>>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/utils/dri= ver/psycopg2/server_manager.py", line 365, in export_password_env >>>>>>>>>>> os.environ[str(env)] =3D password >>>>>>>>>>> File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/os.p= y", line 675, in __setitem__ >>>>>>>>>>> self.putenv(key, value) >>>>>>>>>>> ValueError: illegal environment variable name >>>>>>>>>>> FAIL >>>>>>>>>>> >>>>>>>>>>> =E2=80=8B >>>>>>>>>>> >>>>>>>>>>> Sincerely, >>>>>>>>>>> >>>>>>>>>>> Victoria && Anthony >>>>>>>>>>> >>>>>>>>>>> On Thu, May 31, 2018 at 1:16 AM Khushboo Vashi < >>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> Please find the attached updated patch with the fixes. >>>>>>>>>>>> The test cases were only failing on MAC not on Linux. >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Khushboo >>>>>>>>>>>> >>>>>>>>>>>> On Wed, May 30, 2018 at 10:13 AM, Khushboo Vashi < >>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Wed, May 30, 2018 at 1:05 AM, Dave Page >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mon, May 28, 2018 at 8:09 AM, Khushboo Vashi < >>>>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> please find the attached updated patch for the test cases o= f >>>>>>>>>>>>>>> Backup, Restore and Maintenance modules which includes: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> 1. Unit test cases >>>>>>>>>>>>>>> 2. End to end regression test cases >>>>>>>>>>>>>>> 3. Feature test cases >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks. I've yet to be able to run the feature tests >>>>>>>>>>>>>> successfully. Here's what I've found so far: >>>>>>>>>>>>>> >>>>>>>>>>>>>> 1) DEFAULT_BINARY_PATHS should be default_binary_paths in th= e >>>>>>>>>>>>>> JSON config file. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Will do. >>>>>>>>>>>>> >>>>>>>>>>>>>> 2) I've hit screensize related issues: >>>>>>>>>>>>>> >>>>>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>>>>> >>>>>>>>>>>>>> ERROR: runTest (pgadmin.feature_tests.pg_ >>>>>>>>>>>>>> utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTest= ) >>>>>>>>>>>>>> >>>>>>>>>>>>>> Test for PG maintenance: database >>>>>>>>>>>>>> >>>>>>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>>>>>> ---------- >>>>>>>>>>>>>> >>>>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/ >>>>>>>>>>>>>> web/pgadmin/feature_tests/pg_utilities_maintenance_test.py", >>>>>>>>>>>>>> line 56, in runTest >>>>>>>>>>>>>> >>>>>>>>>>>>>> self._open_maintenance_dialogue() >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/ >>>>>>>>>>>>>> web/pgadmin/feature_tests/pg_utilities_maintenance_test.py", >>>>>>>>>>>>>> line 75, in _open_maintenance_dialogue >>>>>>>>>>>>>> >>>>>>>>>>>>>> "*[.=3D'" + self.table_name + >>>>>>>>>>>>>> "']/../*[@class=3D'aciTreeItem'" >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/.virtualenvs/ >>>>>>>>>>>>>> pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remo= te/webelement.py", >>>>>>>>>>>>>> line 80, in click >>>>>>>>>>>>>> >>>>>>>>>>>>>> self._execute(Command.CLICK_ELEMENT) >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/.virtualenvs/ >>>>>>>>>>>>>> pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remo= te/webelement.py", >>>>>>>>>>>>>> line 628, in _execute >>>>>>>>>>>>>> >>>>>>>>>>>>>> return self._parent.execute(command, params) >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/.virtualenvs/ >>>>>>>>>>>>>> pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remo= te/webdriver.py", >>>>>>>>>>>>>> line 312, in execute >>>>>>>>>>>>>> >>>>>>>>>>>>>> self.error_handler.check_response(response) >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/.virtualenvs/ >>>>>>>>>>>>>> pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remo= te/errorhandler.py", >>>>>>>>>>>>>> line 242, in check_response >>>>>>>>>>>>>> >>>>>>>>>>>>>> raise exception_class(message, screen, stacktrace) >>>>>>>>>>>>>> >>>>>>>>>>>>>> WebDriverException: Message: unknown error: Element >>>>>>>>>>>>> class=3D"aciTreeItem">... is not clickable at point (= 223, 604). Other >>>>>>>>>>>>>> element would receive the click:
>>>>>>>>>>>>> wcPanelBackground wcScrollableX wcScrollableY" style=3D"left= : 0px; right: >>>>>>>>>>>>>> 0px; bottom: 0px;">...
>>>>>>>>>>>>>> >>>>>>>>>>>>>> (Session info: chrome=3D66.0.3359.181) >>>>>>>>>>>>>> >>>>>>>>>>>>>> (Driver info: chromedriver=3D2.38.552518 ( >>>>>>>>>>>>>> 183d19265345f54ce39cbb94cf81ba5f15905011),platform=3DMac OS = X >>>>>>>>>>>>>> 10.12.6 x86_64) >>>>>>>>>>>>>> >>>>>>>>>>>>>> 3) One time the test did start, but then I saw this failure: >>>>>>>>>>>>>> >>>>>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>>>>> >>>>>>>>>>>>>> ERROR: runTest (pgadmin.feature_tests.pg_ >>>>>>>>>>>>>> utilities_backup_restore_test.PGUtilitiesBackupFeatureTest) >>>>>>>>>>>>>> >>>>>>>>>>>>>> Test for PG utilities - Backup and Restore >>>>>>>>>>>>>> >>>>>>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>>>>>> ---------- >>>>>>>>>>>>>> >>>>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/ >>>>>>>>>>>>>> web/pgadmin/feature_tests/pg_utilities_backup_restore_test.p= y", >>>>>>>>>>>>>> line 93, in runTest >>>>>>>>>>>>>> >>>>>>>>>>>>>> self.page.fill_input_by_field_name("file", >>>>>>>>>>>>>> "test_backup_file") >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/ >>>>>>>>>>>>>> web/regression/feature_utils/pgadmin_page.py", line 211, in >>>>>>>>>>>>>> fill_input_by_field_name >>>>>>>>>>>>>> >>>>>>>>>>>>>> self.wait_for_input_field_content(field_name, >>>>>>>>>>>>>> field_content) >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/ >>>>>>>>>>>>>> web/regression/feature_utils/pgadmin_page.py", line 251, in >>>>>>>>>>>>>> wait_for_input_field_content >>>>>>>>>>>>>> >>>>>>>>>>>>>> "field to contain '" + str(content) + "'", >>>>>>>>>>>>>> input_field_has_content >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/ >>>>>>>>>>>>>> web/regression/feature_utils/pgadmin_page.py", line 337, in >>>>>>>>>>>>>> _wait_for >>>>>>>>>>>>>> >>>>>>>>>>>>>> "Timed out waiting for " + waiting_for_message >>>>>>>>>>>>>> >>>>>>>>>>>>>> File "/Users/dpage/.virtualenvs/ >>>>>>>>>>>>>> pgadmin4/lib/python2.7/site-packages/selenium/webdriver/supp= ort/wait.py", >>>>>>>>>>>>>> line 80, in until >>>>>>>>>>>>>> >>>>>>>>>>>>>> raise TimeoutException(message, screen, stacktrace) >>>>>>>>>>>>>> >>>>>>>>>>>>>> TimeoutException: Message: Timed out waiting for field to >>>>>>>>>>>>>> contain 'test_backup_file' >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> (with screenshot attached) >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I have ran the feature tests with multiple servers many time= s >>>>>>>>>>>>> but didn't get a single failure. >>>>>>>>>>>>> I have asked Akshay to run on his machine, let see what he >>>>>>>>>>>>> gets. >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> Khushboo >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Wed, Apr 25, 2018 at 9:40 PM, Joao De Almeida Pereira < >>>>>>>>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Khushboo, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> We reviewed the patch and it is very nice to see some more >>>>>>>>>>>>>>>> coverage in this area. Good job :D >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> We passed the tests through our CI the feature tests are >>>>>>>>>>>>>>>> not passing, but the linter fails: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:37: [E= 501] line too long (91 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:53: [E= 501] line too long (104 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:59: [E= 501] line too long (85 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:62: [E= 501] line too long (96 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:63: [E= 501] line too long (91 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:70: [E= 501] line too long (118 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:37: [E= 121] continuation line under-indented for hanging indent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:48: [E= 122] continuation line missing indentation or outdented >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E= 251] unexpected spaces around keyword / parameter equals >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E= 251] unexpected spaces around keyword / parameter equals >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:51: [E= 501] line too long (91 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:52: [E= 501] line too long (94 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:53: [E= 501] line too long (108 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:81: [E= 501] line too long (113 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:82: [E= 501] line too long (94 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:83: [E= 501] line too long (108 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:111: [= E501] line too long (100 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:113: [= E501] line too long (94 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:114: [= E501] line too long (108 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:147: [= E501] line too long (93 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:40: [E1= 21] continuation line under-indented for hanging indent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:51: [E1= 22] continuation line missing indentation or outdented >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:135: [E= 501] line too long (80 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:137: [E= 501] line too long (83 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:138: [E= 122] continuation line missing indentation or outdented >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:139: [E= 122] continuation line missing indentation or outdented >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:140: [E= 122] continuation line missing indentation or outdented >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:191: [E= 501] line too long (81 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:203: [E= 501] line too long (80 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E= 128] continuation line under-indented for visual indent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E= 501] line too long (94 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E= 128] continuation line under-indented for visual indent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E= 501] line too long (94 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:216: [W= 391] blank line at end of file >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:296= : [E501] line too long (97 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:317= : [E303] too many blank lines (2) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:336= : [E501] line too long (84 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:371= : [W391] blank line at end of file >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2 E121 continuation line under-indented for hanging = indent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 5 E122 continuation line missing indentation or outd= ented >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2 E128 continuation line under-indented for visual i= ndent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2 E251 unexpected spaces around keyword / parameter = equals >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 1 E303 too many blank lines (2) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 24 E501 line too long (91 > 79 characters) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2 W391 blank line at end of file >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 38 >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> For the feature tests, we realized we had to update the >>>>>>>>>>>>>>>> configuration, and we did that, but we get the following e= rror attached. We >>>>>>>>>>>>>>>> spent some time trying to understand the problem but we we= re not successful. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Codewise: >>>>>>>>>>>>>>>> - We just found some One Letter Variables in the code... >>>>>>>>>>>>>>>> - Looks like there is a bug report in this area of the cod= e >>>>>>>>>>>>>>>> and we do not have coverage for it: https://redmine. >>>>>>>>>>>>>>>> postgresql.org/issues/3232 >>>>>>>>>>>>>>>> Looks like in some of the unit tests we only have happy >>>>>>>>>>>>>>>> path tests, maybe we should see if there are any sad paths= that also need >>>>>>>>>>>>>>>> coverage. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> The configuration change, maybe need to be updated. When w= e >>>>>>>>>>>>>>>> install multiple versions of postgres the binaries live in >>>>>>>>>>>>>>>> `/usr/lib/postgresql/{{db_version}}/bin`, which makes us >>>>>>>>>>>>>>>> think that this configuration should live near the server = configuration, >>>>>>>>>>>>>>>> maybe? Also to maintain coherency on the naming maybe we s= hould make it all >>>>>>>>>>>>>>>> lower case. >>>>>>>>>>>>>>>> Just as an aside, you can add the gpdb configuration as >>>>>>>>>>>>>>>> well in you patch. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> Victoria & Joao >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Wed, Apr 25, 2018 at 5:20 AM Khushboo Vashi < >>>>>>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Please find the attached patch which covers test cases fo= r >>>>>>>>>>>>>>>>> the backup module (RM #3206). >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> 1. Unit test cases >>>>>>>>>>>>>>>>> 2. End to end regression test cases >>>>>>>>>>>>>>>>> 3. Feature test cases >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> Khushboo >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> --000000000000824c52056df14fd5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Victoria,

As per the logs, Restore j= ob is failing only for GPDB. As I don't have setup for the greenplum da= tabase, can you please check this functionality works well in pgAdmin4 with= GPDB?

Thanks,
Khushboo

On Wed, Jun 6, 2018 at 5:13 AM, Victoria Henry <vhenr= y@pivotal.io> wrote:
Hi Khushboo

The tests are still failing= and seems flaky:

Sincerely,

Victoria

On Tue, Jun 5, 2018 at 4:50 AM Khushb= oo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Tue, Jun 5, 2018 at 2:09 PM, Dave Page <dpa= ge@pgadmin.org> wrote:


= On Tue, Jun 5, 2018 at 9:37 AM, Khushboo Vashi <= khushb= oo.vashi@enterprisedb.com> wrote:


On Tue, Jun 5, 2018 at 1:36 PM, Dave Page <dpage@p= gadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Mon, Jun 4, 2018 at 8:41 PM, Joao De = Almeida Pereira <jdealmeidapereira@pivotal.io> wr= ote:
Hi Khushboo,=

Some tests are failing in greenplum:
https://gpdb-dev.bosh= .pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/r= un-tests/builds/108
The piece of code responsible for the err= or is:
if server['default_binary_paths'] is not None:
    test_utils.set_preference(server[=
'default_binary_paths'=
])

    config.DEFAULT_BINARY_PATHS =3D {
        "pg": str(server['=
default_binary_paths']['pg']),
        "ppas": str(server['default_bin=
ary_paths']['ppas=
']),
        "gpdb": "&=
quot;
    }
Can you send me the test_config.json = file?=C2=A0 The above code sets the paths to the SQLite database and throug= h the logs couldn't figure out the exact failure.=C2=A0

It seems clear from the cod= e shown that it's not setting the binary paths for gpdb database server= s. Shouldn't it be something like:

    config.DEFA=
ULT_BINARY_PATHS =3D {
        &qu=
ot;pg": str(serve=
r['default_binary_paths'=
]['pg']),
        "ppas"=
: str(server['default_binary_paths']['ppas']),
        "gpdb": str(server['default_binary_paths'<=
span style=3D"font-size:9pt">]['gpdb'])=

    }
<= div>Without this code, the test cases should work as I already set=C2=A0 pa= ths through below code.
    test_utils.set_preference(server['default_binary_paths'])

In that case, wh= y is the code above required at all?

My bad. Removed this code and also updated set_prefere= nce function for greenplum database.
Please find the attached upd= ated patch.
=C2=A0
=C2=A0

test_backup_utils.py file name is misleading, these are not tests, are helpers.

=E2=80=8B
=


Thanks
Victoria &a= mp; Joao

On Mon, Jun= 4, 2018 at 1:36 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com&g= t; wrote:


On Sat, Jun 2, 2018 a= t 3:01 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This looks goo= d, except that it's leaving the test_restore_database behind. Can we cl= ean that up please?

PFA updated= patch.=C2=A0
Thanks.

On Fri, Jun 1, 2018 at 7:06 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Victoria,

T= hanks for reviewing the patch.
The tests were failing due to the = latest commit #2b4605a9d390cb44e5dfe9967c3adf2b28d04f1f=C2=A0 - E= nsure backup/restore/maintenance work via SSH tunnels. Fixes #3355

I have fixed the issues and attached the updated patch.

Thanks,
Khushboo=C2=A0

<= div class=3D"gmail_quote">On Thu, May 31, 2018 at 10:00 PM, Victoria Henry = <vhenry@pivotal.io> wrote:
Hi there,

We've been noticing some= issues with the tests on both our CI and local Mac workstations.
  1. When the following code blocks are invoked -= we get plenty of app.context() issues. It must not= be valid when running tests.
=E2=80=8B
= 
from pgadmin.utils.driver import get_driver
driver =3D get_driver(PG_DEFAULT_DR=
IVER)
manager =3D driver.connection_manager(self.sid)

host =3D manager.local_bind_host if manager.use_ssh_tunnel else s.host
port =3D manager.local=
_bind_port if manager.use_ssh_=
tunnel else s.port=C2=A0
=
2. When we finally enable=C2=A0
"default_binary_=
paths": {
in our test_config, we get more failing tests that look like:
= 
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.tools.restore.tests.test_restore_create_job_uni=
t_test.RestoreCreateJobTest)
When restore object with option - Miscellaneous
-----------------------------------------------------------------=
-----
Traceback (most recent call last):
  File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/u=
nittest/mock.py", line 1179, in patched
    return func(*args, **keywargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/=
restore/tests/test_restore_create_job_unit_test.py", line 295, in=
 runTest
    self.assertEquals(response.status_code, 200)
AssertionError: 410 !=3D 200

And

When restore object =
with the sections options ... 2018-05-31 12:24:42,988: ERROR    pgadmin:   =
 illegal environment variable name
Traceback (most recent call last):
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/=
restore/__init__.py", line 352, in create_restore_job
    manager.export_password_env(p=
.id)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/utils/=
driver/psycopg2/server_manager.py", line 365, in export_password_=
env
    os.environ[str(env)] =3D password
  File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/o=
s.py", line 675, in __setitem__
    self.putenv(key, value)
ValueError: illegal environment variable name
FAIL
=E2=80=8B
=

Sincerely,

Vi= ctoria && Anthony

On Thu, May 31, 2018 at 1:16 AM Khushboo Vashi = <kh= ushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the atta= ched updated patch with the fixes.
The test cases were only faili= ng on MAC not on Linux.

Thanks,
Khushboo=

On We= d, May 30, 2018 at 10:13 AM, Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:


On Wed, May 30, 2018 at 1:05 AM, Dave Page <dpage@pgadmin.o= rg> wrote:
Hi

On M= on, May 28, 2018 at 8:09 AM, Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
Hi,

please find the= attached updated patch for the test cases of Backup, Restore and Maintenan= ce modules which includes:

1. Unit test case= s
2. End to end regression test cases=C2=A0
3. Feature test cases=

Thanks. I&= #39;ve yet to be able to run the feature tests successfully. Here's wha= t I've found so far:

1) DEFAULT_BINARY_PATHS s= hould be default_binary_paths in the JSON config file.

=
Will do.=C2=A0
2) I've hit screensize related issues:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D

ERROR: runTest (pgadmin.feature_tests.pg_utilities_m= aintenance_test.PGUtilitiesMaintenanceFeatureTest)

Test for PG maintenance: database

----------------------------------------------------= ------------------

Traceback (most recent call last):

=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_= utilities_maintenance_test.py", line 56, in runTest

=C2=A0 =C2=A0 <= /span>self._open_maintenance_dialogue()

=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_= utilities_maintenance_test.py", line 75, in _open_maintenance_dia= logue

=C2=A0 =C2=A0 <= /span>"*[.=3D'" + self.table_name + "']/../*[@class= =3D'aciTreeItem'"

=C2=A0 F= ile "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-p= ackages/selenium/webdriver/remote/webelement.py", line 80, in cli= ck

=C2=A0 =C2=A0 <= /span>self._execute(Command.CLICK_ELEMENT)

=C2=A0 F= ile "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-p= ackages/selenium/webdriver/remote/webelement.py", line 628, in _e= xecute

=C2=A0 =C2=A0 <= /span>return self._parent.execute(command, params)

=C2=A0 F= ile "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-p= ackages/selenium/webdriver/remote/webdriver.py", line 312, in exe= cute

=C2=A0 =C2=A0 <= /span>self.error_handler.check_response(response)

=C2=A0 F= ile "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-p= ackages/selenium/webdriver/remote/errorhandler.py", line 242, in = check_response

=C2=A0 =C2=A0 <= /span>raise exception_class(message, screen, stacktrace)

WebDriverException: Message: unknown error: Element <s= pan class=3D"aciTreeItem">...</span> is not clickable at= point (223, 604). Other element would receive the click: <div class=3D&= quot;wcFrameCenter wcPanelBackground wcScrollableX wcScrollableY" styl= e=3D"left: 0px; right: 0px; bottom: 0px;">...</div>

=C2=A0 (= Session info: chrome=3D66.0.3359.181)

=C2=A0 (= Driver info: chromedriver=3D2.38.552518 (183d19265345f54ce39cbb94cf81b= a5f15905011),platform=3DMac OS X 10.12.6 x86_64)


3) One time the test did start, but then I saw this failure:=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D

ERROR: runTest (pgadmin.feature_tests.pg_utilities_b= ackup_restore_test.PGUtilitiesBackupFeatureTest)

Test for PG utilities - Backup and Restore

----------------------------------------------------= ------------------

Traceback (most recent call last):

=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_= utilities_backup_restore_test.py", line 93, in runTest

=C2=A0 =C2=A0 <= /span>self.page.fill_input_by_field_name("file", "test_= backup_file")

=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/regression/feature_utils/= pgadmin_page.py", line 211, in fill_input_by_field_name

=C2=A0 =C2=A0 <= /span>self.wait_for_input_field_content(field_name, field_content)

=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/regression/feature_utils/= pgadmin_page.py", line 251, in wait_for_input_field_content

=C2=A0 =C2=A0 <= /span>"field to contain '" + str(content) + "'"= , input_field_has_content

=C2=A0 F= ile "/Users/dpage/git/pgadmin4/web/regression/feature_utils/= pgadmin_page.py", line 337, in _wait_for

=C2=A0 =C2=A0 <= /span>"Timed out waiting for " + waiting_for_message

=C2=A0 F= ile "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-p= ackages/selenium/webdriver/support/wait.py", line 80, in until

=C2=A0 =C2=A0 <= /span>raise TimeoutException(message, screen, stacktrace)

TimeoutException: Message: Timed out waiting for field to= contain 'test_backup_file'



(with screenshot attached)

Thanks.<= /div>

<= div>I have ran the feature tests with multiple servers many times but didn&= #39;t get a single failure.
I have asked Akshay to run on his mac= hine, let see what he gets.


=C2=A0

Thanks,
Khushboo



<= /div>

On Wed, Apr 25, 2018 at 9:40 PM, Joao = De Almeida Pereira <jdealmeidapereira@pivotal.io>= wrote:
Hi Khushboo,
We reviewed the patch and it is very nice to see some more = coverage in this area. Good job :D

We passed the t= ests through our CI the feature tests are not passing, but the linter fails= :
./pgadmin/feature_tests/pg_utilities_backu=
p_test.py:37: [E501] line too long (91 > 79 characters)

./pgadmin/=
feature_tests/pg_utilities_backup_test.py:53: [E501] line too long (10=
4 > 79 characters)

./pgadmin/=
feature_tests/pg_utilities_backup_test.py:59: [E501] line too long (85=
 > 79 characters)

./pgadmin/=
feature_tests/pg_utilities_backup_test.py:62: [E501] line too long (96=
 > 79 characters)

./pgadmin/=
feature_tests/pg_utilities_backup_test.py:63: [E501] line too long (91=
 > 79 characters)

./pgadmin/=
feature_tests/pg_utilities_backup_test.py:70: [E501] line too long (11=
8 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:37: [E121] continuation line=
 under-indented for hanging indent

./pgadmin/=
tools/backup/tests/test_backup_message.py:48: [E122] continuation line=
 missing indentation or outdented

./pgadmin/=
tools/backup/tests/test_backup_message.py:49: [E251] unexpected spaces=
 around keyword / parameter equals

./pgadmin/=
tools/backup/tests/test_backup_message.py:49: [E251] unexpected spaces=
 around keyword / parameter equals

./pgadmin/=
tools/backup/tests/test_backup_message.py:51: [E501] line too long (91=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:52: [E501] line too long (94=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:53: [E501] line too long (10=
8 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:81: [E501] line too long (11=
3 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:82: [E501] line too long (94=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:83: [E501] line too long (10=
8 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:111: [E501] line too long (1=
00 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:113: [E501] line too long (9=
4 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:114: [E501] line too long (1=
08 > 79 characters)

./pgadmin/=
tools/backup/tests/test_backup_message.py:147: [E501] line too long (9=
3 > 79 characters)

./pgadmin/=
tools/backup/tests/test_batch_process.py:40: [E121] continuation line =
under-indented for hanging indent

./pgadmin/=
tools/backup/tests/test_batch_process.py:51: [E122] continuation line =
missing indentation or outdented

./pgadmin/=
tools/backup/tests/test_batch_process.py:135: [E501] line too long (80=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_batch_process.py:137: [E501] line too long (83=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_batch_process.py:138: [E122] continuation line=
 missing indentation or outdented

./pgadmin/=
tools/backup/tests/test_batch_process.py:139: [E122] continuation line=
 missing indentation or outdented

./pgadmin/=
tools/backup/tests/test_batch_process.py:140: [E122] continuation line=
 missing indentation or outdented

./pgadmin/=
tools/backup/tests/test_batch_process.py:191: [E501] line too long (81=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_batch_process.py:203: [E501] line too long (80=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_batch_process.py:204: [E128] continuation line=
 under-indented for visual indent

./pgadmin/=
tools/backup/tests/test_batch_process.py:204: [E501] line too long (94=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_batch_process.py:205: [E128] continuation line=
 under-indented for visual indent

./pgadmin/=
tools/backup/tests/test_batch_process.py:205: [E501] line too long (94=
 > 79 characters)

./pgadmin/=
tools/backup/tests/test_batch_process.py:216: [W391] blank line at end=
 of file

./pgadmin/=
tools/backup/tests/test_create_backup_job.py:296: [E501] line too long=
 (97 > 79 characters)

./pgadmin/=
tools/backup/tests/test_create_backup_job.py:317: [E303] too many blan=
k lines (2)

./pgadmin/=
tools/backup/tests/test_create_backup_job.py:336: [E501] line too long=
 (84 > 79 characters)

./pgadmin/=
tools/backup/tests/test_create_backup_job.py:371: [W391] blank line at=
 end of file

2       E1=
21 continuation line under-indented for hanging indent

5       E1=
22 continuation line missing indentation or outdented

2       E1=
28 continuation line under-indented for visual indent

2       E2=
51 unexpected spaces around keyword / parameter equals

1       E3=
03 too many blank lines (2)

24      E5=
01 line too long (91 > 79 characters)

2       W3=
91 blank line at end of file

38

For the feature tests, we realize= d we had to update the configuration, and we did that, but we get the follo= wing error attached. We spent some time trying to understand the problem bu= t we were not successful.


Codewise:=
- We just found some One Letter Variables in the code...
- Looks like there is a bug report in this area of the code and we do no= t have coverage for it:=C2=A0https://redmine.postgresql.org/issues/3232<= /a>


Victoria & Joao<= /div>

Hi,

Please find the attached pa= tch which covers test cases for the backup module (RM #3206).
1. Unit test cases
2. End to end regression test case= s=C2=A0
3. Feature test cases

Thanks,
Khushboo

<= /div>
=
--000000000000824c52056df14fd5--