Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gohn6-0004GH-3n for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 04:48:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gohn4-0000mc-LF for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 04:47:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gohn4-0000ip-7X for pgadmin-hackers@lists.postgresql.org; Wed, 30 Jan 2019 04:47:58 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gohmw-0007NR-Jq for pgadmin-hackers@postgresql.org; Wed, 30 Jan 2019 04:47:56 +0000 Received: by mail-ot1-x344.google.com with SMTP id e12so20059475otl.5 for ; Tue, 29 Jan 2019 20:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p1xyIpmxl/pYDCFjeik8tn5BwJqnKpYS1L0/nJ2zYds=; b=MPkiA5ixfA8OZFmHvjDC3UdaKO/SXXTarfYxdn7dR2tzjleTt5EPCiJNT4u9PPFNw9 Cne+H188nu/R+AQQ6j0VC7Y2nQRJS++gpFZps9stcWtA2/xDbhLkFL0QXM8TjqNXrdl1 YtLuUMQIWoX4go1pqHkiaJFsjkJi8W5WWM9hAqhsbtBjpRfenlZ6LE10WENVgtvV39eQ DjDz9064QaZPZQIEPB7AJ5X8rL3QJBPGXFqztmlAqq4+RGUPXC8u9CtKXcl8yWeT1Ycq RdZt4Hlntu4EN9jMZIGDoCIckx3SJ0KrFvVrZ3HPSUvfxyhuxhmsKNt0uMSVIeIWNeu8 9ppg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p1xyIpmxl/pYDCFjeik8tn5BwJqnKpYS1L0/nJ2zYds=; b=iqu7iwYa9n/yALTTrfk/0Xw4HoNUYll/gOn+/nULrAUACJtwVe6hdypvLzhCywb2bF GE+6gueoN4A8uCUnkJ+WMt6eqYNA9x8jDtF0RwrgQOpz6GVs1TmapdYchcHvp1FVJ1Zz LxSTYnHp1nw4f8d42ve/+sS5pG2sylEBHuBdevnHR4stypghKlCDpfRPh1WCgw3B9rJG PQCNnmpWEVKsSEWckNr1S0c84nH6y/WZbnH0pbMzkZhuk4DwAUJ9WNKYMz/BGkIzqoMz qHZIBWjYaBjzahryL3Ai8lOyDa2s8ZDZ6Y5VahHy5jdw1SuwKCYOOTBFhv7iKqhFV4ZP pdhg== X-Gm-Message-State: AJcUukfUQQfDA++FQw+nrOX+i0OooFWDv3DZeF3+i7bGMz/ML/pdZWsf 4IW1eFUmaoWEuGSN5zn0rsg8byeT13Blvp0TzomWQg== X-Google-Smtp-Source: ALg8bN65aXvRpPL+B6gbWc5AiVzt9gCOf7R8IXSmCRwQYaJKglCLZEnpXbCr9sOmwZRjtBn0boFoTdQyCUrSg319IZw= X-Received: by 2002:a9d:1d65:: with SMTP id m92mr22103307otm.65.1548823669736; Tue, 29 Jan 2019 20:47:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Wed, 30 Jan 2019 10:17:38 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a79fc00580a59c38" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a79fc00580a59c38 Content-Type: text/plain; charset="UTF-8" Hi Akshay, The issue has been fixed with this patch but I feel we need code refactoring of the existing code especially the loop in which we find the required string. What's your thought? Also, please remove the datagrid/__init__.py file from the patch which I assume you have sent by mistake. Thanks, Khushboo On Tue, Jan 29, 2019 at 4:49 PM Dave Page wrote: > Khushboo, can you review this please? If you're happy with it, Akshay > can commit. > > Thanks. > > On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi > wrote: > > > > Hi Hackers, > > > > Attached is the patch to fix RM 3927 "Unable to debug the procedure > inside package". Problem with the existing code is we assume that > "PLDBGBREAK" will be always found in the first element of the notification > list. > > > > In this patch we loop through the list and found the string. Apart from > that patch contains small fix to cancel the transaction of Query Tool when > panel is closed. > > > > Please review it. > > > > -- > > Akshay Joshi > > Sr. Software Architect > > > > > > Phone: +91 20-3058-9517 > > Mobile: +91 976-788-8246 > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > --000000000000a79fc00580a59c38 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

The issue has been fixed wit= h this patch but I feel we need code refactoring of the existing code espec= ially the loop in which we find the required string.
What's y= our thought?

Also, please remove the datagrid/__in= it__.py file from the patch which I assume you have sent by mistake.
<= div>
Thanks,
Khushboo
=C2=A0
<= br>
On Tue,= Jan 29, 2019 at 4:49 PM Dave Page <dpage@pgadmin.org> wrote:
Khushboo, can you review this please? If you're happy= with it, Akshay
can commit.

Thanks.

On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi
<aksh= ay.joshi@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM 3927 "Unable to debug the procedu= re inside package". Problem with the existing code is we assume that &= quot;PLDBGBREAK" will be always found in the first element of the noti= fication list.
>
> In this patch we loop through the list and found the string. Apart fro= m that patch contains small fix to cancel the transaction of Query Tool whe= n panel is closed.
>
> Please review it.
>
> --
> Akshay Joshi
> Sr. Software Architect
>
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000a79fc00580a59c38--