Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fUmwy-0002Aj-SI for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jun 2018 05:43:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fUmwx-0008TN-Em for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jun 2018 05:43:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fUmwx-0008TD-6E for pgadmin-hackers@lists.postgresql.org; Mon, 18 Jun 2018 05:43:35 +0000 Received: from mail-ot0-x231.google.com ([2607:f8b0:4003:c0f::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fUmwu-0004Ai-5I for pgadmin-hackers@postgresql.org; Mon, 18 Jun 2018 05:43:33 +0000 Received: by mail-ot0-x231.google.com with SMTP id w9-v6so17128965otj.7 for ; Sun, 17 Jun 2018 22:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1pZMxLp/PW6N8FEczCt4wx3Q3qeemn57IIC176uF0wg=; b=0xVZPfxibHfG2+Q+NZpMBgkqu5slI1WZK+Mr2XBE+SeVUBGb+aM52oeHHfKSdoMoYA ffvGajI7Sd2GJAwlh7+PlEuObfUI7D9l4dcD2ey75h8mw2KTKHCMLSwxNzUJiPAd7bDX Hwa9Ad1NUo05vwVYPwrvurWDc/avBYj7Lrm7hQQ+Vg3OOphC7fkmdI8qAJZeHt6qHd9o NRPJEuvfo7NxlxQCEzwtw1/P5bS6RpthRdY8inYV3qBR/YT44zJnhbH9CyzyHz9OwZ2B Gw7FV1rCl7xmBqxj3EcNZiLcmFoceef3+4GxFyQnqSU+1bjRlXMsu/O8PHlMhOVu1rHo RXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1pZMxLp/PW6N8FEczCt4wx3Q3qeemn57IIC176uF0wg=; b=g+5cQAuMQX6inQ1n9ml5c10f5p0JVpH8qVNZqf51NPaGyaGKUAfmECq+0fXSLmDRyA 8NLXx/W6tZZoxhAR0MAvsDzI3tC1fgSYTdAGNVjIE/uk74V6XlEGDEW3A1ZPHo+WNAV1 c6iHYdkhhckZtObjGnmqGhDlCCH6IkVQT6W57SuzcFO8Kcx1kdt59wo/agajtnwK2cVC 5rG5UPjOVMDb1WLTowIpg4e5TLN7rz+ydeDYfeemH9/7G2WNt6cL6xZKUGTmpPbLqUxY JnlfIKtGRysM3wgtKVt5QmDIkeaC1+sVblL1zAtDa3svniclNmBernbQcbPRd4mlH0F8 +MVg== X-Gm-Message-State: APt69E2cPtSsr6JAvmse53BrCl7z0k19RLebRq3HNUSkvTo7OlHEN5QB AIHjEeYtM40Mz997qYc/bS9g3PZ/NhkSp3TWpCmIhA== X-Google-Smtp-Source: ADUXVKIy8hKWeAz/r6ovJJ6UWLNQgTrPavl8YlYB+WOJ8VeC09FwvZpgSwa7OIFYsF0wTXZGFOKncnk+wORfU5xJAqo= X-Received: by 2002:a9d:522:: with SMTP id 31-v6mr7432465otw.391.1529300611348; Sun, 17 Jun 2018 22:43:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:4081:0:0:0:0:0 with HTTP; Sun, 17 Jun 2018 22:43:30 -0700 (PDT) In-Reply-To: References: From: Khushboo Vashi Date: Mon, 18 Jun 2018 11:13:30 +0530 Message-ID: Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests To: Dave Page Cc: Victoria Henry , Joao De Almeida Pereira , pgadmin-hackers , Anthony Emengo Content-Type: multipart/alternative; boundary="000000000000b1d11b056ee40b1e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b1d11b056ee40b1e Content-Type: text/plain; charset="UTF-8" Hi, The supported versions of Pytest: Python 2.7, Python 3.4+, PyPy 2.3, Jython 2.5 (untested); Grappa: Python 2.7+, 3+ References: https://docs.pytest.org/en/latest/ https://github.com/grappa-py/grappa So, how are we going to handle unsupported versions (PY 2.6 and 3.3) ? Thanks, Khushboo On Wed, Jun 13, 2018 at 6:07 PM, Dave Page wrote: > Hi > > On Tue, Jun 12, 2018 at 3:41 PM, Victoria Henry wrote: > >> Hi Dave, >> >> Attached are four different patches that should be applied in order. >> Included is a fix for the failing test above. >> > > This is no longer failing :-) > > However, I'm still seeing problems that need to be resolved: > > - Passwords are still being written to the log file. This is a complete > show-stopper. > > - The regression.log file is empty. I'm now only getting the JSON summary. > We really need both - the regression log for diagnostics, and the JSON file > for feeding into monitoring systems. > > - There is still no summary list of tests that failed or were skipped > output at the end of the run. This is important because it highlights which > tests failed (obviously!) and need investigation, and knowing which ones > are skipped at a glance is very useful as they can be skipped due to > mis-configuration; e.g. running against a different server than intended, > or failing to specify something like a tablespace path which we can then > easily see to fix. > > - I cannot run against servers other than the first one in the config > file. We need to run against all that are enabled, and have the output show > which one was used for each one as we have now. This may seem trivial, but > it's really not - to the point that for some of us it negates the whole > point of the patch by giving us more control over which tests are run but > removing all control over which database servers they will run against. In > my case, this will almost certainly cost even more time; right now I just > have to run more tests than I may need but I can do other things at the > same time. With this patch I'll have to keep re-running the tests, > modifying the config between each run. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000b1d11b056ee40b1e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

The supported versions of=C2=A0
Pytest:=C2=A0Python 2.7, Python 3.4+, PyPy 2.3, Jython 2.5 (untested= );
Grappa:=C2=A0Python 2.7+, 3+

Referenc= es:

So, how are we going to handle unsupported versions (PY 2.6 and 3.3) = ?

Thanks,
Khushboo

On Wed, Jun 13, 2018 at 6:0= 7 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Jun 12, 2018 at 3:41 PM, Vi= ctoria Henry <vhenry@pivotal.io> wrote:
Hi Dave,

Attached are fou= r different patches that should be applied in order.=C2=A0 Included is a fi= x for the failing test above.

This is no longer failing :-)

However, I'= ;m still seeing problems that need to be resolved:

- Passwords are still being written to the log file. This is a complete sh= ow-stopper.

- The regression.log file is empty. I&= #39;m now only getting the JSON summary. We really need both - the regressi= on log for diagnostics, and the JSON file for feeding into monitoring syste= ms.

- There is still no summary list of tests that= failed or were skipped output at the end of the run. This is important bec= ause it highlights which tests failed (obviously!) and need investigation, = and knowing which ones are skipped at a glance is very useful as they can b= e skipped due to mis-configuration; e.g. running against a different server= than intended, or failing to specify something like a tablespace path whic= h we can then easily see to fix.

- I cannot run ag= ainst servers other than the first one in the config file. We need to run a= gainst all that are enabled, and have the output show which one was used fo= r each one as we have now. This may seem trivial, but it's really not -= to the point that for some of us it negates the whole point of the patch b= y giving us more control over which tests are run but removing all control = over which database servers they will run against. In my case, this will al= most certainly cost even more time; right now I just have to run more tests= than I may need but I can do other things at the same time. With this patc= h I'll have to keep re-running the tests, modifying the config between = each run.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter:= @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreS= QL Company

--000000000000b1d11b056ee40b1e--