Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goPzG-0005X3-1G for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 09:47:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1goPzE-0007YY-QG for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 09:47:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goPzE-0007YR-Cs for pgadmin-hackers@lists.postgresql.org; Tue, 29 Jan 2019 09:47:20 +0000 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goPzB-0006Zo-Dn for pgadmin-hackers@postgresql.org; Tue, 29 Jan 2019 09:47:19 +0000 Received: by mail-oi1-x235.google.com with SMTP id c206so15674757oib.0 for ; Tue, 29 Jan 2019 01:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xzwW8P+MHJQAs6r5Q/TKWDGSx6/6J9NiECBp/CuKDLU=; b=tRQOF3qbL16VxCAe/ciWwV66iqplyLJntDObu/Zc2E+HgHbt2/F46C4NgL2F/vLfoR zWB60BBh8VdPn9eooFn2GNHcgkKfBZ2U5l0XnmN3TcUlijmk/xqGDhpGRukk6K9FId9K x9hCkYF97UiFzJveC7Vfpu+mtwpr5OhhwLnF4u6gghGOF99RG0l4req/AEZ66hvAiyXp 3J/bliRr3v46WCtbJ3lulETwOaiK1J/qwFVQW8Y3saMha3vVcRpzusA5Od0WdyybOTeA OlZkMDLwtjGOANzm916pDtDpFvVFu0xXIWJkbWXt7Uph1mAKK0EY/bEad5SJrAwLt6cT HKeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xzwW8P+MHJQAs6r5Q/TKWDGSx6/6J9NiECBp/CuKDLU=; b=I1aXRTzJAc1Fx28rtcJ8knlRKNrnbhBFmW+k2cNPh2ZOC1rHzIedZjSh37YVaZbcs3 /zatAflcMRef3l+HhtrP2r5ypuawrLDpljuBHpmzBRXU+pV++FWyLB5BJVc8h2eWjorK 5AaVafuWnOXMeRxf0jbv/EkFufewF0Qvpwwm+0N65wMm8Z8fWJ4+Ds5yjNoDBf1E7CQk caKxgEKTyLEbErGdG7KgKQyUR2qaMxiH11HVxsRr/OsK4i2OllDcHw7bbg1jYlACjQk0 TmJU7vMuMTc8jTaFZaHmA9PyCxthM9U+dQ/ld5MNfXFhLDuwXaO8o5eEJZbQkvLeR+J+ /9tA== X-Gm-Message-State: AHQUAuY1C5HLcTntYMHeup5TajVKqsv2nXB3yuvVhNDH1dO7cdRs+MfT LRmrtpq2Ln/Ob2807Bgg7D33YL6Xz8aQ27LV3uy4/Q== X-Google-Smtp-Source: ALg8bN4xXMwArWRl4AO1NVN9xY5XxcR44qD4uZTwFb2UQn111M6j5NFoHXwd8mN1vPCoj8qjECRQ2gJb0s2/Y16zAes= X-Received: by 2002:aca:c443:: with SMTP id u64mr9029045oif.136.1548755236553; Tue, 29 Jan 2019 01:47:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Khushboo Vashi Date: Tue, 29 Jan 2019 15:17:05 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000b86364058095ade5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b86364058095ade5 Content-Type: multipart/alternative; boundary="000000000000b86361058095ade3" --000000000000b86361058095ade3 Content-Type: text/plain; charset="UTF-8" Hi, Please find the attached updated patch. I have also improved the performance of the properties tab. Please also apply the bootstrap toggle patch to check the properties tab performance. Thanks, Khushboo On Tue, Jan 22, 2019 at 5:05 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Khushboo, > > There is improvement than before but the UI still lags. I tested with 2000 > tables and statistics on Tables node. > I would also suggest to add further rows only if scrolling down. Rows > adding can be avoided even if the scroll does not take to the last element. > Currently, if I scroll slightly down it add rows and if I scroll back up > it adds more. I think the scroll up fetch can be avoided. > > On Mon, Jan 21, 2019 at 4:43 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> Can you please review it. >> >> On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the RM 3664 - Statistic panel >>> hangs when 1000+ tables >>> >>> The statistics tab hangs with more rows. So, now the rows will be pushed >>> in the backgrid collection in bunches on scroll event to fix this issue. >>> >>> Thanks, >>> Khushboo >>> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > --000000000000b86361058095ade3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Please find the attached= updated patch.
I have also improved the performance of the prope= rties tab.
Please also apply the bootstrap toggle patch to check = the properties tab performance.=C2=A0

Thanks,
Khushboo

On Tue, Jan 22, 2019 at 5:05 PM Aditya Toshniwal <aditya.toshniwal@enterprised= b.com> wrote:
Hi Khus= hboo,

There is improvement than before but = the UI still lags. I tested with 2000 tables and statistics on Tables node.=
I would also suggest to= add further rows only if scrolling down. Rows adding can be avoided even i= f the scroll does not take to the last element.
Currently, if I scroll slightly down it add rows an= d if I scroll back up it adds more. I think the scroll up fetch can be avoi= ded.

On Mon, Jan 21, 2019 at 4:43 PM Akshay= Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya=C2=A0

<= /div>
Can you please review it.

On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi <khushboo= .vashi@enterprisedb.com> wrote:
Hi,

Please find = the attached patch to fix the RM 3664 - Statistic panel hangs when 1000+ ta= bles

The statistics tab hangs with more rows. So, = now the rows will be pushed in the backgrid collection in bunches on scroll= event to fix this issue.

Thanks,
Khushb= oo


--
= Akshay Joshi
Sr. Software Architect

=

<= /font>
Phon= e: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"
--000000000000b86361058095ade3-- --000000000000b86364058095ade5 Content-Type: application/octet-stream; name="RM_3664_v1.patch" Content-Disposition: attachment; filename="RM_3664_v1.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrhkti8k0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2NvbGxlY3Rpb24uanMg Yi93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9jb2xsZWN0aW9uLmpzCmluZGV4IGFhNzU4 YWZkLi42NzIyYjdjNSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMv Y29sbGVjdGlvbi5qcworKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9jb2xsZWN0 aW9uLmpzCkBAIC0xODgsNyArMTg4LDcgQEAgZGVmaW5lKFsKICAgICAgICAgICAncmVtb3ZlJzog ZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICBpZiAodGhpcy5ncmlkKSB7CiAgICAgICAgICAgICAg IGlmICh0aGlzLmdyaWQuY29sbGVjdGlvbikgewotICAgICAgICAgICAgICAgIHRoaXMuZ3JpZC5j b2xsZWN0aW9uLnJlc2V0KG51bGwsIHtzaWxlbnQ6IHRydWV9KTsKKyAgICAgICAgICAgICAgICB0 aGlzLmdyaWQuY29sbGVjdGlvbi5yZXNldCh7c2lsZW50OiB0cnVlfSk7CiAgICAgICAgICAgICAg ICAgZGVsZXRlICh0aGlzLmdyaWQuY29sbGVjdGlvbik7CiAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgZGVsZXRlICh0aGlzLmdyaWQpOwpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vbWlz Yy9zdGF0aXN0aWNzL3N0YXRpYy9qcy9zdGF0aXN0aWNzLmpzIGIvd2ViL3BnYWRtaW4vbWlzYy9z dGF0aXN0aWNzL3N0YXRpYy9qcy9zdGF0aXN0aWNzLmpzCmluZGV4IGNmZDU3M2UxLi41NDQxZjg4 MyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vbWlzYy9zdGF0aXN0aWNzL3N0YXRpYy9qcy9zdGF0 aXN0aWNzLmpzCisrKyBiL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGlzdGljcy9zdGF0aWMvanMvc3Rh dGlzdGljcy5qcwpAQCAtMTA0LDcgKzEwNCw5IEBAIGRlZmluZSgnbWlzYy5zdGF0aXN0aWNzJywg WwogICAgICAgb2ZmVGV4dDogZ2V0dGV4dCgnRmFsc2UnKSwKICAgICAgIG9uQ29sb3I6ICdzdWNj ZXNzJywKICAgICAgIG9mZkNvbG9yOiAncHJpbWFyeScsCi0gICAgICBzaXplOiAnbWluaScsCisg ICAgICBzaXplOiAnc21hbGwnLAorICAgICAgd2lkdGg6IG51bGwsCisgICAgICBoZWlnaHQ6IG51 bGwsCiAgICAgfQogICApOwogCkBAIC0xMTcsNyArMTE5LDcgQEAgZGVmaW5lKCdtaXNjLnN0YXRp c3RpY3MnLCBbCiAgICAgICBfLmJpbmRBbGwoCiAgICAgICAgIHRoaXMsCiAgICAgICAgICdzaG93 U3RhdGlzdGljcycsICdwYW5lbFZpc2liaWxpdHlDaGFuZ2VkJywKLSAgICAgICAgJ19fY3JlYXRl TXVsdGlMaW5lU3RhdGlzdGljcycsICdfX2NyZWF0ZVNpbmdsZUxpbmVTdGF0aXN0aWNzJyk7Cisg ICAgICAgICdfX2NyZWF0ZU11bHRpTGluZVN0YXRpc3RpY3MnLCAnX19jcmVhdGVTaW5nbGVMaW5l U3RhdGlzdGljcycsICdfX2xvYWRNb3JlUm93cycpOwogCiAgICAgICBfLmV4dGVuZCgKICAgICAg ICAgdGhpcywgewpAQCAtMjUzLDEwICsyNTUsMjIgQEAgZGVmaW5lKCdtaXNjLnN0YXRpc3RpY3Mn LCBbCiAgICAgICAgICAgICBjbGVhclRpbWVvdXQodGltZXIpOwogICAgICAgICAgICAgJG1zZ0Nv bnRhaW5lci50ZXh0KCcnKTsKICAgICAgICAgICAgIGlmIChyZXMuZGF0YSkgewotICAgICAgICAg ICAgICB2YXIgZGF0YSA9IHJlcy5kYXRhOworICAgICAgICAgICAgICB2YXIgZGF0YSA9IHNlbGYu ZGF0YSA9IHJlcy5kYXRhOwogICAgICAgICAgICAgICBpZiAobm9kZS5oYXNDb2xsZWN0aXZlU3Rh dGlzdGljcyB8fCBkYXRhWydyb3dzJ10ubGVuZ3RoID4gMSkgeworICAgICAgICAgICAgICAgIC8v IExpc3RlbiBzY3JvbGwgZXZlbnQgdG8gbG9hZCBtb3JlIHJvd3MKKyAgICAgICAgICAgICAgICBw Z0Jyb3dzZXIuRXZlbnRzLm9uKAorICAgICAgICAgICAgICAgICAgJ3BnYWRtaW4tYnJvd3Nlcjpw YW5lbC1zdGF0aXN0aWNzOicgKworICAgICAgICAgICAgICAgICAgd2NEb2NrZXIuRVZFTlQuU0NS T0xMRUQsCisgICAgICAgICAgICAgICAgICBzZWxmLl9fbG9hZE1vcmVSb3dzCisgICAgICAgICAg ICAgICAgKTsKICAgICAgICAgICAgICAgICBzZWxmLl9fY3JlYXRlTXVsdGlMaW5lU3RhdGlzdGlj cy5jYWxsKHNlbGYsIGRhdGEsIG5vZGUuc3RhdHNQcmV0dGlmeUZpZWxkcyk7CiAgICAgICAgICAg ICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgLy8gRG8gbm90IGxpc3RlbiB0aGUgc2Nyb2xs IGV2ZW50CisgICAgICAgICAgICAgICAgcGdCcm93c2VyLkV2ZW50cy5vZmYoCisgICAgICAgICAg ICAgICAgICAncGdhZG1pbi1icm93c2VyOnBhbmVsLXN0YXRpc3RpY3M6JyArCisgICAgICAgICAg ICAgICAgICB3Y0RvY2tlci5FVkVOVC5TQ1JPTExFRCwKKyAgICAgICAgICAgICAgICAgIHNlbGYu X19sb2FkTW9yZVJvd3MKKyAgICAgICAgICAgICAgICApOwogICAgICAgICAgICAgICAgIHNlbGYu X19jcmVhdGVTaW5nbGVMaW5lU3RhdGlzdGljcy5jYWxsKHNlbGYsIGRhdGEsIG5vZGUuc3RhdHNQ cmV0dGlmeUZpZWxkcyk7CiAgICAgICAgICAgICAgIH0KIApAQCAtMzg2LDcgKzQwMCwxNyBAQCBk ZWZpbmUoJ21pc2Muc3RhdGlzdGljcycsIFsKIAogICAgICAgfQogCi0gICAgICB0aGlzLmNvbGxl Y3Rpb24ucmVzZXQocm93cyk7CisgICAgICB0aGlzLmNvbGxlY3Rpb24ucmVzZXQocm93cy5zcGxp Y2UoMCwgNTApKTsKKyAgICB9LAorCisgICAgX19sb2FkTW9yZVJvd3M6IGZ1bmN0aW9uKCkgewor ICAgICAgbGV0IGVsZW0gPSAkKCcucGctcGFuZWwtc3RhdGlzdGljcy1jb250YWluZXInKS5jbG9z ZXN0KCcud2NGcmFtZUNlbnRlcicpWzBdOworICAgICAgaWYgKChlbGVtLnNjcm9sbEhlaWdodCAt IDEwKSA8IGVsZW0uc2Nyb2xsVG9wICsgZWxlbS5vZmZzZXRIZWlnaHQpIHsKKyAgICAgICAgdmFy IHJvd3MgPSB0aGlzLmRhdGFbJ3Jvd3MnXTsKKyAgICAgICAgaWYgKHJvd3MubGVuZ3RoID4gMCkg eworICAgICAgICAgIHRoaXMuY29sbGVjdGlvbi5hZGQocm93cy5zcGxpY2UoMCwgNTApKTsKKyAg ICAgICAgfQorICAgICAgfQogICAgIH0sCiAKICAgICBfX2NyZWF0ZVNpbmdsZUxpbmVTdGF0aXN0 aWNzOiBmdW5jdGlvbihkYXRhLCBwcmV0dGlmeUZpZWxkcykgewo= --000000000000b86364058095ade5--