Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGAGI-00058m-UL for pgadmin-hackers@arkaria.postgresql.org; Wed, 31 May 2017 20:30:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dGAGH-0000Nm-Rf for pgadmin-hackers@arkaria.postgresql.org; Wed, 31 May 2017 20:30:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dGAG3-0008OJ-3U for pgadmin-hackers@postgresql.org; Wed, 31 May 2017 20:30:19 +0000 Received: from mail-it0-x233.google.com ([2607:f8b0:4001:c0b::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dGAFs-0001PI-Sb for pgadmin-hackers@postgresql.org; Wed, 31 May 2017 20:30:17 +0000 Received: by mail-it0-x233.google.com with SMTP id m47so3043892iti.0 for ; Wed, 31 May 2017 13:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DAnDVSJEcBrea1nyup2SMFcnPLcFKa1rlOTmKKigEjw=; b=VbS1Z4z/RPvNkcEy5++kkfqaBQMeFomGQcpnozWhrAZmNfPf27rg3zW4E31Togb261 x0j3QS4E/iNGQ2LPr8o7lTd324JBVJSAhS9EinaC6VhZRoxPT9WELaOHV6U0peJmHCkd l55xKPvjPgXISLzLt01Jdggbibvo7RPT773uOeYgxyV2j79gLsD+zXescwgdWHZju199 PWLB2KrId0TPPh88LDWzTsdSd6+VV9AHn/V8ycT9WQ0PN29N65LSu2aSuU6BLN/U/MQs UFOyYXfllkJ6AXRGZy6MKrJTn1zbsqMIhT1qrDY7NfL1GxjJBRPTmhJt4GA91uDGr0rk X7xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DAnDVSJEcBrea1nyup2SMFcnPLcFKa1rlOTmKKigEjw=; b=k6HfAuygrKfWgCwdxFC5Ur+5E9kHbal3KYYZ3ebQPU+7LS+6Qc8oSd8EBoDc5ch9KH 2wP4xcdQMHXulxbeNlqwUeXI2s5PzkcrT2Fb4A7Pe3LdhfdwVZSBUV0Wy+3nMvWgUbK/ Ib68FFuyPMU0ntiKYZAm3nROXf/PWROmB8ZNJbXDdD/Nb4HsHKrVLBf4iVrKU/MEZGAI YuECBPRXnbnFYlleMShSZlPS9J2P3jxZ+kWLGRHCeQKEinhT3jAFZDY3kTwdsrGb/NTz k22V4s5NPw0CbWELHUenXXshN0OWXqvP02SlEvvNw5JHA6CMb0jiGKUBbRMIYkRoWmVS yh0w== X-Gm-Message-State: AODbwcDLyF7sJ8ezNZVROBLrH4gm1kTys1OsderpK8A8EvgUndfMUec/ X/NEDwxCxkTFYsemJvJSDHevpm4kSyd4 X-Received: by 10.36.228.8 with SMTP id o8mr9592958ith.37.1496262606103; Wed, 31 May 2017 13:30:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.185.70 with HTTP; Wed, 31 May 2017 13:29:35 -0700 (PDT) In-Reply-To: References: From: Matthew Kleiman Date: Wed, 31 May 2017 16:29:35 -0400 Message-ID: Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React To: Surinder Kumar Cc: Joao Pedro De Almeida Pereira , Dave Page , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c1113c820c5370550d7c909" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c1113c820c5370550d7c909 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Surinder, Is it possible to run the task listed above by configuring them in > "scripts" in package.json file and running concurrently ? That would be cleaner than what we proposed. We could use the yarn run feature to do just what you are suggesting. It works the same as in npm. Something like the following: In package.json - "scripts": { "linter": "eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js" } To call it on the command line - yarn run linter - Matt On Wed, May 31, 2017 at 12:35 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > On Wed, May 31, 2017 at 12:01 AM, Joao Pedro De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> The motivation is simple - we want a solution that works for the whole >>> app, can handle debug vs. release execution, pluggable modules, and >>> installations in read-only directories. >> >> With the current configuration of Grunt, all the requirements you mentio= n >> are available. >> The tasks on Grunt should only be run under development or before we are >> creating the installer. >> > > >> The installer should pick up only the bundled Javascript and should >> install it in the correct folders, this way there is no need to rewrite = or >> process files in read-only directories of the end user machine. >> >> Per the other thread on the subject (that Joao suggested continuing >>> discussion on), Surinder is currently looking into flask-webpack. I >>> spent some time playing with grunt and some other options last week. >> >> We should continue the discussion about flask-webpack or Grunt or any >> other Build system in the other thread, but we need to have some decisio= n >> because this patch needs a build system. >> If we remove Grunt from this patch we will need to execute the following >> command every time the application run: >> >> yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/= *.js >> regression/javascript/**/*.jsx regression/javascript/**/*.js *.js && yar= n >> run webpack -- --config webpack.config.js && python web/pgAdmin4 >> >> And to run the jasmine tests: >> >> yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/= *.js >> regression/javascript/**/*.jsx regression/javascript/**/*.js *.js && yar= n >> run karma start >> >> And to run the feature tests: >> >> yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/= *.js >> regression/javascript/**/*.jsx regression/javascript/**/*.js *.js && yar= n >> run webpack -- --config webpack.config.js && python runtests.py >> >> Is this a solution that is acceptable? >> > > As per my knowledge, Grunt can run the tasks and bundle the JS and CSS > files (using r.js which is not preferred). But Webpack can not do both. I= t > can only bundle files, it has to be used with either Grunt or Gulp to > execute tasks. > > Is it possible to run the task listed above by configuring them in > "scripts" in package.json file and running concurrently ? > > scripts: { > "task-name1": "yarn run eslint filename", > =E2=80=8B =E2=80=8B > "task-name2": "yarn run karma start", so on... > } > > and run them using following command: > npm run task-name1 > > >> >> However; this patch is supposed to be about the history tab rewrite. >>> Whatever solution we use for webpacking/transpiling/linting/minifying >>> etc, it should be a standalone change as it's decidedly non-trivial. >> >> We split this patch into 2 different commits: >> 1 - Add React and all the tools needed to work with it, this includes >> Grunt, Webpack and ESLint >> 2 - Change the history tab >> >> Do you want a single commit for each of the following? >> React (just adds the React library via yarn) >> Webpack (adds Webpack library via yarn and creates the >> webpack.config.js) >> ESLint (adds ESLint library via yarn, creates .eslintrc config file, >> and corrects all lint errors that previously existed) >> Grunt (adds Grunt library via yarn and creates Gruntfile.js config, >> creating a pipeline of the previous three libraries/tasks) >> Our change to History >> >> Thanks >> Joao & Matt >> >> On Tue, May 30, 2017 at 10:10 AM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, May 30, 2017 at 2:47 PM, Matthew Kleiman >>> wrote: >>> > Hi Dave, >>> > >>> > We are currently using the Grunt taskrunner to run the following task= s: >>> > >>> > lint the javascript code >>> > start javascript tests >>> > invoke webpack to transpile and bundle js and jsx files >>> > minify javascript >>> > >>> > In order to remove Grunt from the application, we will need some othe= r >>> tool >>> > to execute these listed tasks. >>> > >>> > There are other tools available, like Gulp.js, that we could use >>> instead of >>> > Grunt. We would like to understand your motivation for removing Grunt >>> so we >>> > can find a better solution. >>> >>> The motivation is simple - we want a solution that works for the whole >>> app, can handle debug vs. release execution, pluggable modules, and >>> installations in read-only directories. >>> >>> Per the other thread on the subject (that Joao suggested continuing >>> discussion on), Surinder is currently looking into flask-webpack. I >>> spent some time playing with grunt and some other options last week. >>> >>> However; this patch is supposed to be about the history tab rewrite. >>> Whatever solution we use for webpacking/transpiling/linting/minifying >>> etc, it should be a standalone change as it's decidedly non-trivial. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --94eb2c1113c820c5370550d7c909 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey Surinder,

Is it possible to run the task listed above by con= figuring them in "scripts" in package.json file and running concu= rrently ?

That would be cleaner than = what we proposed. We could use the yarn run feature to do just what you are suggesting. It w= orks the same as in npm.
Something like the following:
= In package.json -=C2=A0
"= ;scripts": {
=C2=A0 "linter": "eslint pgadmin/static= /jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.j= sx regression/javascript/**/*.js *.js"
}

To call it o= n the command line -
yarn run linte= r

- Matt

On Wed, May 31, 2017 at 12:35 AM, Surinder Kumar <<= a href=3D"mailto:surinder.kumar@enterprisedb.com" target=3D"_blank">surinde= r.kumar@enterprisedb.com> wrote:
On Wed, May 31, 2017 at 12:01 AM, Joao Pedro De Almeid= a Pereira <jdealmeidapereira@pivotal.io> wrote:
The motiva= tion is simple - we want a solution that works for the whole
app, can handle debug vs. release execution, p= luggable modules, and
installati= ons in read-only directories.
With the curre= nt configuration of Grunt, all the requirements you mention are available.<= br>
The tasks on Grunt should only be run under development or be= fore we are creating the installer.


The installer should pick up only the bundled Javascript and should inst= all it in the correct folders, this way there is no need to rewrite or proc= ess files in read-only directories of the end user machine.

Per the other thread on the subject (that Joao sug= gested continuing
discussion on)= , Surinder is currently looking into flask-webpack. I
spent some time playing with grunt and some other opt= ions last week.
We should continue the discu= ssion about flask-webpack or Grunt or any other Build system in the other t= hread, but we need to have some decision because this patch needs a build s= ystem.
If we remove Grunt from this patch we will need to execute= the following command every time the application run:

=
yarn run eslint pgadmin/static/jsx= /**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.= jsx regression/javascript/**/*.js *.js=C2=A0&& yarn run webpack -- = --config webpack.config.js && python web/pgAdmin4
=
And to run the jasmine tests:

yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/stat= ic/js/selection/*.js regression/javascript/**/*.jsx regression/javascr= ipt/**/*.js *.js=C2=A0&&= =C2=A0yarn run karma start

And t= o run the feature tests:

yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/sele= ction/*.js regression/javascript/**/*.jsx regression/javascript/**/*.j= s *.js=C2=A0&& yarn run webpack=C2=A0-- --config=C2=A0webpack.config.js && python runtests.py

Is this a solution that is acceptable?=C2=A0

As per my knowledge, Grunt can run the tasks and bundle the JS and = CSS files (using r.js which is not preferred). But Webpack can not do both.= It can only bundle files, it has to be used with either Grunt or Gulp to e= xecute tasks.

Is it possible to run the task listed above by configuring them= in "scripts" in package.json file and running concurrently ?

scrip= ts: {
=C2=A0"task-name1": "yarn run eslint filename&quo= t;,
=E2=80=8B =E2=80=8B
"task-name2": "yarn run karma sta= rt", so on...
}

and run them using following= command:
npm run task-name1
=C2=A0

However; this patch is supposed to be = about the history tab rewrite.
W= hatever solution we use for webpacking/transpiling/linting/minifying
etc, it should be a standalone change as it's decidedly non-triv= ial.
We split this patch into 2 different co= mmits:
1 - Add React and all the tools needed to work with it, th= is includes Grunt, Webpack and ESLint
2 - Change the history tab<= /div>

Do you want a single commit for each of the follow= ing?=C2=A0
=C2=A0 React (just adds the React library via yarn)
=C2=A0 Webpack (adds Webpack library via yarn and creates the webpa= ck.config.js)
=C2=A0 ESLint (adds ESLint library via yarn, create= s .eslintrc config file, and corrects all lint errors that previously exist= ed)
=C2=A0 Grunt (adds Grunt library via yarn and creates Gruntfi= le.js config, creating a pipeline of the previous three libraries/tasks)
=C2=A0 Our change to History

Thanks
<= div>Joao & Matt=C2=A0

On Tue, May 30, 2017 at 10:10 AM, = Dave Page <dpage@pgadmin.org> wrote:
Hi<= br>
On Tue, May 30, 2017 at 2:47 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:
> Hi Dave,
>
> We are currently using the Grunt taskrunner to run the fo= llowing tasks:
>
> lint the javascript code
> start javascript tests
> invoke webpack to transpile and bundle js and jsx files
> minify javascript
>
> In order to remove Grunt from the application, we will need some other= tool
> to execute these listed tasks.
>
> There are other tools available, like Gulp.js, that we could use inste= ad of
> Grunt. We would like to understand your motivation for removing Grunt = so we
> can find a better solution.

The motivation is simple - we want a solution that works for the who= le
app, can handle debug vs. release execution, pluggable modules, and
installations in read-only directories.

Per the other thread on the subject (that Joao suggested continuing
discussion on), Surinder is currently looking into flask-webpack. I
spent some time playing with grunt and some other options last week.

However; this patch is supposed to be about the history tab rewrite.
Whatever solution we use for webpacking/transpiling/linting/minifying<= br> etc, it should be a standalone change as it's decidedly non-trivial.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--94eb2c1113c820c5370550d7c909--