Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDWTI-0000hq-2I for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 May 2017 13:37:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dDWTH-000629-LG for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 May 2017 13:37:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dDWT2-0005dL-Tk for pgadmin-hackers@postgresql.org; Wed, 24 May 2017 13:36:49 +0000 Received: from mail-it0-x233.google.com ([2607:f8b0:4001:c0b::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dDWSy-0000ui-34 for pgadmin-hackers@postgresql.org; Wed, 24 May 2017 13:36:48 +0000 Received: by mail-it0-x233.google.com with SMTP id r63so38973640itc.1 for ; Wed, 24 May 2017 06:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3UYN/tp4iHhRpE/HPj21HyxtDgDh1nQtsPT71ikGez0=; b=1fmA1mUCIntyypogudzGdVVPMardG9/2yyXNSQdZ8PLwFHxTprwOoTc6QuxNFjbGaY dULvHqMLT1UF5GHIbOtLoW4elK/5xRwPwK+kdQbPT3vLLqtN8dLSAk0mtYzKvMvwzIXj V+m6dGchfHeQRYRgZT3joICr8FyFdrpdxZKuFgrtqaKJCsAI91pexgEDo+rGkSJ96wAs ktpeOAck5Q0EtGlni/sK79ygfUkPAQQFycx2WMSnd6ULK1g0MctG671xHYeB8lSmBlhW m3A1huwCTKhwMvgkeplNNSaQhfBnDP8C8+ScRJAY6wZd7A9vqAz9rnRNZhJVj8pkZCqZ Wwrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3UYN/tp4iHhRpE/HPj21HyxtDgDh1nQtsPT71ikGez0=; b=laHvis9AcycpL8QqtK7pNN8nzKS0i2VDk0fLxoiZeWVqLE8I9MbdK5tV99pe6LziiU cwZz/DsQiTbJgrFLyqlIotmbYO/2oMdkAoCuhNEbZ5RJpGfBsjh+s6x3zAEGmSVnLM9F XkXJEbF1KYjvVIEY9d9Xsos1jgkGqN+89D9OFGQYy7IEcT6/5dD4I1MYh+fuzSwBeS71 TF8S7v0R9b8+ildBeaVUQWoDOCJoAkraSh586rEES3F/BcXd4I9UFOucDH9DgSUjAyOR KiaMP+jQkZgISnQ+Btx83VW/bm629oQpIdUD4xbZbVH3LCrAPEUTU81Hm0x8DQUWSdv4 KoXg== X-Gm-Message-State: AODbwcBGc7pFmb8YwoJgIN6tnCXNwf7Rc2jRgoylRM4lSgCCfRRfMku7 JL27H/NCj3uIMovZffRVlq7coyonHS/8 X-Received: by 10.36.127.200 with SMTP id r191mr8524841itc.91.1495633001406; Wed, 24 May 2017 06:36:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.185.70 with HTTP; Wed, 24 May 2017 06:36:20 -0700 (PDT) In-Reply-To: References: From: Matthew Kleiman Date: Wed, 24 May 2017 09:36:20 -0400 Message-ID: Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React To: Dave Page Cc: Joao Pedro De Almeida Pereira , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1147c91ec447fa055045319d" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1147c91ec447fa055045319d Content-Type: text/plain; charset="UTF-8" Hi Dave, This one is our bad! We didn't create a grunt task to run the tests only once, as you would in CI. grunt tests currently runs the tests and continues to watch for changes, running the tests again each time the source code is modified. We will create a task that is suitable to run in CI. In the meantime, if you have any free time during the day today and would like to schedule a sync call with us, that would help us to tighten the feedback loop. Thanks, Joao & Matt On Tue, May 23, 2017 at 4:44 PM, Dave Page wrote: > On Tue, May 23, 2017 at 12:12 PM, Joao Pedro De Almeida Pereira > wrote: > > Okay > > > > Can you try removing web/node_modules and web/yarn.lock, and running > > $ yarn install > > $ grunt tests > > > > We think this might be due to a bad version of phantomjs-prebuilt. > > > > If that still fails, can you try running grunt as "yarn run grunt tests"? > > I'm on a different machine now, and here grunt just seems to never > exit when it's doing anything. For example, I ran this a few minutes > ago, it finished in seconds and has been sitting here ever since: > > (pgadmin4)snake:web dpage$ grunt tests > Running "eslint:target" (eslint) task > > Running "karma:unit" (karma) task > > webpack: Compiled successfully. > webpack: Compiling... > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > (node:4902) DeprecationWarning: loaderUtils.parseQuery() received a > non-string value which can be problematic, see > https://github.com/webpack/loader-utils/issues/56 > parseQuery() will be replaced with getOptions() in the next major > version of loader-utils. > 23 05 2017 16:41:54.549:WARN [karma]: No captured browser, open > http://localhost:9876/ > > webpack: Compiled successfully. > PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 87 of 88 (skipped 1) > SUCCESS (1.353 secs / 1.328 secs) > > I'm quite unimpressed with it so far :-( > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1147c91ec447fa055045319d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

This one is our bad! We didn&#= 39;t create a grunt task to run the tests only once, as you would in CI. gr= unt tests currently runs the tests and continues to watch for changes, runn= ing the tests again each time the source code is modified. We will create a= task that is suitable to run in CI.

In the meanti= me, if you have any free time during the day today and would like to schedu= le a sync call with us, that would help us to tighten the feedback loop.

Thanks,
Joao & Matt

On Tue, May 23, 2017 at = 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:
On Tue, May 23, 2017 at 12:12 PM, Joao= Pedro De Almeida Pereira
<jdealmeidapereira@pivot= al.io> wrote:
> Okay
>
> Can you try removing web/node_modules and web/yarn.lock, and running > $ yarn install
> $ grunt tests
>
> We think this might be due to a bad version of phantomjs-prebuilt.
>
> If that still fails, can you try running grunt as "yarn run grunt= tests"?

I'm on a different machine now, and here grunt just seems to nev= er
exit when it's doing anything. For example, I ran this a few minutes ago, it finished in seconds and has been sitting here ever since:

(pgadmin4)snake:web dpage$ grunt tests
Running "eslint:target" (eslint) task

Running "karma:unit" (karma) task

webpack: Compiled successfully.
webpack: Compiling...
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
(node:4902) DeprecationWarning: loaderUtils.parseQuery() received a<= br> non-string value which can be problematic, see
https://github.com/webpack/loader-utils/issues= /56
parseQuery() will be replaced with getOptions() in the next major
version of loader-utils.
23 05 2017 16:41:54.549:WARN [karma]: No captured browser, open
http://localhost:9876/

webpack: Compiled successfully.
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 87 of 88 (skipped 1)
SUCCESS (1.353 secs / 1.328 secs)

I'm quite unimpressed with it so far :-(

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1147c91ec447fa055045319d--