Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBNUS-0000hc-Ow for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 15:37:24 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dBNUR-0001yL-Vf for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 15:37:24 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dBNUR-0001yC-Gf for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 15:37:23 +0000 Received: from mail-it0-x22e.google.com ([2607:f8b0:4001:c0b::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dBNUO-0007SE-3Q for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 15:37:22 +0000 Received: by mail-it0-x22e.google.com with SMTP id o5so102449352ith.1 for ; Thu, 18 May 2017 08:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PvrQw5WJO4XMqb88sXouXT+XC5who3FCvqdyq8d+wts=; b=KCG0otM4JEU+bwGJh/eKrtxyxDlIWnDAO+klVzJkKDfeDPUf8eFVDniOMJg6dvO0z6 aIQCeleUhoHIGgBTCbssB3V1V4v2BdvIQHhDHApzbi9MGaRCe80aZ0O6saqO4+t3d9FB mx0+nnFb9mhMeSRdyAgSG6y7q2CzgYb36GTPvu0IXOgRyoYrwivZjnsVcom+zgWl6IXB aA5AxSdBOTLkSyqGG+ALweIF8R9eQJR0stHhPXVuKxV2M+WVjFoYJmGSBIrg0KRYySR9 xXAdqOrQGgfGSHzyfOk1+sxKkE7LIPRnvYu9Lr0Kb5+EfW+jxkwyUWxeEoDwbt6DsLNL GXgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PvrQw5WJO4XMqb88sXouXT+XC5who3FCvqdyq8d+wts=; b=SNBaFufw3QCWhX46SWUgjIhGEivU3ZWMxm5cd8N5S77pt6cOSERSu/1vw5fmBuSY38 7TDeqY8p1qmPo9/tJiZCAeb1K64JdegtLHATYGXSItUfCu+Qa4PeuIP2GozgQvIlLGwR gxK418IqgFpcjKQpkk6Is4g5sbK++YSY7EnxwNgOgydpwMgirW120fShzHHBFuY/frn8 Y887SzFoGLOTmGMHae7+xCvoLuqyctrBhR9b2QiCtCu5fvFk++IYV/6FGpTRWMkX0UPN cRdrPN4onszUs3Y3c8mxzmX5fp0B5fW+e9hbmYPdUnCd+7AaZ+AJ64o7YMCoZEmmhccW u54Q== X-Gm-Message-State: AODbwcCB0iiLKHiAZDRuPeN1bY8wYK+6g3PD5zLliW9O8PGrNj9w5sqX E9e8mpwIDrFN345DogT+heSnYxz1at1c X-Received: by 10.36.228.8 with SMTP id o8mr23582045ith.37.1495121837445; Thu, 18 May 2017 08:37:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Matthew Kleiman Date: Thu, 18 May 2017 15:37:07 +0000 Message-ID: Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React To: Dave Page , Murtuza Zabuawala Cc: pgadmin-hackers , Shruti B Iyer Content-Type: multipart/alternative; boundary="94eb2c1113c8046d03054fce2e42" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c1113c8046d03054fce2e42 Content-Type: text/plain; charset="UTF-8" Dave, Can you try running grunt tests on the command line? The tests task will run the eslint and karma grunt tasks, which should automatically webpack the React components before running the jasmine tests in karma. If it still fails, send us the output of that. Thanks, Matt On Thu, May 18, 2017 at 5:31 AM Dave Page wrote: > Hi > > On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> >> Go to 'pgadmin4/web' directory >> >> Try running, >> >> run 'yarn install' >> >> (if you have installed globally) >> then run 'grunt' >> OR >> run './node_modules/grunt-cli/bin/grunt' >> >> >> Then run pgAdmin4 >> > > OK, that worked - though pgAdmin now takes a lot longer to start up, which > is a problem. > > The Jasmine tests now fail: > > (pgadmin4)piranha:web dpage$ yarn run karma start --single-run > yarn run v0.24.4 > $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/karma" start > 18 05 2017 10:22:01.182:ERROR [plugin]: Error during loading > "karma-phantomjs-launcher" plugin: > Path must be a string. Received null > > webpack: Compiled successfully. > webpack: Compiling... > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > (node:12214) DeprecationWarning: loaderUtils.parseQuery() received a > non-string value which can be problematic, see > https://github.com/webpack/loader-utils/issues/56 > parseQuery() will be replaced with getOptions() in the next major version > of loader-utils. > 18 05 2017 10:22:07.281:WARN [karma]: No captured browser, open > http://localhost:9876/ > > webpack: Compiled successfully. > 18 05 2017 10:22:07.294:ERROR [karma]: Found 1 load error > error Command failed with exit code 1. > info Visit https://yarnpkg.com/en/docs/cli/run for documentation about > this command. > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c1113c8046d03054fce2e42 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Dave,

Can you try running grunt tests=C2=A0on the command line?=C2=A0
The tests task will run the eslint and karma grunt tasks, which should au= tomatically webpack the React components before running the jasmine tests i= n karma.

If it still fails, send us the output of = that.

Thanks,
Matt

On Thu, May 18, 2017 at 5:31 AM Dave = Page <dpage@pgadmin.org> wro= te:
Hi

On Thu, May= 18, 2017 at 9:56 AM, Murtuza Zabuawala <murtuza.zabuawal= a@enterprisedb.com> wrote:

Go to 'pgadmin4= /web' directory

Try running,
run 'yarn install'

(if you hav= e installed globally)
then run 'grunt'=C2=A0
OR
run './node_modules/grunt-cli/bin/grunt'
<= br>

Then run pgAdmin4

OK, that worked - though pgAdmin now takes a = lot longer to start up, which is a problem.

The Ja= smine tests now fail:

(pgadmin4)piranha:web dpage$= yarn run karma start --single-run
yarn run v0.24.4
$ &= quot;/Users/dpage/git/pgadmin4/web/node_modules/.bin/karma" start
18 05 2017 10:22:01.182:ERROR [plugin]: Error during loading "ka= rma-phantomjs-launcher" plugin:
=C2=A0 Path must be a string= . Received null

webpack: Compiled successfully.
webpack: Compiling...
webpack: wait until bundle finished= :=C2=A0
webpack: wait until bundle finished:=C2=A0
webp= ack: wait until bundle finished:=C2=A0
webpack: wait until bundle= finished:=C2=A0
webpack: wait until bundle finished:=C2=A0
=
webpack: wait until bundle finished:=C2=A0
webpack: wait unt= il bundle finished:=C2=A0
webpack: wait until bundle finished:=C2= =A0
webpack: wait until bundle finished:=C2=A0
webpack:= wait until bundle finished:=C2=A0
webpack: wait until bundle fin= ished:=C2=A0
webpack: wait until bundle finished:=C2=A0
(node:12214) DeprecationWarning: loaderUtils.parseQuery() received a non-s= tring value which can be problematic, see https://github.com/webpack/l= oader-utils/issues/56
parseQuery() will be replaced with getO= ptions() in the next major version of loader-utils.
18 05 2017 10= :22:07.281:WARN [karma]: No captured browser, open http://localhost:9876/

webpack: Compiled successfully.
18 05 2017 10:22:07.294:ERR= OR [karma]: Found 1 load error
error Command failed with exit cod= e 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation = about this command.=C2=A0



--
Dave Pag= e
Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprise= db.com
The Enterprise PostgreSQL Company
--94eb2c1113c8046d03054fce2e42--