Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvRSg-00077M-BF for pgadmin-hackers@arkaria.postgresql.org; Tue, 04 Apr 2017 16:37:42 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cvRSe-0000xB-Ud for pgadmin-hackers@arkaria.postgresql.org; Tue, 04 Apr 2017 16:37:40 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cvRSe-0000wv-9b for pgadmin-hackers@postgresql.org; Tue, 04 Apr 2017 16:37:40 +0000 Received: from mail-it0-x234.google.com ([2607:f8b0:4001:c0b::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cvRSa-0004f5-Ni for pgadmin-hackers@postgresql.org; Tue, 04 Apr 2017 16:37:38 +0000 Received: by mail-it0-x234.google.com with SMTP id y18so67972328itc.0 for ; Tue, 04 Apr 2017 09:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fmFqdqJTBtJEcGkR/ORdeNRAoZS9kmO20w3BEqbrcnM=; b=BmSk2x4BxSJnXAydc6CHa9f9stzheMKLvI+uUbRX2lrPOwKzIvUgBqF7IJX8DkNwHb DE4YaFrF9kXdY7l7ffRS9fJZQu/EnlzpbOi8hLwusyakA+uncLoHqD8Gj+n9SAqse4At JBR12Lq5JkBblcl7lTD4bqTxIHUOv4a02k0bf0TefqZIZrBTb+Qxuw8kXdJFsEiB3MlX tCvC+AFpXGoQird/sA55VNmXyzywJ55YCEzNYSUMLroGuD5sV4R4/ldYC21WMXm8Xq7p CTBCYM69t26y8zvdW49H+e2hv1hjjep6+uby1a2LOY5e219uyqGjmyKTiFzrMcudF03w H/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fmFqdqJTBtJEcGkR/ORdeNRAoZS9kmO20w3BEqbrcnM=; b=iNiYqS9uSdoGptnz+kgAbV/BY5MzQVeUOks+D39L8f+sUA/abkdw3+zpJTwl9H+47+ pfiVZzse57vFy8EfOn7vvY/jdi6eGZc23lKLQkXHWMKBg9uOVDR3xPUn2PXjpm/HrAHu H3zpDsIiTQMjudPj2Iov102VC7lPCj2dZGihCr3QbGQxjg35vxnyyJOyD/D6LXkLmxUd dcIL04xihsR1ogDCdkLUIj6DfBKNAvyJM99sGmZUo49hdfMjJ3Nk9hxhnKHLjW7bpBw2 kXLfawZW9Kvr+AoRN5s4siBNY5n+7HaqAxckLtLmEJxArJiyZ4z2T7MyN9NnNEfESCkZ 7kHA== X-Gm-Message-State: AFeK/H3dd8hCzqhSQGauNy87cv+4KQ0/nnnkdYVcJs01DHX9PSQU3tUN J3BktZfY9uwc2JPmqucAQOx83D8jbTM4 X-Received: by 10.36.127.6 with SMTP id r6mr16052288itc.96.1491323855393; Tue, 04 Apr 2017 09:37:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.15.104 with HTTP; Tue, 4 Apr 2017 09:37:34 -0700 (PDT) In-Reply-To: References: From: Matthew Kleiman Date: Tue, 4 Apr 2017 12:37:34 -0400 Message-ID: Subject: Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values To: Surinder Kumar Cc: pgadmin-hackers , George Gelashvili Content-Type: multipart/alternative; boundary=001a11475152a57f8e054c59e4c6 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11475152a57f8e054c59e4c6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Surinder, We looked at your fix for default values in the query tool editor. We think the user experience could be further improved by seeing the actual default value instead of the empty cell. As an intermediate step, there would be user value in seeing "[default]" instead of the blank cell (or what used to be "[null]"). Thanks, George and Matt On Sat, Apr 1, 2017 at 7:45 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi > > Issues fixed: > > 1. If a column is defined with a default modifier, there is now way to > insert the row with those defaults. > The column will be left blank and it will take default value automaticall= y. > > 2. If a column has a not-null constraint then an error is returned and > the row is not inserted. > The column will be left blank > =E2=80=8B =E2=80=8B > > =E2=80=8BThe default values for new added rows will be displayed on > refresh/execute. > > Please find attached patch and review. > > > Thanks > Surinder > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a11475152a57f8e054c59e4c6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Surinder,

We looked at your fix for = default values in the query tool editor.

We think the user experienc= e could be further improved by seeing the actual default value instead of t= he empty cell.

As an intermediate step, there woul= d be user value in seeing "[default]" instead of the blank cell (= or what used to be "[null]").

Thank= s,
George and Matt



On Sat, Apr 1, 2= 017 at 7:45 AM, Surinder Kumar <surinder.kumar@enterprisedb.= com> wrote:
Hi

Issues fixed:

1. If a co= lumn is defined with a default modifier, there is now way to insert the row= with those defaults.
The column will be left blank and it will= take default value automatically.

2.=C2=A0I= f a column has a not-null constraint then an error is returned and the row = is not inserted.
The column will be left blank
=E2=80=8B =E2=80=8B

=E2=80=8BThe default values for new added rows will be displayed on refr= esh/execute.
Please= find attached patch and review.


Th= anks
Surinder


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers


--001a11475152a57f8e054c59e4c6--