Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs2Gn-000265-HA for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 09:48:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hs2Gl-0000nr-7E for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 09:48:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs2Gk-0000nj-UO for pgadmin-hackers@lists.postgresql.org; Mon, 29 Jul 2019 09:48:39 +0000 Received: from mail-yw1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs2GY-0005Aa-77 for pgadmin-hackers@postgresql.org; Mon, 29 Jul 2019 09:48:38 +0000 Received: by mail-yw1-xc2a.google.com with SMTP id l79so22408635ywe.11 for ; Mon, 29 Jul 2019 02:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5LTfTQFjXeEH+qC/DNCvRs+09Hh0qsCjRPFoV1VuSKM=; b=R9IOIB1K+xl57lM8Yf91KLAO0gO0zRKROMzF4juoFFftXr36mUQeaQhthV1HFWUEPW VRwrmYU2q5D7wu3F2lXBBxFZ3x6BRHMwTNtYvjH2VC79uOIC2rtVAzynmcw2B3JzGxQa gFVrEANQ6mKtjVsCotOlX0y9g7sSTu1X+Temes3vm/kUacttX09kcjWu+CRkCmQWGTKK 7AoHRIShgRthjnGn2QXsq+chmurjBaYdESnDzW+0kY3nuYQGdh9myGXredDjaVwkJ0dT ba1zuqAvd9QepS/tzUM4llW2J2BoJfBnyvWBwdLi2izWzRjtB2DeaEweSzHv1JgdiqXn YrIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5LTfTQFjXeEH+qC/DNCvRs+09Hh0qsCjRPFoV1VuSKM=; b=lhZ65tEj70HFtEUCi3QQQQeIR9ZjNvI9s7as41rpOl3enQbed/r8r13s3jXmT1OkUq B+211s5vvXQlb0JWnk4JD0V4JoBSxec2s8FNkdcI4Ue8AFq8RKneH6Jdr1f4vqr0ahNc 2N90RcCT/rXZ55pA3m16pcYesDS+I0nR7HcpzGqLsnixuXhy8PQc0L1R3Iey+vmnEeAH 8lGDuE1rQmYvQCpjJwLiI2UeCUbFgHiDNdx8kVzA/3r3w1Zmy4Lm4hWM+LIAVBlAlrYy FmHPHxqrK/+OAD9umRzxpC2nBl2RzF5lzGnoaTVWV65RFe0rLJVO2vaxjAvTCl+SHWqV rg6g== X-Gm-Message-State: APjAAAVctj04Sth9d39CstMZBj07cVhMyiUtYBSLGJ82juyHAaVhjBOU fn7gxbv5vUzJ73SYD68AM3a4eyXqtqBd1uqMi3E= X-Google-Smtp-Source: APXvYqx0Uikm/P9psGmg11moE0OSow8PGQ0oV1Im8eMpAx1B4A6ZLWw90gsrWq/7aly4avasNlTEYJd4Ob3DDa4dE4o= X-Received: by 2002:a81:8287:: with SMTP id s129mr63868231ywf.453.1564393704008; Mon, 29 Jul 2019 02:48:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yosry Muhammad Date: Mon, 29 Jul 2019 05:48:11 -0400 Message-ID: Subject: Re: [GSoC] Support editing resultsets from tables with OIDs To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000004304d058ececb51" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000004304d058ececb51 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 29, 2019, 4:26 AM Dave Page wrote: > Hi Yosry and Akshay > > On Fri, Jul 26, 2019 at 1:02 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> >> On the subject of the regression test - I assume at one point the >> messages window was including the command tags in it's output. This failure >> would indicate we broken that. Anyone got any ideas how that happened? >> > > Based on the number of tickets being logged about the lack of command tags > in the messages panel since we released 4.11, it's clear this was broken > and the test was valid all along. Can you look into that ASAP please Yosry? > Sure, will do. --00000000000004304d058ececb51 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jul 29, 2019, 4:26 AM Dave Page <dpage@pgadmin.org> wrote:
Hi Yosry and Akshay
On Fri, J= ul 26, 2019 at 1:02 PM Dave Page <dpage@pgadmin.org> wrote:
Aksha= y; can you take a look at this and commit if appropriate please? I'm so= mewhat busy at the moment :-(

On the subject of the regr= ession test - I assume at one point the messages window was including the c= ommand tags in it's output. This failure would indicate we broken that.= Anyone got any ideas how that happened?

<= /div>
Based on the number of tickets being logged about the lack of com= mand tags in the messages panel since we released 4.11, it's clear this= was broken and the test was valid all along. Can you look into that ASAP p= lease Yosry?
Sure, will do.
--00000000000004304d058ececb51--