Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hfnEv-00041Q-SZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Jun 2019 15:20:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hfnEu-0002T7-Mo for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Jun 2019 15:20:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hfnEu-0002T0-CZ for pgadmin-hackers@lists.postgresql.org; Tue, 25 Jun 2019 15:20:08 +0000 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hfnEr-0006wd-Dv for pgadmin-hackers@postgresql.org; Tue, 25 Jun 2019 15:20:07 +0000 Received: by mail-qt1-x830.google.com with SMTP id x47so18774845qtk.11 for ; Tue, 25 Jun 2019 08:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=BToya5MEpKTzWmFLYaI2exjpi4zrbmIo3TFcbAFQH4Y=; b=TkKESD/Bob6IjJZNizhYLD90xSTFxqu+NoRJIm9LWfiYaz+yBacMGYZeeDKyoIVFbr ik/N1d65jf3H3YAkJOApRZdgOLIz9+QmCij47U4angZN0hlhcfWnvU17zynmVhXU86Z/ KvvEVz8CdJiImywVlKcJ2ifM8dJrWXcR9KGGd9eA7HF/GWeGnR4cf5j4vbeKW691Tc1I sNAQRChtfr8NyRHXTdN990IxttWSXyVfLgy3hZMGBYLbht2/2eujZmKdfdToWsVlX1K2 PzHIXoKk1e6NTLWTXMB8uiLZe02yDc/z+N1gz2BNRj+1iWVJVnX0yfF1zA9mrLQyKwCu 3GpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=BToya5MEpKTzWmFLYaI2exjpi4zrbmIo3TFcbAFQH4Y=; b=sXWRmT2spQ1ByrKeNfvyazF/i4RxapgYKB5FRv7vmeYFJIun7Vqoh2z51krWm0TJbE xjNV9rMaxJ8QCbPkDyXNGS/TAT8fyXrpynaSIsQCLvKzpocO+RmEKKVH7qAGLk+sfvLe cKevilOduJGdR4N8YQSQRBKQOASJP6nyAyCU+HOAotvL5/C83Kgu7/QkN1SHLiS2Da66 IBAIqhS2yUTWGUKwZmoENKG3twZy4ZdF4UGgGFU/rdhqYrUa1biDVMgTRW89FfZCwaNt GSQn/WFBBRB2dN+964G8KrX+OxKG8PEvGbntCC/llfTXHTsKVhk1niZbvH5kkXscwQU/ qZIA== X-Gm-Message-State: APjAAAV224hVxr0osMFsmyNUsa8BjpcITwls/yzRcfUUnfXP6cVTbtiI +i5mRJzAPYNYa1O3EUeTdQDRY4yInv3W0AfR/TRzi0Zj X-Google-Smtp-Source: APXvYqz6QQYfRQ5bxZfqA/5m2d5UT26j8qtsR2ejFSYi7dPZRVsC9WMa0zvrPulY4e1RXoKxCzRaZ6RnWmckpgeS510= X-Received: by 2002:a0c:baa8:: with SMTP id x40mr43315074qvf.168.1561476004637; Tue, 25 Jun 2019 08:20:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yosry Muhammad Date: Tue, 25 Jun 2019 17:19:53 +0200 Message-ID: Subject: Re: [GSoC][Patch] Automatic Mode Detection V1 To: Dave Page , Aditya Toshniwal , pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="00000000000094ee55058c2776b0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000094ee55058c2776b0 Content-Type: text/plain; charset="UTF-8" On Tue, Jun 25, 2019 at 1:09 PM Dave Page wrote: > > - What else is missing from this patch to make it applicable ? I would >>> like to produce a release-ready patch if possible. If so, I can continue >>> working on the project on following patches, I just want to know what is >>> the minimum amount of work needed to make this patch release-ready >>> (especially that changes are being made in the master branch that require >>> me to re-edit parts of the code that I have written before to keep things >>> in-sync). >>> >> @Dave Page is the right person to answer this. >> > > It needs: > > - A code complete feature (or infrastructure/refactoring ready for a > feature), that is acceptable to us. Seems like this is 90% there for an > initial commit. > - Documentation updates. > - Tests for the new feature to ensure it works without needing manual > testing. > - To pass all existing tests (which may be modified if appropriate). > > Could you tell me what is missing from this patch (in terms of features - other than tests) to be acceptable? I will start working on the tests once the patch is complete. The patch passes all the existing tests except for 3 feature tests that fail due to a TimeoutException in selenium. I do not know what this is about I hope Aditya will help me with it. Also, do you mean code documentation or documentation for the users? Could you point me towards the related parts? Thanks a lot. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class representative of CMP 2021. https://www.linkedin.com/in/yosrym93/ --00000000000094ee55058c2776b0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Jun 25, 2019 at 1:09 PM Dave = Page <dpage@pgadmin.org> wro= te:

- What else is missing = from this patch to make it applicable ? I would like to produce a release-r= eady patch if possible. If so, I can continue working on the project on fol= lowing patches, I just want to know what is the minimum amount of work need= ed to make this patch release-ready (especially that changes are being made= in the master branch that require me to re-edit parts of the code that I h= ave written before to keep things in-sync).
@Dave = Page is the right person to answer this.=C2=A0

It needs:

- A code co= mplete feature (or infrastructure/refactoring ready for a feature), that is= acceptable to us. Seems like this is 90% there for an initial commit.
- Documentation updates.
- Tests for the new feature to ens= ure it works without needing manual testing.
- To pass all existi= ng tests (which may be modified if appropriate).
=C2=A0

Could you tell me what is missing = from this patch (in terms of features - other than tests) to be acceptable?= I will start working on the tests once the patch is complete. The patch pa= sses all the existing tests except for 3 feature tests that fail due to a T= imeoutException in selenium. I do not know what this is about I hope Aditya= will help me with it.

Also, do you mean code docu= mentation or documentation for the users? Could you point me towards the re= lated parts?

Thanks a lot.


--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo = University (2021).
Class representative= of CMP 2021.
--00000000000094ee55058c2776b0--