Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnzA6-0001cq-JQ for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 Jul 2019 05:41:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hnzA5-0001Le-Ey for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 Jul 2019 05:41:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnzA5-0001LX-6E for pgadmin-hackers@lists.postgresql.org; Thu, 18 Jul 2019 05:41:01 +0000 Received: from mail-yw1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnz9y-0002HN-BZ for pgadmin-hackers@postgresql.org; Thu, 18 Jul 2019 05:41:00 +0000 Received: by mail-yw1-xc2d.google.com with SMTP id x67so10469544ywd.3 for ; Wed, 17 Jul 2019 22:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L+v+8g9pig6BpIaqm0y9Xx5Yvqzjr0nZRsGNCuUE4Ww=; b=TquZE06K2t7L1gDvvHKaQPzpeOOMshoPy2+Y16V+oBIDtmYeBUPWS+wirEi0y9sETa wh4kHpxZm78Cy5k2Ex0DTfh6IfEDZxPGXIr5tJKIY8z50hxzttmjNDMqRUdhMmN50pkV tZ5T9l+bhiJvtuxgG2jpla67JVK520LlwDv10OzN9x7OIs1FXT4GYT/YK9k6xGjbHeiA ZGOA2tWTC0Q5gTC2D2H2XiMtFpJZc8v6lxRIKzrqG7B4W1rOMIcw9LnrJ+1gkcylFd27 /k7vv1aRYE03l4Jbk+n4xLUJryuFwY3vAleNKqWwuG57inufjAMl7VSPm1BJcukU4ibv Putg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L+v+8g9pig6BpIaqm0y9Xx5Yvqzjr0nZRsGNCuUE4Ww=; b=qkACG2a3tc4EFBM+oPCs9fe5Mk0igAci70RjTpsxtAcPQLTxnD8clfPvY8l6BMY1TL QXdwrLC1OAqGxGkrNE62WiDQ6ZCykkTzHOWsq1163JhfSJGvDx+F60mBJpZw7uJiHgfo FPs6t25FOgFqfK34DzB3pADNnv+8YW3wLQmMjNZsAzeP1nzgDEVK8v78WenllLWxqll8 FcpeoZYyIbQw9VbIqqWmhMyKnGp+wUAyEr8NmrYAlRAzmvSTP5H/wqIQWX0xW6ehbJBD Sa5pmk+RrlRNscbIoDIOw4XVf/63Aq4NMdSB2Q1TTanUFG8Xdp0w42isOosjrHEUjYE9 GNRQ== X-Gm-Message-State: APjAAAVpxyf9Bn+1BKyDUXKTVt1+4ddQtnzBR6emLXWzZn0xTpbml5ld 7GCj0JJufhTa8ByGA4NKRpJNYw0QROkNIZmKVoI= X-Google-Smtp-Source: APXvYqx6LEJqgsB6x1zTuDpn23fsGgxFa60vN3f+ciV1mLxJAh/qoTkdIaOe1u9ZN6RY85XgprT8u8oRLis7J36sbSo= X-Received: by 2002:a81:2915:: with SMTP id p21mr28157127ywp.152.1563428452446; Wed, 17 Jul 2019 22:40:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yosry Muhammad Date: Thu, 18 Jul 2019 07:40:40 +0200 Message-ID: Subject: Re: Bug in Database Nodes in the Tree To: Khushboo Vashi Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008a36c3058dee0d9f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008a36c3058dee0d9f Content-Type: text/plain; charset="UTF-8" Hi, On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Yosry, > > On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad > wrote: > >> Hi Khushboo, >> >> There's a minor bug that I noticed a while back that when you right click >> a disconnected database (to drop it for example) it automatically connects >> to the database and expands the node. This behaviour is a little annoying >> to users (me too), I am trying to fix it. >> >> This behavior is by design as we have considered some of the pgAdmin > III behavior. One behavior we can change is that on the selection of the > database node, we can just connect it and not expand it and when we expand > the database node (by arrow icon or double click), we can connect and > expand both. > > We need Dave's approval to change this. > I think this makes more sense. > I looked around the code in the browser module (node.js, database.js, >> menu.js) and I couldn't find a way to modify this behaviour. Is this >> handled internally by jQuery? Is modifying this behaviour feasible? >> >> > I think the problem is that the right click event triggers the left event >> click too. Am I correct? >> >> Basically, the browser tree is generated through the aciTree library, so > when required, the public APIs (provided by aciTree) of the events are > being called. > In this case, on the selection of the database node, the selected event is > used in the database.js file. > > Thanks for the clarification. --0000000000008a36c3058dee0d9f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi <khushboo.vashi@enterprised= b.com> wrote:
Hi Yosry,

On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhamm= ad <yosrym93@gmail.com> wrote:
Hi Khushboo,
There's a minor bug that I noticed a while ba= ck that when you right click a disconnected database (to drop it for exampl= e) it automatically connects to the database and expands the node. This beh= aviour is a little annoying to users (me too), I am trying to fix it.
=

This behavior is by des= ign as we have considered some of the pgAdmin III=C2=A0behavior. One behavi= or we can change is that on the selection of the database node, we can just= connect it and not expand it and when we expand the database node (by arro= w icon or double click), we can connect and expand both.

We need Dave's approval to change this.

I think thi= s makes more sense.


I = looked around the code in the browser module (node.js, database.js, menu.js= ) and I couldn't find a way to modify this behaviour. Is this handled i= nternally by jQuery? Is modifying this behaviour feasible?
=C2=A0
I think the problem is that the right click event triggers the left event= click too. Am I correct?

Basically, the browser tree is generated through the aciTree librar= y, so when required, the public APIs (provided by aciTree) of the events ar= e being called.
In this case, on the selection of the database no= de, the selected event is used in the database.js file.

Thanks f= or the clarification.=C2=A0
--0000000000008a36c3058dee0d9f--