Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpqbi-0001aw-Rm for pgadmin-hackers@arkaria.postgresql.org; Tue, 23 Jul 2019 08:57:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hpqbh-0007YS-K1 for pgadmin-hackers@arkaria.postgresql.org; Tue, 23 Jul 2019 08:57:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpqbh-0007YL-BI for pgadmin-hackers@lists.postgresql.org; Tue, 23 Jul 2019 08:57:13 +0000 Received: from mail-yb1-xb42.google.com ([2607:f8b0:4864:20::b42]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpqbd-0002Ri-7c for pgadmin-hackers@postgresql.org; Tue, 23 Jul 2019 08:57:12 +0000 Received: by mail-yb1-xb42.google.com with SMTP id j199so15912608ybg.5 for ; Tue, 23 Jul 2019 01:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GCLHLlG6uBGw5Czi0eavMG9NcUV4f5dpL5lbO8DoPE0=; b=Q3aYueuWoV21dxDn/AlBAn/LlLgwsGGgVEVyZSSQPB/HqTWwciri5umQjgGFiolAYN qHkYBrEcBiIrFgZ2suQuxBFB9J46Nf26/exlxTa6Q6YSKBCQU3NslHxtoJsjImWxDTL/ Hl4WVIilekrQc+FsGyp2lVA+U/5fogi5Zmi2Zd0h2G2XXgZwFq3ML6+oIb9+yi4HlNqj VHq9bOg4db/m9bZgc/ENiAGkH8uQAnRwqKlPNMWeaOYVaGHvfujZ2i9dtaJ3Gy4p1Quv P78YpmZ9h44ptTwWojLS5ATw94HN3kmwkVVHFfn0X5nAdcbCFiFNSFdPC/ippBeXSGgk rs7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GCLHLlG6uBGw5Czi0eavMG9NcUV4f5dpL5lbO8DoPE0=; b=GTdhVn4eaPn0xg8Be9LeX0jNUYZmbDcwCL3QdrArgWpnKvSb3qndZ4KHkMYwXXLxiw Akf8viL10NYjM8sSGpwiCuupE/31fAO/85Z7ApvZKZAXNBYRE26SGTsIPYkaaYMrHKTo iHcmW4PFhOVN+8AG86E3q340x4EI2+Ldk04MBeoV9ZJiBvgJVmHl3pusxE5GqZ+ei2Gn 7+5sYkr1xNp7MD0dx+ofjzSR/PtSp7nNTN3U0CTw27BBh6fnDkskak9DXnxVcxRSVIFD EcwkFONbaMyz2miDWhYErNJTgER2r1PyIsS/y3kbBBn8a2vfVmi3BnIa8omuAwOTcE3T jHcg== X-Gm-Message-State: APjAAAUaWXEOzx9uygESUvclfAUha31qVWg3hZWatIgM2UvzOZ10qhA3 xa7l1dYrGVKjJQebVendAgwM0h9IW2I2hpvcjUU= X-Google-Smtp-Source: APXvYqyP71JaeY5PqUQiHn0eN0i2fnGK8zEAFl4BheLWZFqHUGU17G5lqJr9n1MpjIMpC0LFRZ2j4u9Nk3P7J284fK8= X-Received: by 2002:a25:5b86:: with SMTP id p128mr41930053ybb.32.1563872226052; Tue, 23 Jul 2019 01:57:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yosry Muhammad Date: Tue, 23 Jul 2019 10:56:54 +0200 Message-ID: Subject: Re: Bug in Database Nodes in the Tree To: Dave Page Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000820d29058e556008" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000820d29058e556008 Content-Type: text/plain; charset="UTF-8" Thanks for making things clear. On Tue, Jul 23, 2019, 10:01 AM Dave Page wrote: > > > On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad >> wrote: >> >>> Hi, >>> >>> I tried just removing the lines responsible for connecting to the >>> database on selecting a database node and it seem to work fine. >>> Specifically the lines 254-257 in database.js (callbacks.selected function). >>> >>> Are there any specific scenarios I need to test to make sure everything >>> is okay? Anywhere else in the code where I need to make changes? >>> >>> I think all the right side panels (i.e. Properties, SQL, etc...) will be >> affected. >> > > They're populated on select. It may mean that we have to show a "Please > connect to the server" message in them, if a database or server is selected > but not connected. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000820d29058e556008 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for making things clear.

On Tue, Jul 23, 2019, 10:0= 1 AM Dave Page <dpage@pgadmin.org> wrote:



=

= On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <yosrym93@gmail.com&g= t; wrote:
Hi,

I tried just removing the line= s responsible for connecting to the database on selecting a database node a= nd it seem to work fine. Specifically the lines 254-257 in database.js (cal= lbacks.selected function).

Are there any specific = scenarios I need to test to make sure everything is okay? Anywhere else in = the code where I need to make changes?

I think all the right side panels (i.e. Properties, SQL, etc...) will be a= ffected.=C2=A0

They'r= e populated on select. It may mean that we have to show a "Please conn= ect to the server" message in them, if a database or server is selecte= d but not connected.
=C2=A0
--
Dave Page
Blog: http://p= gsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div> --000000000000820d29058e556008--