MIME-Version: 1.0
References: 
 <CAFSMqn8yLA329GFHSm0Bn4cEqvd+kVoYpCAB5mRDbVF6NNaxxA@mail.gmail.com>
 <CAFSMqn8fjFT8CbhB5FAtkN8cd7QH0+XYtSUZmD5J1F38n1189g@mail.gmail.com>
 <CA+OCxoz=50F2N6+7dGrarieXNaXiiJw-deSAXd6fSH7SvEaQXw@mail.gmail.com>
 <CAFSMqn9HaapnutknGQdG2h0-xyk9qCcGB_wxkPM5iwiHp=fPpg@mail.gmail.com>
 <CA+OCxox43r3qH9YNt_gT7TT3s+DkROvf1pvvAKzg663xHzT5VQ@mail.gmail.com>
 <CAFOhELeFLVLS_RDTJPH0cLDRP8PUxFfxL05YXcL0+r1addP8dg@mail.gmail.com>
 <CAFOhELerRJ3WLau4rXVHvCC=YO9nEpp8qtX+f0tbq0rTqLO5uw@mail.gmail.com>
In-Reply-To: 
 <CAFOhELerRJ3WLau4rXVHvCC=YO9nEpp8qtX+f0tbq0rTqLO5uw@mail.gmail.com>
From: Yosry Muhammad <yosrym93@gmail.com>
Date: Wed, 10 Jul 2019 11:41:13 +0200
Message-ID: 
 <CAFSMqn_gEi1JyeHdeFqWKtjg9w4T8p7Edi8iKPEtX1_qZjo0Fg@mail.gmail.com>
Subject: Re: [GSoC] Finalized First Patch
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: Dave Page <dpage@pgadmin.org>, pgadmin-hackers@postgresql.org,
	Akshay Joshi <akshay.joshi@enterprisedb.com>
Content-Type: multipart/alternative; boundary="00000000000012d3e3058d507ba0"
Precedence: bulk

--00000000000012d3e3058d507ba0
Content-Type: text/plain; charset="UTF-8"

Hi,

On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Some points I missed:
> 1.  I assumed that in this patch modification in case of OIDs= True
> (without primary key) has not considered as that is not working.
>

This is not implemented yet. I will work on that in a following patch soon
enough.

2. As we are already showing the changed Data prompt on closing the Query
> Tool, do we really need the Uncommitted Transaction prompt?
>

This is needed when auto-commit is off. Saving changes in the data grid is
performed as part of the ongoing transaction (or a new one if none is
ongoing). After saving the data changes the user should still commit the
current transaction for the changes to be commited to the database. This
feature is also useful in general when auto-commit is off as users may
forget to commit ongoing transactions.

Thanks and Regards :D

--00000000000012d3e3058d507ba0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi,<br><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi &lt;<a=
 href=3D"mailto:khushboo.vashi@enterprisedb.com">khushboo.vashi@enterprised=
b.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"lt=
r">Some points I missed:<div>1.=C2=A0 I assumed that in this patch modifica=
tion in case of OIDs=3D True (without primary key) has not considered as th=
at is not working.</div></div></blockquote></div></div><div dir=3D"auto"><b=
r></div><div dir=3D"auto">This is not implemented yet. I will work on that =
in a following patch soon enough.</div><div dir=3D"auto"><br></div><div dir=
=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div di=
r=3D"ltr"><div>2. As we are already showing the changed Data prompt on clos=
ing the Query Tool, do we really need the Uncommitted Transaction prompt?=
=C2=A0</div></div></blockquote></div></div><div dir=3D"auto"><br></div><div=
 dir=3D"auto">This is needed when auto-commit is off. Saving changes in the=
 data grid is performed as part of the ongoing transaction (or a new one if=
 none is ongoing). After saving the data changes the user should still comm=
it the current transaction for the changes to be commited to the database. =
This feature is also useful in general when auto-commit is off as users may=
 forget to commit ongoing transactions.</div><div dir=3D"auto"><br></div><d=
iv dir=3D"auto">Thanks=C2=A0and Regards :D</div></div>

--00000000000012d3e3058d507ba0--