public inbox for [email protected]  

help / color / mirror / Atom feed

Minor issues
3+ messages / 2 participants
[nested] [flat]

* Minor issues
@ 2016-04-29 06:22 Harshal Dhumal <[email protected]>
  2016-04-29 06:30 ` Re: Minor issues Harshal Dhumal <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Harshal Dhumal @ 2016-04-29 06:22 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

PFA patch for minor issues.

Issues fixed:

1] Removed unwanted "{% if  %}" from database 9.1 nodes.sql
2] Fixed issue while removing select2cell fro backgrid.




-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB <http://www.enterprisedb.com;


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] minor_issues_29_April.patch (1.4K, 3-minor_issues_29_April.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.1_plus/nodes.sql b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.1_plus/nodes.sql
index 3ce9645..b05880c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.1_plus/nodes.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.1_plus/nodes.sql
@@ -3,7 +3,7 @@ SELECT
     has_database_privilege(db.oid, 'CREATE') as cancreate, datdba as owner
 FROM
     pg_database db
-    LEFT OUTER JOIN pg_tablespace ta ON db.dattablespace = ta.oid{% if did %}
+    LEFT OUTER JOIN pg_tablespace ta ON db.dattablespace = ta.oid
 WHERE {% if did %}
 db.oid = {{ did|qtLiteral }}::OID{% else %}
 db.oid > {{ last_system_oid }}::OID
diff --git a/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js
index 999ac7c..5311a01 100644
--- a/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js
@@ -530,7 +530,9 @@
 
     remove: function() {
       this.$select.off('change', this.onSave);
-      this.$select.select2('destroy');
+      if (this.$select.data('select2')) {
+        this.$select.select2('destroy');
+      }
       this.$el.empty();
       Backgrid.SelectCell.prototype.remove.apply(this, arguments);
      }


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Minor issues
  2016-04-29 06:22 Minor issues Harshal Dhumal <[email protected]>
@ 2016-04-29 06:30 ` Harshal Dhumal <[email protected]>
  2016-04-29 10:23   ` Re: Minor issues Ashesh Vashi <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Harshal Dhumal @ 2016-04-29 06:30 UTC (permalink / raw)
  To: pgadmin-hackers

-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB <http://www.enterprisedb.com;

On Fri, Apr 29, 2016 at 11:52 AM, Harshal Dhumal <
[email protected]> wrote:

> Hi,
>
> PFA patch for minor issues.
>
> Issues fixed:
>
> 1] Removed unwanted "{% if  %}" from database 9.1 nodes.sql
> 2] Fixed issue while removing select2cell fro backgrid.
>

Regarding select2 cell; Even though we have created select2 cell sometimes
we do not get select2 instance when we retrieve it from dom. So we have to
manually check it's data attribute before calling it's destroy method.


>
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com;
>


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Minor issues
  2016-04-29 06:22 Minor issues Harshal Dhumal <[email protected]>
  2016-04-29 06:30 ` Re: Minor issues Harshal Dhumal <[email protected]>
@ 2016-04-29 10:23   ` Ashesh Vashi <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Ashesh Vashi @ 2016-04-29 10:23 UTC (permalink / raw)
  To: Harshal Dhumal <[email protected]>; +Cc: pgadmin-hackers

Thanks - committed along with some other change!!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;

On Fri, Apr 29, 2016 at 12:00 PM, Harshal Dhumal <
[email protected]> wrote:

>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com;
>
> On Fri, Apr 29, 2016 at 11:52 AM, Harshal Dhumal <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA patch for minor issues.
>>
>> Issues fixed:
>>
>> 1] Removed unwanted "{% if  %}" from database 9.1 nodes.sql
>> 2] Fixed issue while removing select2cell fro backgrid.
>>
>
> Regarding select2 cell; Even though we have created select2 cell sometimes
> we do not get select2 instance when we retrieve it from dom. So we have to
> manually check it's data attribute before calling it's destroy method.
>
>
>>
>>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com;
>>
>
>


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2016-04-29 10:23 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-04-29 06:22 Minor issues Harshal Dhumal <[email protected]>
2016-04-29 06:30 ` Harshal Dhumal <[email protected]>
2016-04-29 10:23   ` Ashesh Vashi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox