Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNIc7-0000Q5-VD for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 11:46:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNIc7-00062Y-IV for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 11:46:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNIbu-0005oh-G0 for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 11:45:50 +0000 Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNIbq-0005ur-7O for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 11:45:50 +0000 Received: by mail-oi0-x234.google.com with SMTP id j185so59431191oih.0 for ; Wed, 13 Jul 2016 04:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8/qxTZFVl/oruWCmbOIk19ygYvD8wkM/eDrknnfCpx0=; b=Fr4rcEaGg/HxzGaD3P4L3C+U7+MqHeqnagSvXn4a4Ys13kIojR4Mwpj5/d3aZYX2dU do5V23cb+5d9kxIRYqva9TupRo1+mvolu5FvPTxS7OJn4xPlXnsD8x15OR/dPKT/N6lf 1BWDRbB/ZAs0CC/RpA1JKYuvG46oiGUDMk+Exzn/IDX2O3jjFnMn4am2PlAq8xeA3NMy CCP3fA311nVNGnsDtK7UiV4nrUsnWBm5+hpDw9GXgcFDWV539g5BQa8vaK14dfh1RgaH DTKcMzrEDZX1ECuUq+z2WngONnTzuwI5lEMpwBmkDB7tyhkCiR9d1ULxxwSgD6pmkcRt FrHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8/qxTZFVl/oruWCmbOIk19ygYvD8wkM/eDrknnfCpx0=; b=lESYxt99ZDw6Pbgae9w53egwMz2cRnqstHp2OAPa4K/fPlNYwTK1GGjFXZFP5vDzZl KtyNXGpog9cz4cYjDDwy1CtjYGIgN5/P3YKjLvParlrKWBFZ5gd0d8NSqUTaFxuARmo+ ldlRXBwPW5LtwgXFMiR1e6dyZyGo/8wSCz4cxdLOP4Tri31IkpEcE9A//Ao2L0ijz67d Gc9YdJDpGJ2NAvHgB5D6sXL7YRMk9Xuo0uwfvUuzREAt7tu80sLQ0/pw74iwOc2/9pgQ //A8LnXJJnEywsc7wqfyL9fjQZmJjJdr55c27B7Lz/5XR7d8/0qbdfawpzJIlO0ZXo8W jnQw== X-Gm-Message-State: ALyK8tK6KFkfh5T2XhelHyPOs12590pq3BYrth3XV0YmtZ9s91eJL0lD5NncPxMOYLXfharWTnDfutStmMq0djvi X-Received: by 10.157.36.70 with SMTP id p64mr4572358ota.172.1468410344241; Wed, 13 Jul 2016 04:45:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.99 with HTTP; Wed, 13 Jul 2016 04:45:43 -0700 (PDT) In-Reply-To: References: <70470862-26C1-4281-838E-F2C755E5C645@enterprisedb.com> <671D8CC8-C1D8-4CC1-BC32-431C496C4C5C@enterprisedb.com> From: Harshal Dhumal Date: Wed, 13 Jul 2016 17:15:43 +0530 Message-ID: Subject: Re: PATCH: Fix the issue for saving query output as CSV To: Dave Page Cc: Akshay Joshi , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113d1a26f4102a053782ecc5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113d1a26f4102a053782ecc5 Content-Type: text/plain; charset=UTF-8 Yes sure -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:10 PM, Dave Page wrote: > Hi > > Can you rebase this please? > > Thanks. > > On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch for RM1405. Also to allow download in runtime we will still >> need patch >> >> sent by Neel. >> >> Changes: To download query result to CSV directly from server and not to >> use download attr. of anchor tag () as it's not support by all of major >> browsers (e.g. Safari). >> Also it's not feasible to load data in html to download if result set of >> query is very huge (in GBs). >> >> >> >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala >> enterprisedb.com> wrote: >>> >>>> Yes, It will not work in runtime as well but I think Neel is working >>>> for fix in run time for this issue, We might able to fix it in run time but >>>> issue persists in Safari unless they add support in browser itself. >>>> >>>> https://webkit.org/status/#feature-download-attribute >>>> >>>> >>>> > On 29-Jun-2016, at 3:40 pm, Dave Page wrote: >>>> > >>>> > On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala >>>> > wrote: >>>> >> Yes Dave, I agree that downloading files has been supported in >>>> browsers since long . >>>> >> >>>> >> But in general we send request & then receives files from web server >>>> but in our case we are fetching our data from Backbone models & then >>>> converting it to CSV format for downloading as a file at client side in >>>> browser itself. >>>> > >>>> > If Safari doesn't support client-side saving of files, then I have to >>>> > wonder if our runtime will either - both are webkit based. >>>> > >>>> > So I guess the next question to ask is; why don't we just generate the >>>> > CSV on the server side? >>>> > >>>> >>>> @Akshay, >>>> Can you please suggest on above? >>>> >>> >>> As we already have complete data in backgrid's full collection, so I >>> have used it instead of fetching it again. >>> >>>> >>>> > -- >>>> > Dave Page >>>> > Blog: http://pgsnake.blogspot.com >>>> > Twitter: @pgsnake >>>> > >>>> > EnterpriseDB UK: http://www.enterprisedb.com >>>> > The Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246* >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113d1a26f4102a053782ecc5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Yes sure
On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, = 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb= .com> wrote:
Hi,

PFA patch for RM1405. Also to allow download = in runtime we will still need patch sent by Neel.

Changes: To = download query result to CSV directly from server and not to use download a= ttr. of anchor tag (<a>) as it's not support by all of major brow= sers (e.g. Safari).
Also it's not feasible to load data in html to d= ownload if result set of query is very huge (in GBs).





--=C2=A0
Harshal Dhumal
Software Engine= er

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
= The Enterprise PostgreSQL Company
<= /div>

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Josh= i <akshay.joshi@enterprisedb.com> wrote:

=
On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Yes, It will not work in runtime as w= ell but I think Neel is working for fix in run time for this issue, We migh= t able to fix it in run time but issue persists in Safari unless they add s= upport in browser itself.

https://webkit.org/status/#feature-download-att= ribute


> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in bro= wsers since long .
>>
>> But in general we send request & then receives files from web = server but in our case we are fetching our data from Backbone models & = then converting it to CSV format for downloading as a file at client side i= n browser itself.
>
> If Safari doesn't support client-side saving of files, then I have= to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate= the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

=C2=A0 =C2=A0As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again. =C2=A0 = =C2=A0

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--
Akshay Joshi
Principal Software Enginee= r=C2=A0

=

+91 20-3058-9517
Mobile: +91 976-788-8246




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--001a113d1a26f4102a053782ecc5--