Re: [PATCH] Tables node (pgAdmin4)

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Harshal Dhumal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: [PATCH] Tables node (pgAdmin4)
Date: Sat, 14 May 2016 02:03:42 +0530
Message-ID: <CAFiP3vw5nx2Wdt9ci-MNRV+H+dO-x9KUSZtk16EZKjdox+KRxg@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELd=_vuqwR0eGLL=KhxGaQCP6n9mcXP1GijcWh1ecCpegw@mail.gmail.com>
References: <CAKKotZRCf07F_SGHi4KawBtLHPSeKz5Uvzwu6ddQ=bKc1FDRRw@mail.gmail.com>
	<CAFiP3vw61T0n--F4vYXALdtrkBKznBegBPq5Ds=6uZrg02vWXQ@mail.gmail.com>
	<CAFOhELea6nCtX_T78o_3mNKJC0_emirXKGm3nq8d6mvSZV57pg@mail.gmail.com>
	<CAFiP3vypf7KEmToKsBqn1--qf_PzMV+p-d9bsMj04eoYnj5_tQ@mail.gmail.com>
	<CAKKotZQumWW_cvhvgyFc7_1Lvs8npkPW57FgVN_+wPPSurBDOw@mail.gmail.com>
	<CAKKotZQMR5zsbDAiAhUEQ46yhNE51BONu0DYjEY1WFSJbBqK+w@mail.gmail.com>
	<CAFiP3vwBUX5Ez51Fk_s+t67hRW-uZ6ViMcuTg4e+oPf+k5KqTg@mail.gmail.com>
	<CAFOhELdg9-TB=fdpGDLNkjYve9vBxYttE_PzmahsrNMQv4nn4Q@mail.gmail.com>
	<CAFiP3vxO9tej3WXYeLjZk6MgQYR0C-hp9UUWmog1E7iDvvqFmQ@mail.gmail.com>
	<CAFOhELd=_vuqwR0eGLL=KhxGaQCP6n9mcXP1GijcWh1ecCpegw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,


PFA updated patches (version: 6) for table and it's child nodes.

-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB <http://www.enterprisedb.com;

On Fri, May 13, 2016 at 6:55 PM, Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Review Comments:
>
> - Please replace 'can not' with 'cannot'  in all the validation messages.
> - PG 9.1+ Inheritance issue as below:
>
> CREATE TABLE public.table1
> (
> )
> (
> )
>     INHERITS (a)
> WITH (
>     OIDS = FALSE
> )
> TABLESPACE pg_default;
> ALTER TABLE public.table1
>     OWNER to postgres;
>
>
> brackets are coming twice.
>
Fixed


>
> - Please maintain one line spacing between SQL queries In the SQL Tab.
>
TODO


> - Foreign Key Grid in Table css issue: Grid columns expands on the
> selection of the cell
>
Fixed


> - Check Constraint: Validated? option should be True by default
>
Not sure about this. I cross checked in pgadmin3.



> - pg 9.4: Exclude constraint does not render in SQL tab
>
Fixed


> - Missing Security validation
>
Fixed


> - Vacuum grid should not be editable in properties mode.
>
TODO (It's editable but one cannot save it on server from here as there is
no save button.)


> - Edit mode, Fill Factor can be allowed to be null.
>
TODO (This is generic issue in Integer and Numeric controls. This issue is
covered in this partial patch
<http://www.postgresql.org/message-id/[email protected]....;
)


> - While dropping inheritance, related table columns drop SQL are also
> populated in the SQL Tab
>
> ALTER TABLE public."Tbl"
>     NO INHERIT b;
> ALTER TABLE public."Tbl" DROP COLUMN id;
> ALTER TABLE public."Tbl" DROP COLUMN name;
>
>
Fixed



>
> And also render error while clicking on the save button.
>
> ERROR: syntax error at or near "["
> LINE 2: INHERIT [;
>
> ^
>
> Fixed


> - in a Reverse Engineering SQL tab, schema_name.tablename should be there,
> currently only table_name displays.
>
Fixed



> - Column SQL is showing below text with HTML
>
>
> <html><head></head><body>-- Column: id -- ALTER TABLE public.a DROIP
> COLUMN id; ALTER TABLE public.a ADD COLUMN id integer;</body></html>
>
>
I was not able to reproduce exact issue but still I have fixed other issue
which I found related to column SQL. Hopefully that will fix this issue as
well.


> - The column datatype dependency does not get cleared upon selection of
> another datatype.
>
 For example, if I select numeric and gives the length and precision. After
> that I change the dat-type then, dependent fields should be get cleared.
>
Fixed.


>
> - The column datatype does not get displayed in the properties and edit
> mode if the length and precision are given while creating a column.
>

TODO ( I cannot fix this blindly as this might introduce another issue(s)
in column node. I will need Murtuza's help as he has worked on column node)


>
> - Statistics is showing null value even after having value.
>
Fixed


>
> - if the check constraints are not validated then put proper icon in tree
> and also it should be validated in edit mode.
>
Not reproducible.


>
> NOTE: I have not checked the Indexes, Triggers and Rules nodes as I do not
> have much knowledge about it.
>
>


> Thanks,
> Khushboo
>
> On Fri, May 13, 2016 at 5:24 PM, Harshal Dhumal <
> [email protected]> wrote:
>
>> Hi
>>
>> PFA attached patches for table and it's child nodes with python 2.7
>> compatibility.
>>
>>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/zip] table_14_May_V6.patch.zip (84.0K, 3-table_14_May_V6.patch.zip)
  download

  [application/zip] index_constraint_14_May_V6.patch.zip (13.1K, 4-index_constraint_14_May_V6.patch.zip)
  download

  [application/zip] foreign_key_14_May_V6.patch.zip (16.1K, 5-foreign_key_14_May_V6.patch.zip)
  download

  [application/zip] check_constraint_14_May_V6.patch.zip (9.4K, 6-check_constraint_14_May_V6.patch.zip)
  download

  [application/zip] exclusion_constraint_14_May_V6.patch.zip (14.5K, 7-exclusion_constraint_14_May_V6.patch.zip)
  download

view thread (49+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH] Tables node (pgAdmin4)
  In-Reply-To: <CAFiP3vw5nx2Wdt9ci-MNRV+H+dO-x9KUSZtk16EZKjdox+KRxg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox