Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL30g-0008PK-KC for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 06:42:06 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bL30f-00072G-V9 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 06:42:06 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bL30e-00071n-Q2 for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 06:42:05 +0000 Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bL30b-0001w8-S2 for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 06:42:03 +0000 Received: by mail-oi0-x229.google.com with SMTP id f189so11468343oig.3 for ; Wed, 06 Jul 2016 23:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Q3EC1UqSw7yDSstBJJO+8GlSf3fR0BpYYmHJ8i6lrEQ=; b=hjYSxhs+z7nYaHBVrRh+0zW+kTDKCtQKECpdeAtxYuaa+MoxK3zhqzmK/VJufgNLfP 3unSWSU1q9CG1JxrDNjn40YLIHZvByt/ldva7vC2T2ubzTTy6PtqVL2TORvG5rxSazwG NAjVqFeTfcTI5nYyh22tP0twAtcWx3q76SWuxv1rj+uAT48wIbG+u6lBhdybANC0toUh LmJBzYcX/uYspQ9A9ghkFtcRiv+cLVlOWWCojWyqzHTsQTp/5OscC1LDQCID0qFzWPzJ EEg4BU8UzbiwsDsfsoQqGjVYvkN7M3w7lI50l+j1zTDwwuQ7tLkkPvND8iasCv7L3akr Q13w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Q3EC1UqSw7yDSstBJJO+8GlSf3fR0BpYYmHJ8i6lrEQ=; b=aZ3qwlNHYnndsYArqBi1oIXoqmZNFaqp1fG0hx2t9eTZooEyLKVvG+5EnyRFIhQvBN PWIuwktq07+uNoJZFbYzeN1D8UtUtM+m+ImcryZxXQ/ngr4sbiNY9TDQ1YbBduUEleHh 9elJXZQ0riiEJ06M7Capz6qxpGvZAut1vgu0WbESrb+WDV2GA21yxV6LaZfcMGNT9TRN EZ6qASWsgmUixzxadAK4RpdOiubx43Sq3zpmYhu60+PKwzuZxZQnNv5JucnipylP3l4d yGICerYIZ0TPz8Pj8Ui6l2CR6HZrzT5RZOzpHNzcxH25V7MsQHwvwYIIVxHZ5Swi5S36 u37A== X-Gm-Message-State: ALyK8tIE/Pe42/vjS2M2FJPJ4UlNxtg6ei4jqXjiEJgIjaNa1N8CEvQ1zQj+H/C0PKaQ50ldI4ksz9p5D4xUe/xz X-Received: by 10.202.84.70 with SMTP id i67mr13178419oib.188.1467873720750; Wed, 06 Jul 2016 23:42:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.100 with HTTP; Wed, 6 Jul 2016 23:42:00 -0700 (PDT) In-Reply-To: References: From: Harshal Dhumal Date: Thu, 7 Jul 2016 12:12:00 +0530 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113b0b90b39c63053705fbd0 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113b0b90b39c63053705fbd0 Content-Type: multipart/alternative; boundary=001a113b0b90b39c5e053705fbce --001a113b0b90b39c5e053705fbce Content-Type: text/plain; charset=UTF-8 Hi, PFA updated patch for issue RM1260 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > Please ignore this patch as this has some minor issue. I'll sent updated > one. > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch for issue RM1260. >> >> Changes: Issue wasn't related to foreign table but was due the Select2 >> control. Now I have improved select2 control to handle null value in >> multi-select mode. Initial it was returning "null" instead it should return >> [] (empty array). >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a113b0b90b39c5e053705fbce Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA updated patch for issue RM1260

--=C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhu= mal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Please ignore thi= s patch as this has some minor issue. I'll sent updated one.

--=C2=A0
Harshal Dhumal
Softwa= re Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6,= 2016 at 5:30 PM, Harshal Dhumal <harshal.dhumal@enterprised= b.com> wrote:
Hi,

PFA patch for issue RM1260.

Cha= nges: Issue wasn't related to foreign table but was due the Select2 con= trol. Now I have improved select2 control to handle null value in multi-sel= ect mode. Initial it was returning "null" instead it should retur= n [] (empty array).


--=C2=A0
Harshal Dhu= mal
Software Engineer



--001a113b0b90b39c5e053705fbce-- --001a113b0b90b39c63053705fbd0 Content-Type: text/x-patch; charset=US-ASCII; name="RM1260_V2.patch" Content-Disposition: attachment; filename="RM1260_V2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqby3l7h0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL2ZvcmVpZ25fdGFibGVzL3Rl bXBsYXRlcy9mb3JlaWduX3RhYmxlcy9qcy9mb3JlaWduX3RhYmxlcy5qcyBi L3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL2ZvcmVpZ25fdGFibGVzL3RlbXBsYXRlcy9mb3Jl aWduX3RhYmxlcy9qcy9mb3JlaWduX3RhYmxlcy5qcwppbmRleCBhNGI1YTI3 Li4zYWY2YzYxIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3Nl cnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9mb3JlaWdu X3RhYmxlcy90ZW1wbGF0ZXMvZm9yZWlnbl90YWJsZXMvanMvZm9yZWlnbl90 YWJsZXMuanMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3Jv dXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvZm9yZWlnbl90YWJsZXMv dGVtcGxhdGVzL2ZvcmVpZ25fdGFibGVzL2pzL2ZvcmVpZ25fdGFibGVzLmpz CkBAIC0yNjYsMTIgKzI2Niw2IEBAIGZ1bmN0aW9uKCQsIF8sIFMsIHBnQWRt aW4sIHBnQnJvd3NlciwgYWxlcnRpZnkpIHsKICAgKi8KIAogICB2YXIgTm9k ZUFqYXhPcHRpb25zTXVsdGlwbGVDb250cm9sID0gQmFja2Zvcm0uTm9kZUFq YXhPcHRpb25zTXVsdGlwbGVDb250cm9sID0gQmFja2Zvcm0uTm9kZUFqYXhP cHRpb25zQ29udHJvbC5leHRlbmQoewotICAgIHRlbXBsYXRlOiBfLnRlbXBs YXRlKFsKLSAgICAgICc8bGFiZWwgY2xhc3M9IjwlPUJhY2tmb3JtLmNvbnRy b2xMYWJlbENsYXNzTmFtZSU+Ij48JT1sYWJlbCU+PC9sYWJlbD4nLAotICAg ICAgJzxkaXYgY2xhc3M9IjwlPUJhY2tmb3JtLmNvbnRyb2xzQ2xhc3NOYW1l JT4gPCU9ZXh0cmFDbGFzc2VzLmpvaW4oXCcgXCcpJT4iPicsCi0gICAgICAn ICA8c2VsZWN0IGNsYXNzPSJwZ2FkbWluLW5vZGUtc2VsZWN0IGZvcm0tY29u dHJvbCIgbmFtZT0iPCU9bmFtZSU+IiBzdHlsZT0id2lkdGg6MTAwJTsiIHZh bHVlPTwlLXZhbHVlJT4gPCU9ZGlzYWJsZWQgPyAiZGlzYWJsZWQiIDogIiIl PiA8JT1yZXF1aXJlZCA/ICJyZXF1aXJlZCIgOiAiIiU+ID4nLAotICAgICAg JyAgPC9zZWxlY3Q+JywKLSAgICAgICc8L2Rpdj4nXS5qb2luKCJcbiIpKSwK ICAgICBkZWZhdWx0czogXy5leHRlbmQoCiAgICAgICB7fSwgQmFja2Zvcm0u Tm9kZUFqYXhPcHRpb25zQ29udHJvbC5wcm90b3R5cGUuZGVmYXVsdHMsCiAg ICAgICB7CkBAIC0zMzUsNyArMzI5LDcgQEAgZnVuY3Rpb24oJCwgXywgUywg cGdBZG1pbiwgcGdCcm93c2VyLCBhbGVydGlmeSkgewogICAgICAgICAgIHsK ICAgICAgICAgICAgICdkYXRhJzogZGF0YS5vcHRpb25zCiAgICAgICAgICAg fSk7Ci0gICAgICAgIHRoaXMuJGVsLmZpbmQoInNlbGVjdCIpLnNlbGVjdDIo b3B0cykudmFsKGRhdGEucmF3VmFsdWUpLnRyaWdnZXIoImNoYW5nZSIpOwor ICAgICAgICB0aGlzLiRlbC5maW5kKCJzZWxlY3QiKS5zZWxlY3QyKG9wdHMp OwogICAgICAgICB0aGlzLnVwZGF0ZUludmFsaWQoKTsKICAgICAgICAgfQog ICAgICAgfQpAQCAtMzcwLDcgKzM2NCw3IEBAIGZ1bmN0aW9uKCQsIF8sIFMs IHBnQWRtaW4sIHBnQnJvd3NlciwgYWxlcnRpZnkpIHsKIAogICAgICAgLy8g UmVtb3ZlIENvbHVtbnMgaWYgaW5oZXJpdCBvcHRpb24gaXMgZGVzZWxlY3Rl ZCBmcm9tIHRoZSBjb21ib2JveAogICAgICAgaWYoXy5zaXplKHZhbHVlKSA8 IF8uc2l6ZShpbmhlcml0cykpIHsKLSAgICAgICAgdmFyIGRpZiA9ICBfLmRp ZmZlcmVuY2UoaW5oZXJpdHMsIEpTT04ucGFyc2UodmFsdWUpKTsKKyAgICAg ICAgdmFyIGRpZiA9ICBfLmRpZmZlcmVuY2UoaW5oZXJpdHMsIHZhbHVlKTsK ICAgICAgICAgdmFyIHJtdl9jb2x1bW5zID0gY29sdW1ucy53aGVyZSh7aW5o ZXJpdGVkaWQ6IHBhcnNlSW50KGRpZlswXSl9KTsKICAgICAgICAgY29sdW1u cy5yZW1vdmUocm12X2NvbHVtbnMpOwogICAgICAgfQpkaWZmIC0tZ2l0IGEv d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0 YWJhc2VzL3NjaGVtYXMvZm9yZWlnbl90YWJsZXMvdGVtcGxhdGVzL2ZvcmVp Z25fdGFibGVzL3NxbC85LjVfcGx1cy9nZXRfdGFibGVzLnNxbCBiL3dlYi9w Z2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNl cy9zY2hlbWFzL2ZvcmVpZ25fdGFibGVzL3RlbXBsYXRlcy9mb3JlaWduX3Rh Ymxlcy9zcWwvOS41X3BsdXMvZ2V0X3RhYmxlcy5zcWwKaW5kZXggODM0NDVh Mi4uMWJiNTAxZSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvZm9yZWln bl90YWJsZXMvdGVtcGxhdGVzL2ZvcmVpZ25fdGFibGVzL3NxbC85LjVfcGx1 cy9nZXRfdGFibGVzLnNxbAorKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3Nl cnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9mb3JlaWdu X3RhYmxlcy90ZW1wbGF0ZXMvZm9yZWlnbl90YWJsZXMvc3FsLzkuNV9wbHVz L2dldF90YWJsZXMuc3FsCkBAIC05LDcgKzksNyBAQCBXSEVSRQogCiB7JSBl bHNlICV9CiBTRUxFQ1QKLSAgICBjLm9pZCBBUyBpZCwgcXVvdGVfaWRlbnQo bi5uc3BuYW1lKSB8fCAnLicgfHwgcXVvdGVfaWRlbnQoYy5yZWxuYW1lKSBh cyB0ZXh0CisgICAgYy5vaWQgQVMgdmFsdWUsIHF1b3RlX2lkZW50KG4ubnNw bmFtZSkgfHwgJy4nIHx8IHF1b3RlX2lkZW50KGMucmVsbmFtZSkgYXMgbGFi ZWwKIEZST00KICAgICBwZ19jbGFzcyBjLCBwZ19uYW1lc3BhY2UgbgogV0hF UkUKQEAgLTE5LDQgKzE5LDQgQEAgV0hFUkUKIHslIGVuZGlmICV9CiBPUkRF UiBCWQogICAgIG4ubnNwbmFtZSwgYy5yZWxuYW1lOwoteyUgZW5kaWYgJX0K K3slIGVuZGlmICV9ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZm IC0tZ2l0IGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRt aW4uanMgYi93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYmFja2Zvcm0ucGdhZG1p bi5qcwppbmRleCA5NzNiNjBiLi5mYjZjNTFmIDEwMDY0NAotLS0gYS93ZWIv cGdhZG1pbi9zdGF0aWMvanMvYmFja2Zvcm0ucGdhZG1pbi5qcworKysgYi93 ZWIvcGdhZG1pbi9zdGF0aWMvanMvYmFja2Zvcm0ucGdhZG1pbi5qcwpAQCAt MTc5Myw3ICsxNzkzLDExIEBACiAgICAgICBpZiAoXy5pc0FycmF5KGZvcm1h dHRlZERhdGEpKSB7CiAgICAgICAgIHJldHVybiBfLm1hcChmb3JtYXR0ZWRE YXRhLCBkZWNvZGVVUklDb21wb25lbnQpOwogICAgICAgfSBlbHNlIHsKLSAg ICAgICAgcmV0dXJuIGRlY29kZVVSSUNvbXBvbmVudChmb3JtYXR0ZWREYXRh KTsKKyAgICAgICAgaWYoIV8uaXNOdWxsKGZvcm1hdHRlZERhdGEpICYmICFf LmlzVW5kZWZpbmVkKGZvcm1hdHRlZERhdGEpKSB7CisgICAgICAgICAgcmV0 dXJuIGRlY29kZVVSSUNvbXBvbmVudChmb3JtYXR0ZWREYXRhKTsKKyAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICByZXR1cm4gbnVsbDsKKyAgICAgICAg fQogICAgICAgfQogICAgIH0KICAgfSk7CkBAIC0xOTA0LDkgKzE5MDgsMTUg QEAKICAgICAgIHJldHVybiB0aGlzOwogICAgIH0sCiAgICAgZ2V0VmFsdWVG cm9tRE9NOiBmdW5jdGlvbigpIHsKLSAgICAgIHJldHVybiBCYWNrZm9ybS5T ZWxlY3RDb250cm9sLnByb3RvdHlwZS5nZXRWYWx1ZUZyb21ET00uYXBwbHko Ci0gICAgICAgIHRoaXMsIGFyZ3VtZW50cwotICAgICAgKTsKKyAgICAgIHZh ciB2YWwgPSBCYWNrZm9ybS5TZWxlY3RDb250cm9sLnByb3RvdHlwZS5nZXRW YWx1ZUZyb21ET00uYXBwbHkoCisgICAgICAgICAgICAgICAgICB0aGlzLCBh cmd1bWVudHMKKyAgICAgICAgICAgICAgICApLAorICAgICAgICBzZWxlY3Qy T3B0cyA9IF8uZXh0ZW5kKHt9LCB0aGlzLmZpZWxkLmdldCgic2VsZWN0MiIp IHx8IHRoaXMuZGVmYXVsdHMuc2VsZWN0Mik7CisKKyAgICAgIGlmIChzZWxl Y3QyT3B0cy5tdWx0aXBsZSAmJiB2YWwgPT0gbnVsbCkgeworICAgICAgICBy ZXR1cm4gW107CisgICAgICB9CisgICAgICByZXR1cm4gdmFsOwogICAgIH0K ICAgfSk7CiAK --001a113b0b90b39c63053705fbd0 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113b0b90b39c63053705fbd0--