Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLl9b-0005D3-M0 for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Jun 2017 06:54:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dLl9b-000487-0r for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Jun 2017 06:54:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dLl9Z-00047u-Hd for pgadmin-hackers@postgresql.org; Fri, 16 Jun 2017 06:54:45 +0000 Received: from mail-it0-x233.google.com ([2607:f8b0:4001:c0b::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dLl9T-0003lW-11 for pgadmin-hackers@postgresql.org; Fri, 16 Jun 2017 06:54:44 +0000 Received: by mail-it0-x233.google.com with SMTP id b205so8268389itg.1 for ; Thu, 15 Jun 2017 23:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EgRRfcaL9Lavk9y8j3aunRgdIptOvPehyt9xgDYI2rk=; b=DWmzLqq9E78m8Pv/eF39g8uqGMZghFil/K5bEsYNYVLEqtQufP7LLnUBDspF35HW6i 9W1nI0HDxMd2REZDrGy2R+e0hxWwLp/QmB/DFFXcShErpvwLPxD6YobZTXp6AprsX7lB R5yj+KEhMo2ZZX7DqlPA7tdTlSlgBPIU0fiQzokEk5LlHdTY/VyeM4oeh7z5o4/g5S/O 1h4LdT5CAUwlkdWjkqLpGsBhbNTCh810RYit17mVF7OOVycSaieQ0AHIV+ObR80SYgla tLNaPZucMO430k0wL2hrHj/fLlIHufZtOgwFYaEvcwyxARTyU1jdskX30oSPWUl5PIES 0hyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EgRRfcaL9Lavk9y8j3aunRgdIptOvPehyt9xgDYI2rk=; b=CFsJqGa4XCP6TNNHI+tspj0psrYFHlcvegbZ8u0B7jzceK91D4P1DoqWhaNovIpBvn 6Wi9DNx6ASmuhxcAJ6a8EcYSOnxNgU12jw9xdMawq4VoGo4Mor0jhx6a5ivaLZabz6P1 Xi7pt45GM8W0pPJJjvW/AmjEDiJdbpSA+QTmZCnKkJ5eBOvDhl0hxV9/mbGQUuGaM0ON 852LGSiztUJMN7yyNMOkCqeBcC6l4npL+yEOwEVh7aBFPSEFKd0YLt7I1xXDld69u5gI HgdAhrcTTsesXphNG0YndlzWHyIcjxjS/7Cb2eZtWV9yrkBBkH2e37pgexEsjjBq85TO 2ALw== X-Gm-Message-State: AKS2vOyoPGvR+2YftrNpm9MkS9L648hqIoTDfeMA4mhSy+at283RoFo8 WiQZiQcE9L3bAiZlKJgWfV4BCljiMfpE X-Received: by 10.36.214.7 with SMTP id o7mr8921940itg.53.1497596076811; Thu, 15 Jun 2017 23:54:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.147.23 with HTTP; Thu, 15 Jun 2017 23:54:35 -0700 (PDT) In-Reply-To: References: From: Harshal Dhumal Date: Fri, 16 Jun 2017 12:24:35 +0530 Message-ID: Subject: Re: Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4] To: Dave Page Cc: Harshal Dhumal , Ashesh Vashi , pgadmin-hackers Content-Type: multipart/mixed; boundary="001a11498f002e63ca05520e4264" List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11498f002e63ca05520e4264 Content-Type: multipart/alternative; boundary="001a11498f002e63c705520e4262" --001a11498f002e63c705520e4262 Content-Type: text/plain; charset="UTF-8" Hi Dave, Please find attached patch where I have added timeout of 2 seconds before selecting object menu in connect to server function. Note: Apply this patch on top of previous patch for on demand loading feature. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 16, 2017 at 2:25 AM, Dave Page wrote: > Sounds good, thanks. > > On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal > wrote: > > Hi > > > > On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: > >> > >> Hi > >> > >> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal > >> wrote: > >> > Hi Dave, > >> > > >> > Please find attached updated patch. > >> > > >> > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: > >> >> > >> >> Hi > >> >> > >> >> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal > >> >> wrote: > >> >>> > >> >>> Hi Dave, > >> >>> > >> >>> Please find rebased patch for RM2137. > >> >> > >> >> > >> >> Looking very good. The only issues I see are: > >> >> > >> >> - The row headers should auto-size such that they can display the row > >> >> numbers if the last row was displayed. E.g. if there are 12345 rows > in > >> >> total, then the row header should be sized to display 5 digits. > >> >> > >> > Fixed. > >> > > >> > > >> >> > >> >> - The tests are comprehensive, which is awesome. However, every time > I > >> >> ran > >> >> them, at least one of the feature tests failed. Unfortunately, it > was a > >> >> different one each time. In the last two runs, I got: > >> >> > >> >> ============================================================ > ========== > >> >> ERROR: runTest > >> >> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) > >> >> Query tool feature test > >> >> ------------------------------------------------------------ > ---------- > >> >> Traceback (most recent call last): > >> >> File > >> >> > >> >> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/ > base_feature_test.py", > >> >> line 40, in setUp > >> >> self.before() > >> >> File > >> >> > >> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/ > query_tool_tests.py", > >> >> line 40, in before > >> >> self._connects_to_server() > >> >> File > >> >> > >> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/ > query_tool_tests.py", > >> >> line 144, in _connects_to_server > >> >> self.page.driver.find_element_by_link_text("Create"))\ > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webdriver.py", > >> >> line 319, in find_element_by_link_text > >> >> return self.find_element(by=By.LINK_TEXT, value=link_text) > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webdriver.py", > >> >> line 756, in find_element > >> >> 'value': value})['value'] > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webdriver.py", > >> >> line 238, in execute > >> >> self.error_handler.check_response(response) > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/errorhandler.py", > >> >> line 193, in check_response > >> >> raise exception_class(message, screen, stacktrace) > >> >> NoSuchElementException: Message: no such element: Unable to locate > >> >> element: {"method":"link text","selector":"Create"} > >> >> (Session info: chrome=58.0.3029.110) > >> >> (Driver info: chromedriver=2.29.461585 > >> >> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3 > >> >> x86_64) > >> >> > >> > I checked code from _connects_to_server function which is common in > all > >> > features test cases. I didn't find anything wrong with this. If there > is > >> > a > >> > bug in this function then all feature test must fail. > >> > Let me know if you are getting failure consistently in > >> > _connects_to_server > >> > function. > >> > >> I wondered if that one is a race condition. Do we need a short delay > >> before clicking the Object menu? I have seen this occasionally before. > > > > > > OK. In that case let's try putting 1-2 second delay and observer > behaviour. > > I'll send separate patch for this tomorrow as this is not related to on > > demand query result feature or its test cases. > > > >> > >> > >> >> > >> >> > >> >> ============================================================ > ========== > >> >> ERROR: runTest > >> >> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) > >> >> Query tool feature test > >> >> ------------------------------------------------------------ > ---------- > >> >> Traceback (most recent call last): > >> >> File > >> >> > >> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/ > query_tool_tests.py", > >> >> line 119, in runTest > >> >> self._query_tool_auto_rollback_enabled() > >> >> File > >> >> > >> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/ > query_tool_tests.py", > >> >> line 697, in _query_tool_auto_rollback_enabled > >> >> '//div[contains(@class, "sql-editor-message") and > >> >> contains(string(), > >> >> "COMMIT")]' > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webdriver.py", > >> >> line 295, in find_element_by_xpath > >> >> return self.find_element(by=By.XPATH, value=xpath) > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webdriver.py", > >> >> line 756, in find_element > >> >> 'value': value})['value'] > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/webdriver.py", > >> >> line 238, in execute > >> >> self.error_handler.check_response(response) > >> >> File > >> >> > >> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/errorhandler.py", > >> >> line 193, in check_response > >> >> raise exception_class(message, screen, stacktrace) > >> >> NoSuchElementException: Message: no such element: Unable to locate > >> >> element: {"method":"xpath","selector":"//div[contains(@class, > >> >> "sql-editor-message") and contains(string(), "COMMIT")]"} > >> >> (Session info: chrome=58.0.3029.110) > >> >> (Driver info: chromedriver=2.29.461585 > >> >> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3 > >> >> x86_64) > >> >> > >> > I have updated Auto rollback enabled test in this patch. > >> > > >> >> > >> >> Relevant screenshots attached. > >> >> > >> >> - Can you tidy up the regression output a little please? Instead of: > >> >> > >> >> ------- > >> >> runTest (pgadmin.feature_tests.query_tool_tests. > QueryToolFeatureTest) > >> >> Query tool feature test ... On demand result set on scrolling... > >> >> OK. > >> >> > >> >> On demand result set on grid select all... > >> >> OK. > >> >> > >> >> On demand result set on column select all... > >> >> OK. > >> >> > >> >> Explain query... > >> >> OK. > >> >> > >> >> Explain query with verbose... > >> >> OK. > >> >> > >> >> Explain query with costs... > >> >> OK. > >> >> > >> >> Explain analyze query... > >> >> OK. > >> >> > >> >> Explain analyze query with buffers... > >> >> OK. > >> >> > >> >> Explain analyze query with timing... > >> >> OK. > >> >> > >> >> Auto commit disabled... > >> >> OK. > >> >> > >> >> Auto commit enabled... > >> >> OK. > >> >> > >> >> Auto rollback enabled... > >> >> ERROR > >> >> ------- > >> >> > >> >> Something like: > >> >> > >> >> ------- > >> >> runTest (pgadmin.feature_tests.query_tool_tests. > QueryToolFeatureTest) > >> >> Query tool feature test ... > >> >> On demand result set on scrolling... OK. > >> >> On demand result set on grid select all... OK. > >> >> On demand result set on column select all... OK. > >> >> Explain query... OK. > >> >> Explain query with verbose... OK. > >> >> Explain query with costs... OK. > >> >> Explain analyze query... OK. > >> >> Explain analyze query with buffers... OK. > >> >> Explain analyze query with timing... OK. > >> >> Auto commit disabled... OK. > >> >> Auto commit enabled... OK. > >> >> Auto rollback enabled... ERROR > >> >> -------- > >> >> > >> > Fixed. > >> > > >> > > >> >> > >> >> Thanks! > >> >> > >> >> -- > >> >> Dave Page > >> >> Blog: http://pgsnake.blogspot.com > >> >> Twitter: @pgsnake > >> >> > >> >> EnterpriseDB UK: http://www.enterprisedb.com > >> >> The Enterprise PostgreSQL Company > >> > > >> > > >> > >> > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11498f002e63c705520e4262 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

Please find attached patch whe= re I have added timeout of 2 seconds before selecting object menu in connec= t to server function.

Note: Apply this patch on to= p of previous patch for on demand loading feature.


=
--=C2=A0
Hars= hal Dhumal
Sr. Software Engineer

=
Enterpri= seDB India:=C2=A0http://www.enterpri= sedb.com
The Enterprise PostgreSQL Co= mpany

On Fri, Jun 16, 2017 at 2:25 AM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Sounds good, thanks.

On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi
>
> On Fri, Jun 16, 2017 at 2:07 AM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal
>> <harshal.dhu= mal@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > Please find attached updated patch.
>> >
>> > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal
>> >> <ha= rshal.dhumal@enterprisedb.com> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> Please find rebased patch for RM2137.
>> >>
>> >>
>> >> Looking very good. The only issues I see are:
>> >>
>> >> - The row headers should auto-size such that they can dis= play the row
>> >> numbers if the last row was displayed. E.g. if there are = 12345 rows in
>> >> total, then the row header should be sized to display 5 d= igits.
>> >>
>> > Fixed.
>> >
>> >
>> >>
>> >> - The tests are comprehensive, which is awesome. However,= every time I
>> >> ran
>> >> them, at least one of the feature tests failed. Unfortuna= tely, it was a
>> >> different one each time. In the last two runs, I got:
>> >>
>> >>=C2=A0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D
>> >> ERROR: runTest
>> >> (pgadmin.feature_tests.query_tool_tests.QueryTo= olFeatureTest)
>> >> Query tool feature test
>> >> ----------------------------------------------------= ------------------
>> >> Traceback (most recent call last):
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/regression/featu= re_utils/base_feature_test.py",
>> >> line 40, in setUp
>> >>=C2=A0 =C2=A0 =C2=A0self.before()
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_= tests/query_tool_tests.py",
>> >> line 40, in before
>> >>=C2=A0 =C2=A0 =C2=A0self._connects_to_server()
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_= tests/query_tool_tests.py",
>> >> line 144, in _connects_to_server
>> >>=C2=A0 =C2=A0 =C2=A0self.page.driver.find_element_by_= link_text("Create"))\
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 319, in find_element_by_link_text
>> >>=C2=A0 =C2=A0 =C2=A0return self.find_element(by=3DBy.LINK_= TEXT, value=3Dlink_text)
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 756, in find_element
>> >>=C2=A0 =C2=A0 =C2=A0'value': value})['value= 9;]
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 238, in execute
>> >>=C2=A0 =C2=A0 =C2=A0self.error_handler.check_response= (response)
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/errorhandler.py",=
>> >> line 193, in check_response
>> >>=C2=A0 =C2=A0 =C2=A0raise exception_class(message, screen,= stacktrace)
>> >> NoSuchElementException: Message: no such element: Unable = to locate
>> >> element: {"method":"link text","= selector":"Create"}
>> >>=C2=A0 =C2=A0(Session info: chrome=3D58.0.3029.110)
>> >>=C2=A0 =C2=A0(Driver info: chromedriver=3D2.29.461585
>> >> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),plat= form=3DMac OS X 10.12.3
>> >> x86_64)
>> >>
>> > I checked code from _connects_to_server function which is com= mon in all
>> > features test cases. I didn't find anything wrong with th= is. If there is
>> > a
>> > bug in this function then all feature test must fail.
>> > Let me know if you are getting failure consistently in
>> > _connects_to_server
>> > function.
>>
>> I wondered if that one is a race condition. Do we need a short del= ay
>> before clicking the Object menu? I have seen this occasionally bef= ore.
>
>
> OK. In that case let's try putting 1-2 second delay and observer b= ehaviour.
> I'll send separate patch for this tomorrow as this is not related = to on
> demand query result feature or its test cases.
>
>>
>>
>> >>
>> >>
>> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D
>> >> ERROR: runTest
>> >> (pgadmin.feature_tests.query_tool_tests.QueryTo= olFeatureTest)
>> >> Query tool feature test
>> >> ----------------------------------------------------= ------------------
>> >> Traceback (most recent call last):
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_= tests/query_tool_tests.py",
>> >> line 119, in runTest
>> >>=C2=A0 =C2=A0 =C2=A0self._query_tool_auto_rollback_en= abled()
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_= tests/query_tool_tests.py",
>> >> line 697, in _query_tool_auto_rollback_enabled
>> >>=C2=A0 =C2=A0 =C2=A0'//div[contains(@class, "sql-= editor-message") and
>> >> contains(string(),
>> >> "COMMIT")]'
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 295, in find_element_by_xpath
>> >>=C2=A0 =C2=A0 =C2=A0return self.find_element(by=3DBy.XPATH= , value=3Dxpath)
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 756, in find_element
>> >>=C2=A0 =C2=A0 =C2=A0'value': value})['value= 9;]
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 238, in execute
>> >>=C2=A0 =C2=A0 =C2=A0self.error_handler.check_response= (response)
>> >>=C2=A0 =C2=A0File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2= .7/site-packages/selenium/webdriver/remote/errorhandler.py",=
>> >> line 193, in check_response
>> >>=C2=A0 =C2=A0 =C2=A0raise exception_class(message, screen,= stacktrace)
>> >> NoSuchElementException: Message: no such element: Unable = to locate
>> >> element: {"method":"xpath","sele= ctor":"//div[contains(@class,
>> >> "sql-editor-message") and contains(string(), &q= uot;COMMIT")]"}
>> >>=C2=A0 =C2=A0(Session info: chrome=3D58.0.3029.110)
>> >>=C2=A0 =C2=A0(Driver info: chromedriver=3D2.29.461585
>> >> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),plat= form=3DMac OS X 10.12.3
>> >> x86_64)
>> >>
>> > I have updated Auto rollback enabled test in this patch.
>> >
>> >>
>> >> Relevant screenshots attached.
>> >>
>> >> - Can you tidy up the regression output a little please? = Instead of:
>> >>
>> >> -------
>> >> runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
>> >> Query tool feature test ... On demand result set on scrol= ling...
>> >> OK.
>> >>
>> >> On demand result set on grid select all...
>> >> OK.
>> >>
>> >> On demand result set on column select all...
>> >> OK.
>> >>
>> >> Explain query...
>> >> OK.
>> >>
>> >> Explain query with verbose...
>> >> OK.
>> >>
>> >> Explain query with costs...
>> >> OK.
>> >>
>> >> Explain analyze query...
>> >> OK.
>> >>
>> >> Explain analyze query with buffers...
>> >> OK.
>> >>
>> >> Explain analyze query with timing...
>> >> OK.
>> >>
>> >> Auto commit disabled...
>> >> OK.
>> >>
>> >> Auto commit enabled...
>> >> OK.
>> >>
>> >> Auto rollback enabled...
>> >> ERROR
>> >> -------
>> >>
>> >> Something like:
>> >>
>> >> -------
>> >> runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
>> >> Query tool feature test ...
>> >> On demand result set on scrolling... OK.
>> >> On demand result set on grid select all... OK.
>> >> On demand result set on column select all... OK.
>> >> Explain query... OK.
>> >> Explain query with verbose... OK.
>> >> Explain query with costs... OK.
>> >> Explain analyze query... OK.
>> >> Explain analyze query with buffers... OK.
>> >> Explain analyze query with timing... OK.
>> >> Auto commit disabled... OK.
>> >> Auto commit enabled... OK.
>> >> Auto rollback enabled... ERROR
>> >> --------
>> >>
>> > Fixed.
>> >
>> >
>> >>
>> >> Thanks!
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11498f002e63c705520e4262-- --001a11498f002e63ca05520e4264 Content-Type: text/x-patch; charset="US-ASCII"; name="timeout_before_object_menu_clcik_in_connect_to_server.patch" Content-Disposition: attachment; filename="timeout_before_object_menu_clcik_in_connect_to_server.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j3zhwmck0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMvY29ubmVj dF90b19zZXJ2ZXJfZmVhdHVyZV90ZXN0LnB5IGIvd2ViL3BnYWRtaW4vZmVh dHVyZV90ZXN0cy9jb25uZWN0X3RvX3NlcnZlcl9mZWF0dXJlX3Rlc3QucHkK aW5kZXggZThkZTE2MS4uNmJlYzRhYyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRt aW4vZmVhdHVyZV90ZXN0cy9jb25uZWN0X3RvX3NlcnZlcl9mZWF0dXJlX3Rl c3QucHkKKysrIGIvd2ViL3BnYWRtaW4vZmVhdHVyZV90ZXN0cy9jb25uZWN0 X3RvX3NlcnZlcl9mZWF0dXJlX3Rlc3QucHkKQEAgLTcsNiArNyw3IEBACiAj CiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIwogCitpbXBvcnQgdGlt ZQogZnJvbSBzZWxlbml1bS53ZWJkcml2ZXIgaW1wb3J0IEFjdGlvbkNoYWlu cwogCiBpbXBvcnQgY29uZmlnIGFzIGFwcF9jb25maWcKQEAgLTUzLDYgKzU0 LDcgQEAgY2xhc3MgQ29ubmVjdHNUb1NlcnZlckZlYXR1cmVUZXN0KEJhc2VG ZWF0dXJlVGVzdCk6CiAKICAgICBkZWYgX2Nvbm5lY3RzX3RvX3NlcnZlcihz ZWxmKToKICAgICAgICAgc2VsZi5wYWdlLmZpbmRfYnlfeHBhdGgoIi8vKltA Y2xhc3M9J2FjaVRyZWVUZXh0JyBhbmQgLj0nU2VydmVycyddIikuY2xpY2so KQorICAgICAgICB0aW1lLnNsZWVwKDIpCiAgICAgICAgIHNlbGYucGFnZS5k cml2ZXIuZmluZF9lbGVtZW50X2J5X2xpbmtfdGV4dCgiT2JqZWN0IikuY2xp Y2soKQogICAgICAgICBBY3Rpb25DaGFpbnMoc2VsZi5wYWdlLmRyaXZlcikg XAogICAgICAgICAgICAgLm1vdmVfdG9fZWxlbWVudChzZWxmLnBhZ2UuZHJp dmVyLmZpbmRfZWxlbWVudF9ieV9saW5rX3RleHQoIkNyZWF0ZSIpKSBcCmRp ZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3BnX2RhdGF0 eXBlX3ZhbGlkYXRpb25fdGVzdC5weSBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVf dGVzdHMvcGdfZGF0YXR5cGVfdmFsaWRhdGlvbl90ZXN0LnB5CmluZGV4IGI3 MmY3MjcuLjZiODU4NDggMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2ZlYXR1 cmVfdGVzdHMvcGdfZGF0YXR5cGVfdmFsaWRhdGlvbl90ZXN0LnB5CisrKyBi L3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMvcGdfZGF0YXR5cGVfdmFsaWRh dGlvbl90ZXN0LnB5CkBAIC02LDYgKzYsNyBAQAogIyBUaGlzIHNvZnR3YXJl IGlzIHJlbGVhc2VkIHVuZGVyIHRoZSBQb3N0Z3JlU1FMIExpY2VuY2UKICMK ICMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCitpbXBvcnQgdGltZQog ZnJvbSBzZWxlbml1bS53ZWJkcml2ZXIgaW1wb3J0IEFjdGlvbkNoYWlucwog ZnJvbSBzZWxlbml1bS5jb21tb24uZXhjZXB0aW9ucyBpbXBvcnQgVGltZW91 dEV4Y2VwdGlvbgogZnJvbSBzZWxlbml1bS53ZWJkcml2ZXIuc3VwcG9ydC51 aSBpbXBvcnQgV2ViRHJpdmVyV2FpdApAQCAtNTYsNiArNTcsNyBAQCBjbGFz cyBQR0RhdGF5cGVGZWF0dXJlVGVzdChCYXNlRmVhdHVyZVRlc3QpOgogICAg ICAgICBzZWxmLnBhZ2UuZmluZF9ieV94cGF0aCgKICAgICAgICAgICAgICIv LypbQGNsYXNzPSdhY2lUcmVlVGV4dCcgYW5kIC49J1NlcnZlcnMnXSIKICAg ICAgICAgKS5jbGljaygpCisgICAgICAgIHRpbWUuc2xlZXAoMikKICAgICAg ICAgc2VsZi5wYWdlLmRyaXZlci5maW5kX2VsZW1lbnRfYnlfbGlua190ZXh0 KCJPYmplY3QiKS5jbGljaygpCiAgICAgICAgIEFjdGlvbkNoYWlucyhzZWxm LnBhZ2UuZHJpdmVyKSBcCiAgICAgICAgICAgICAubW92ZV90b19lbGVtZW50 KApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vZmVhdHVyZV90ZXN0cy9xdWVy eV90b29sX3Rlc3RzLnB5IGIvd2ViL3BnYWRtaW4vZmVhdHVyZV90ZXN0cy9x dWVyeV90b29sX3Rlc3RzLnB5CmluZGV4IDE4NjE1OTkuLmM1ODE3ZTMgMTAw NjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMvcXVlcnlfdG9v bF90ZXN0cy5weQorKysgYi93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3F1 ZXJ5X3Rvb2xfdGVzdHMucHkKQEAgLTEzOCw2ICsxMzgsNyBAQCBjbGFzcyBR dWVyeVRvb2xGZWF0dXJlVGVzdChCYXNlRmVhdHVyZVRlc3QpOgogICAgIGRl ZiBfY29ubmVjdHNfdG9fc2VydmVyKHNlbGYpOgogICAgICAgICBzZWxmLnBh Z2UuZmluZF9ieV94cGF0aCgKICAgICAgICAgICAgICIvLypbQGNsYXNzPSdh Y2lUcmVlVGV4dCcgYW5kIC49J1NlcnZlcnMnXSIpLmNsaWNrKCkKKyAgICAg ICAgdGltZS5zbGVlcCgyKQogICAgICAgICBzZWxmLnBhZ2UuZHJpdmVyLmZp bmRfZWxlbWVudF9ieV9saW5rX3RleHQoIk9iamVjdCIpLmNsaWNrKCkKICAg ICAgICAgQWN0aW9uQ2hhaW5zKHNlbGYucGFnZS5kcml2ZXIpIFwKICAgICAg ICAgICAgIC5tb3ZlX3RvX2VsZW1lbnQoCmRpZmYgLS1naXQgYS93ZWIvcGdh ZG1pbi9mZWF0dXJlX3Rlc3RzL3hzc19jaGVja3NfcGFuZWxzX2FuZF9xdWVy eV90b29sX3Rlc3QucHkgYi93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3hz c19jaGVja3NfcGFuZWxzX2FuZF9xdWVyeV90b29sX3Rlc3QucHkKaW5kZXgg YTBkZjQ0ZS4uNzViNDIyMiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vZmVh dHVyZV90ZXN0cy94c3NfY2hlY2tzX3BhbmVsc19hbmRfcXVlcnlfdG9vbF90 ZXN0LnB5CisrKyBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMveHNzX2No ZWNrc19wYW5lbHNfYW5kX3F1ZXJ5X3Rvb2xfdGVzdC5weQpAQCAtNzUsNiAr NzUsNyBAQCBjbGFzcyBDaGVja0Zvclhzc0ZlYXR1cmVUZXN0KEJhc2VGZWF0 dXJlVGVzdCk6CiAKICAgICBkZWYgX2Nvbm5lY3RzX3RvX3NlcnZlcihzZWxm KToKICAgICAgICAgc2VsZi5wYWdlLmZpbmRfYnlfeHBhdGgoIi8vKltAY2xh c3M9J2FjaVRyZWVUZXh0JyBhbmQgLj0nU2VydmVycyddIikuY2xpY2soKQor ICAgICAgICB0aW1lLnNsZWVwKDIpCiAgICAgICAgIHNlbGYucGFnZS5kcml2 ZXIuZmluZF9lbGVtZW50X2J5X2xpbmtfdGV4dCgiT2JqZWN0IikuY2xpY2so KQogICAgICAgICBBY3Rpb25DaGFpbnMoc2VsZi5wYWdlLmRyaXZlcikgXAog ICAgICAgICAgICAgLm1vdmVfdG9fZWxlbWVudChzZWxmLnBhZ2UuZHJpdmVy LmZpbmRfZWxlbWVudF9ieV9saW5rX3RleHQoIkNyZWF0ZSIpKSBcCmRpZmYg LS1naXQgYS93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3hzc19jaGVja3Nf cGdhZG1pbl9kZWJ1Z2dlcl90ZXN0LnB5IGIvd2ViL3BnYWRtaW4vZmVhdHVy ZV90ZXN0cy94c3NfY2hlY2tzX3BnYWRtaW5fZGVidWdnZXJfdGVzdC5weQpp bmRleCAwOTRkZmVkLi5lODQ3MDQwIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1p bi9mZWF0dXJlX3Rlc3RzL3hzc19jaGVja3NfcGdhZG1pbl9kZWJ1Z2dlcl90 ZXN0LnB5CisrKyBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMveHNzX2No ZWNrc19wZ2FkbWluX2RlYnVnZ2VyX3Rlc3QucHkKQEAgLTQyLDYgKzQyLDcg QEAgY2xhc3MgQ2hlY2tEZWJ1Z2dlckZvclhzc0ZlYXR1cmVUZXN0KEJhc2VG ZWF0dXJlVGVzdCk6CiAKICAgICBkZWYgX2Nvbm5lY3RzX3RvX3NlcnZlcihz ZWxmKToKICAgICAgICAgc2VsZi5wYWdlLmZpbmRfYnlfeHBhdGgoIi8vKltA Y2xhc3M9J2FjaVRyZWVUZXh0JyBhbmQgLj0nU2VydmVycyddIikuY2xpY2so KQorICAgICAgICB0aW1lLnNsZWVwKDIpCiAgICAgICAgIHNlbGYucGFnZS5k cml2ZXIuZmluZF9lbGVtZW50X2J5X2xpbmtfdGV4dCgiT2JqZWN0IikuY2xp Y2soKQogICAgICAgICBBY3Rpb25DaGFpbnMoc2VsZi5wYWdlLmRyaXZlcikg XAogICAgICAgICAgICAgLm1vdmVfdG9fZWxlbWVudChzZWxmLnBhZ2UuZHJp dmVyLmZpbmRfZWxlbWVudF9ieV9saW5rX3RleHQoIkNyZWF0ZSIpKSBcCg== --001a11498f002e63ca05520e4264 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11498f002e63ca05520e4264--