Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avM8m-0002KO-Ll for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Apr 2016 09:52:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1avM8m-00035A-47 for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Apr 2016 09:52:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1avM8l-000350-BA for pgadmin-hackers@postgresql.org; Wed, 27 Apr 2016 09:52:15 +0000 Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1avM8i-0005Fx-0E for pgadmin-hackers@postgresql.org; Wed, 27 Apr 2016 09:52:14 +0000 Received: by mail-oi0-x22a.google.com with SMTP id k142so43434469oib.1 for ; Wed, 27 Apr 2016 02:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=l/QT4Ml1dky3pleGG//WlOplGNfIjBZAQCiKfd9rrYg=; b=FGu9TVyTRoyGLPDFI65G30KCN1+0yUspvBlmqEWp2Io3Ip02oHyCoINLfrbsHJWO6m oJ6CacPR6T5xC3AuA6BJ7JPab+Wp3YOJpz46IwzKYc2i+yiqDDcu+QPlvowRab4cG8BU 28jgTFe2fYk+DJ0nxC97AtALpNRV1msC2NfkVQk8VQXq78DkiR1uXcML2Sxd73M1+9rz 4ADOuXxmLNZFEoQKyzK6y7Crf+Wub2yJU0S5ce4w65qdJzBzx4SuzxDt4cddtBrZJdg2 8qBvKddGtEQrMSVv5rqlDLfsSjce0ylMrVyqfjx/mZ2JRRTQ3QvXJGHhDmX5I4Ukg6Mj +NMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=l/QT4Ml1dky3pleGG//WlOplGNfIjBZAQCiKfd9rrYg=; b=Ffujye8IQgXjcgwhi/4TyvZE/mGtlTNZo21kXwG46a411dBmSIVLyrzk3qFHoOKcrW /cqhKVSuObdKkXwO9hTe3rq/b61OCh4eO3y2tSk7jpB8uBQ3zSP/5F3oc6ldBZxcuRAA 3sYhP4Saf2ROE2Z8sG9hHpGaX8eievoCNj0uMc4ovH83f1rDMOQKWRwpBXwMex1WVqZR mkskKQ2bn0+QUZkMXT0jBVS58vVUN5/4tKFcKXF51RdOScqmXCNDsgZfccOjZuBgqaFM vBYKLHTPxoXZuy7gJg8Uy6PGhkBtZWplCN6P3cQK1z1FXlM4UVW1xMV2UQwVaFD4mCbK LN+Q== X-Gm-Message-State: AOPr4FWu99NJtPp94kbn2nxC2Js7Wt0/87ARsGOkUFhRmUb8IrGcJoMganHAO0/FPZyLTedtCkesgdD4lszYxSBm MIME-Version: 1.0 X-Received: by 10.202.204.21 with SMTP id c21mr2616012oig.188.1461750730414; Wed, 27 Apr 2016 02:52:10 -0700 (PDT) Received: by 10.157.54.226 with HTTP; Wed, 27 Apr 2016 02:52:10 -0700 (PDT) In-Reply-To: References: Date: Wed, 27 Apr 2016 15:22:10 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) From: Harshal Dhumal To: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113524000976ab0531745d67 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113524000976ab0531745d67 Content-Type: text/plain; charset=UTF-8 Hi, The exclusion constraint has minor validation issue (this won't block testing of patch). I'm closely working with Ashesh to fix this. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Apr 27, 2016 at 2:52 PM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > PFA attached patches for table node and all table child nodes. > > This patch includes below nodes, > > 1) Table node *-- Initial patch by Murtuza, > constraints compatibility by Harshal. * > 2) Column node *-- by Murtuza. * > 3) Index node *-- by Murtuza. * > 4) Trigger node *-- by Murtuzz. * > 6) Rules node > *-- by Surinder.* > 7) Constraints nodes: > i] Index Constraint *-- Initial patch by Harshal, > Integration with table node by **Murtuza.* > ii] Foreign key *-- Initial patch and > Integration with table node by Harshal**.* > iii] Check constraint *-- Initial patch and > Integration with table node by Harshal**.* > iv] Exclusion constraint *-- Initial patch and > Integration with table node by Harshal**.* > > Please apply patches in following order as all of them depends on each > other. > > > > *Order: Table Node ----> Index constraint ---> remaining patches in any > order.* > > > > > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB > > On Mon, Apr 18, 2016 at 7:04 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> Please find initial patch for tables node. >> >> This patch includes below nodes, >> >> 1) Tables node >> 2) Columns node >> 3) Index node >> 4) Trigger node >> 5) Constraints node (Primary key & Unique constraints only) *-- From: >> Harshal* >> 6) Roles node >> *-- From: Surinder* >> >> This patch also includes "VacuumSettings control" required by table node. >> >> Please apply Fieldset Control UI patch sent earlier. >> >> >> *Please note that constraint node is still partial, It has Primary Key & >> Unique constraint working & integrated in tables node.* >> >> 1) I have used initial patch of index constraints node from Harshal & >> further extend it it to work with table node. >> [ Harshal will integrate rest of constraints in tables node, he is >> working on it.] >> >> 2) I have also used initial patches of rules node and VacuumSettings >> control from Surinder & further extend them it to work with table node. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --001a113524000976ab0531745d67 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

The exclusion constraint has minor = validation issue (this won't block testing of patch). I'm closely w= orking with Ashesh to fix this.

--=C2=A0
Harshal Dhumal
Sof= tware Engineer=C2=A0




On Wed, Apr 27, 2016 at 2:52 PM, Harshal Dhu= mal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
PFA attached patches for table node and all table child nodes.<= span class=3D"">

This patch includes below nodes,
1) Table node=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -- Initial patc= h by Murtuza, constraints compatibility by Harshal.
2) Column node=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --=C2=A0by Murtuza.
3) Index node=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --=C2=A0b= y Murtuza.
4) Trigger node=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= = -- by Murtuzz.
6) Rules node =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0=C2=A0 -- by Surinder.
7)= Constraints nodes:
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 i]=C2=A0 Index = Constraint=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -- Initial patch by Harshal, Int= egration with table node by Murtuza.<= /span>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ii] Foreign key=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -- Initial patch and Int= egration with table node by Harshal.<= /span>
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iii] Check constraint=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 -- Initial patch and Integration with table node by Harshal<= /b>.
=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 iv] Exclusion constraint=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 -- Initial patch and Integration with table node by= Harshal.

<= /div>
Please apply patches in following order as all of them depends on= each other.

Order:=C2=A0 Table Node ----> Index co= nstraint ---> remaining patches in any order.


= =C2=A0




--=C2=A0
Harshal Dhumal
Soft= ware Engineer=C2=A0




On Mon, Apr 18, 2016 = at 7:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterpri= sedb.com> wrote:
Hi,

Please fin= d initial patch for tables node.

This patch includ= es below nodes,

1) Tables node
2) Column= s node
3) Index node
4) Trigger node
5) Const= raints node (Primary key & Unique constraints only) =C2=A0 =C2=A0-- From: Harshal
6) Roles node =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-- From: Surinder

This patch also includes "VacuumS= ettings control" required by table node.

Plea= se apply Fieldset Control UI patch sent earlier.

<= span style=3D"background-color:rgb(204,204,204)">
Please note that constraint node= is still partial, It has Primary Key & Unique constraint working &= integrated in tables node.

1) =C2=A0I have used initial patch of index constraints=C2=A0= node from Harshal & further extend it it to work with table node.
[ Harsha= l will integrate rest of constraints in tables node, he is working on it.]<= /span>
2) I = have also used initial patches of rules node and VacuumSettings control fro= m Surinder & further extend them it to work with table node.


--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.en= terprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=



--001a113524000976ab0531745d67--