Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSLvs-0006yD-DK for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 10:19:20 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bSLvr-0001PO-WA for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 10:19:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bSLve-0001Ba-MQ for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 10:19:07 +0000 Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bSLva-00077j-CK for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 10:19:05 +0000 Received: by mail-oi0-x22a.google.com with SMTP id l72so10977979oig.2 for ; Wed, 27 Jul 2016 03:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kdUY9aZb2ARh04yLsnDYn6RR83bRYXFaW0oilbfGtfs=; b=m8+/sAgxgOql1IxoXCZhiYVIw2Cwp6qNFWqpD7JcKKRpbZd9p+lfRihKVab5jSLPMP vUw+aTgZHyTqu91JXmiUTop2Yivz6ZYAL8Vbfe8SyMaEfmRfLqKT5ZbvWG+QcMO7JzqR whZ2zbMA9ljiYzq0pbFskiKrzi6TXzaVHrrX993xeiQWNjlm+U5QYql1l3GuuDZvskYB TH1DtU5TRGAy998msDVE52vlebmyeC19n4RFQLLdCpeFMAnvyg1WnDlCwWavFnpIXl5D axquYSfCwopjj3gydi+tTsuOeel/RfO/BOYazfFRT14caQy3KdtcvgWwdhkn3I0vF7xd e+Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kdUY9aZb2ARh04yLsnDYn6RR83bRYXFaW0oilbfGtfs=; b=jWj4Y3S22+R7Qke6jMDZ+hqCWu/1I6aoS6UEDEQbsfKs9R1n36S7nJTboZysMYvkyc KudTuXoyEHa3+yyfmjoibyVhquU09IaBve6ohmB82M+H0Qi0SM8YcZpd+mpu/v0vVHu7 ++2qomUvsJc0Af5RZjZe8Pcjwa7hEUeEPd8amgkcY2FoGLnkGEBZOfnmRAruiPAw5UzZ AXBvfuYCr0mGdkQ5OvQfEd9m/SHJCiFvfEJXw+eQKBjQ/XWgD6uJY2LON2Du1QAliDF3 AOa48SQgU9wC46a3nVnQjOV+0PMDSftZlc3L7yXfBZcmxlYp24uk/ZwV4LwH3qUF/AXL LQ6g== X-Gm-Message-State: AEkoouuy7LW3whVf7CyuktMkt8kGQDF6ScLnURtFyV1UI1HiSWBc76lQG0apSAkJvArhkaUAYJkgDScrUKqmu3CV X-Received: by 10.202.232.1 with SMTP id f1mr14792059oih.75.1469614741610; Wed, 27 Jul 2016 03:19:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.99 with HTTP; Wed, 27 Jul 2016 03:19:01 -0700 (PDT) In-Reply-To: References: From: Harshal Dhumal Date: Wed, 27 Jul 2016 15:49:01 +0530 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: Ashesh Vashi Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140801ea179b505389b580b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140801ea179b505389b580b Content-Type: text/plain; charset=UTF-8 Hi, PFA updated patch for RM1260. In addition to RM1260 issue I have added following changes in this patch. 1] datamodel.js: Added option check against undefined. 2] foreign key: fixed first empty option issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 5:08 PM, Ashesh Vashi wrote: > Sure - I will do. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Thu, Jul 7, 2016 at 2:33 PM, Dave Page wrote: > >> Ashesh, can you review/commit please? >> >> Thanks. >> >> On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> By mistake I deleted a line which was not supposed to be deleted, and >>> that line of code was initialization of select2. >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Hi Harshal, >>>> >>>> Can you please explain - what was missing in the last patch? >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>> On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal < >>>> harshal.dhumal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA updated patch for issue RM1260 >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Software Engineer* >>>>> >>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < >>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> Please ignore this patch as this has some minor issue. I'll sent >>>>>> updated one. >>>>>> >>>>>> -- >>>>>> *Harshal Dhumal* >>>>>> *Software Engineer* >>>>>> >>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < >>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> PFA patch for issue RM1260. >>>>>>> >>>>>>> Changes: Issue wasn't related to foreign table but was due the >>>>>>> Select2 control. Now I have improved select2 control to handle null value >>>>>>> in multi-select mode. Initial it was returning "null" instead it should >>>>>>> return [] (empty array). >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Harshal Dhumal* >>>>>>> *Software Engineer* >>>>>>> >>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a1140801ea179b505389b580b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA updated patch for= RM1260.

In addition to RM1260 issue I have added following ch= anges in this patch.
1] datamodel.js: Added option check against u= ndefined.
2] foreign key: fixed first empty option issue.

--=C2=A0
Harshal Dhumal
= Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>

On Thu, Jul 7, 2016 at 5:08 PM, Ashesh Vashi= <ashesh.vashi@enterprisedb.com> wrote:
Sure - I will do.

<= p style=3D"margin:0pt">--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<= /p>

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7,= 2016 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit= please?

Thanks.
<= div>

On Thu, Jul 7, 2016 at 7:50 AM, Har= shal Dhumal <harshal.dhumal@enterprisedb.com> = wrote:
Hi,

<= /div>By mistake I deleted a line which was not supposed to be deleted, and = that line of code was initialization of select2.

--=C2=A0
=
Harshal Dhumal
Software Engineer
=
= EnterpriseDB India:=C2=A0http://www.= enterprisedb.com
<= span style=3D"color:rgb(136,136,136);font-size:12.8px">The Enterprise Postg= reSQL Company

On Thu, Jul 7, 2016 at 12:1= 3 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,
Can you please explain - what was missing in the last patc= h?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 12:12 PM, H= arshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA updated patch for issue RM1260
=

=
--=C2=A0
Harshal Dhumal
Software Enginee= r

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:04 PM= , Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Plea= se ignore this patch as this has some minor issue. I'll sent updated on= e.

<= div>
--=C2=A0
Harshal Dhumal
Soft= ware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA patch for issue RM1260.

Changes: Issue w= asn't related to foreign table but was due the Select2 control. Now I h= ave improved select2 control to handle null value in multi-select mode. Ini= tial it was returning "null" instead it should return [] (empty a= rray).


--=C2=A0
Harshal Dhumal
=
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






<= font color=3D"#888888">--
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company


--001a1140801ea179b505389b580b--