public inbox for [email protected]  

help / color / mirror / Atom feed

From: Harshal Dhumal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: RM1492 [pgadmin4]
Date: Thu, 4 Aug 2016 15:22:01 +0530
Message-ID: <CAFiP3vxAR64dO_qUcRzOe+ubgCQ_xeeCaAyMTEdn_QNVWbop7Q@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

PFA patch for RM1492

Issue fixed: Generate proper queries for "View all/first 100/last 100 rows"
with table containing columns with capital letters.


-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] RM1492.patch (991B, 3-RM1492.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/command.py b/web/pgadmin/tools/sqleditor/command.py
index e491fba..de3a9f8 100644
--- a/web/pgadmin/tools/sqleditor/command.py
+++ b/web/pgadmin/tools/sqleditor/command.py
@@ -365,8 +365,8 @@ class TableCommand(GridCommand):
         """
         This function is used to fetch the primary key columns.
         """
-
-        manager = get_driver(PG_DEFAULT_DRIVER).connection_manager(self.sid)
+        driver = get_driver(PG_DEFAULT_DRIVER)
+        manager = driver.connection_manager(self.sid)
         conn = manager.connection(did=self.did, conn_id=self.conn_id)
 
         pk_names = ''
@@ -382,7 +382,7 @@ class TableCommand(GridCommand):
                 raise Exception(result)
 
             for row in result['rows']:
-                pk_names += row['attname'] + ','
+                pk_names += driver.qtIdent(conn, row['attname']) + ','
                 primary_keys[row['attname']] = row['typname']
 
             if pk_names != '':

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: RM1492 [pgadmin4]
  In-Reply-To: <CAFiP3vxAR64dO_qUcRzOe+ubgCQ_xeeCaAyMTEdn_QNVWbop7Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox