MIME-Version: 1.0
From: Harshal Dhumal <harshal.dhumal@enterprisedb.com>
Date: Thu, 10 Jan 2019 13:16:53 +0530
Message-ID: 
 <CAFiP3vxc4KKGzKboMcMJBpMpVJGkhcthgb89YbqTtVknbWhw4A@mail.gmail.com>
Subject: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000e77874057f15c883"
Precedence: bulk

--000000000000e77874057f15c883
Content-Type: multipart/alternative; boundary="000000000000e77872057f15c881"

--000000000000e77872057f15c881
Content-Type: text/plain; charset="UTF-8"

Hi,
This patch fixes Dialog tabset keyboard navigation.
This regression was caused due to bootstrap 4 changes.
Also I have added jasmine test cases for the same


-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000e77872057f15c881
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi,</div><div>This patch fixes=C2=A0=
Dialog tabset keyboard navigation.</div><div>This regression was caused due=
 to bootstrap 4 changes.</div><div>Also I have added jasmine test cases for=
 the same</div><div><br></div><br clear=3D"all"><div><div dir=3D"ltr" class=
=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=
=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr">=
<div><div dir=3D"ltr"><div>--=C2=A0</div><div><b>Harshal Dhumal</b></div><d=
iv><b>Sr. Software Engineer</b></div><div><b><br></b></div><div><span style=
=3D"color:rgb(136,136,136);font-size:12.8px">EnterpriseDB India:=C2=A0</spa=
n><a href=3D"http://www.enterprisedb.com/" style=3D"color:rgb(17,85,204);fo=
nt-size:12.8px" target=3D"_blank">http://www.enterprisedb.com</a><br style=
=3D"color:rgb(136,136,136);font-size:12.8px"><span style=3D"color:rgb(136,1=
36,136);font-size:12.8px">The Enterprise PostgreSQL Company</span><br></div=
></div></div></div></div></div></div></div></div></div></div></div></div></=
div></div></div></div></div>

--000000000000e77872057f15c881--

--000000000000e77874057f15c883
Content-Type: text/x-patch; charset="US-ASCII"; name="RM3862.patch"
Content-Disposition: attachment; filename="RM3862.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jqqb32zr0>
X-Attachment-Id: f_jqqb32zr0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9kaWFsb2dfdGFiX25hdmlnYXRvci5q
cyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9kaWFsb2dfdGFiX25hdmlnYXRvci5qcwppbmRleCAx
OWIyMDQ1Li5lYTVmZWMzIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMvanMvZGlhbG9n
X3RhYl9uYXZpZ2F0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2RpYWxvZ190YWJf
bmF2aWdhdG9yLmpzCkBAIC04Niw3ICs4Niw3IEBAIGNsYXNzIGRpYWxvZ1RhYk5hdmlnYXRvciB7
CiAgICAgdmFyIHNlbGYgPSB0aGlzLAogICAgICAgbmV4dFRhYlBhbmUsCiAgICAgICBpbm5lclRh
YkNvbnRhaW5lciwKLSAgICAgIHByZXZ0YWIgPSAkKHRhYnMpLmZpbmQoJ2xpLmFjdGl2ZScpLnBy
ZXYoJ2xpJyk7CisgICAgICBwcmV2dGFiID0gJCh0YWJzKS5maW5kKCdsaScpLmhhcygnYS5hY3Rp
dmUnKS5wcmV2KCdsaScpOwogCiAgICAgaWYgKHByZXZ0YWIubGVuZ3RoID4gMCkgewogICAgICAg
cHJldnRhYi5maW5kKCdhJykudGFiKCdzaG93Jyk7CkBAIC0xMTYsNyArMTE2LDcgQEAgY2xhc3Mg
ZGlhbG9nVGFiTmF2aWdhdG9yIHsKICAgICB2YXIgc2VsZiA9IHRoaXMsCiAgICAgICBuZXh0VGFi
UGFuZSwKICAgICAgIGlubmVyVGFiQ29udGFpbmVyLAotICAgICAgbmV4dHRhYiA9ICQodGFicyku
ZmluZCgnbGkuYWN0aXZlJykubmV4dCgnbGknKTsKKyAgICAgIG5leHR0YWIgPSAkKHRhYnMpLmZp
bmQoJ2xpJykuaGFzKCdhLmFjdGl2ZScpLm5leHQoJ2xpJyk7CiAKICAgICBpZihuZXh0dGFiLmxl
bmd0aCA+IDApIHsKICAgICAgIG5leHR0YWIuZmluZCgnYScpLnRhYignc2hvdycpOwpAQCAtMTQ5
LDQgKzE0OSw0IEBAIGNsYXNzIGRpYWxvZ1RhYk5hdmlnYXRvciB7CiAKIG1vZHVsZS5leHBvcnRz
ID0gewogICBkaWFsb2dUYWJOYXZpZ2F0b3I6IGRpYWxvZ1RhYk5hdmlnYXRvciwKLX07ClwgTm8g
bmV3bGluZSBhdCBlbmQgb2YgZmlsZQorfTsKZGlmZiAtLWdpdCBhL3dlYi9yZWdyZXNzaW9uL2ph
dmFzY3JpcHQvZGlhbG9nX3RhYl9uYXZpZ2F0b3Jfc3BlYy5qcyBiL3dlYi9yZWdyZXNzaW9uL2ph
dmFzY3JpcHQvZGlhbG9nX3RhYl9uYXZpZ2F0b3Jfc3BlYy5qcwppbmRleCBmMzU1ZTg4Li41YzQ2
OTk2IDEwMDY0NAotLS0gYS93ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L2RpYWxvZ190YWJfbmF2
aWdhdG9yX3NwZWMuanMKKysrIGIvd2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9kaWFsb2dfdGFi
X25hdmlnYXRvcl9zcGVjLmpzCkBAIC0xNCwxMCArMTQsMTAgQEAgZGVzY3JpYmUoJ2RpYWxvZ1Rh
Yk5hdmlnYXRvcicsIGZ1bmN0aW9uICgpIHsKICAgbGV0IGRpYWxvZywgdGFiTmF2aWdhdG9yLCBi
YWNrd2FyZF9zaG9ydGN1dCwgZm9yd2FyZF9zaG9ydGN1dDsKIAogICBiZWZvcmVFYWNoKCgpID0+
IHsKLSAgICBsZXQgZGlhbG9nSHRtbCA9JCgnPGRpdiB0YWJpbmRleD0iMSIgY2xhc3M9ImJhY2tm
b3JtLXRhYiIgcm9sZT0idGFicGFuZWwiPicrCisgICAgbGV0IGRpYWxvZ0h0bWwgPSAkKCc8ZGl2
IHRhYmluZGV4PSIxIiBjbGFzcz0iYmFja2Zvcm0tdGFiIiByb2xlPSJ0YWJwYW5lbCI+JysKICAg
ICAgICAgJyAgIDx1bCBjbGFzcz0ibmF2IG5hdi10YWJzIiByb2xlPSJ0YWJsaXN0Ij4nKwotICAg
ICAgICAnICAgICAgPGxpIHJvbGU9InByZXNlbnRhdGlvbiIgY2xhc3M9ImFjdGl2ZSI+JysKLSAg
ICAgICAgJyAgICAgICAgIDxhIGRhdGEtdG9nZ2xlPSJ0YWIiIHRhYmluZGV4PSItMSIgZGF0YS10
YWItaW5kZXg9IjEiIGhyZWY9IiMxIiBhcmlhLWNvbnRyb2xzPSIxIj4gR2VuZXJhbDwvYT4nKwor
ICAgICAgICAnICAgICAgPGxpIHJvbGU9InByZXNlbnRhdGlvbiI+JysKKyAgICAgICAgJyAgICAg
ICAgIDxhIGNsYXNzPSJhY3RpdmUiIGRhdGEtdG9nZ2xlPSJ0YWIiIHRhYmluZGV4PSItMSIgZGF0
YS10YWItaW5kZXg9IjEiIGhyZWY9IiMxIiBhcmlhLWNvbnRyb2xzPSIxIj4gR2VuZXJhbDwvYT4n
KwogICAgICAgICAnICAgICAgPC9saT4nKwogICAgICAgICAnICAgICA8bGkgcm9sZT0icHJlc2Vu
dGF0aW9uIj4nKwogICAgICAgICAnICAgICAgICAgPGEgZGF0YS10b2dnbGU9InRhYiIgdGFiaW5k
ZXg9Ii0xIiBkYXRhLXRhYi1pbmRleD0iNSIgaHJlZj0iIzIiIGFyaWEtY29udHJvbHM9IjIiPiBE
ZWZhdWx0IFByaXZpbGVnZXM8L2E+JysKQEAgLTExMiw0ICsxMTIsOTMgQEAgZGVzY3JpYmUoJ2Rp
YWxvZ1RhYk5hdmlnYXRvcicsIGZ1bmN0aW9uICgpIHsKIAogICB9KTsKIAotfSk7ClwgTm8gbmV3
bGluZSBhdCBlbmQgb2YgZmlsZQorCisgIGRlc2NyaWJlKCduYXZpZ2F0ZUZvcndhcmQgZnJvbSBm
aXN0IHRhYiB0byBzZWNvbmQgdGFiJywgZnVuY3Rpb24gKCkgeworICAgIHZhciBuYXZpZ2F0ZUZv
cndhcmRSZXN1bHQ7CisgICAgYmVmb3JlRWFjaCgoKSA9PiB7CisgICAgICBzcHlPbih0YWJOYXZp
Z2F0b3IsICduYXZpZ2F0ZUZvcndhcmQnKS5hbmQuY2FsbFRocm91Z2goKTsKKworICAgICAgbmF2
aWdhdGVGb3J3YXJkUmVzdWx0ID0gdGFiTmF2aWdhdG9yLm5hdmlnYXRlRm9yd2FyZCgKKyAgICAg
ICAgZGlhbG9nLiRlbC5maW5kKCd1bC5uYXYtdGFiczpmaXJzdCcpLAorICAgICAgICBkaWFsb2cu
JGVsLmZpbmQoJ2RpdiMxJykKKyAgICAgICk7CisgICAgfSk7CisKKyAgICBpdCgnc2hvdWxkIHJl
dHVybiB0cnVlJywgZnVuY3Rpb24gKCkgeworCisgICAgICBleHBlY3QobmF2aWdhdGVGb3J3YXJk
UmVzdWx0KS50b0VxdWFsKHRydWUpOworCisgICAgfSk7CisKKyAgfSk7CisKKworICBkZXNjcmli
ZSgnbmF2aWdhdGVGb3J3YXJkIGZyb20gbGFzdCB0YWInLCBmdW5jdGlvbiAoKSB7CisgICAgdmFy
IG5hdmlnYXRlRm9yd2FyZFJlc3VsdDsKKyAgICBiZWZvcmVFYWNoKCgpID0+IHsKKworICAgICAg
Ly8gc2V0IHNlY29uZCB0YWIgYWN0aXZlCisgICAgICBkaWFsb2cuJGVsLmZpbmQoJ3VsLm5hdi10
YWJzIGxpIGEuYWN0aXZlJykucmVtb3ZlQ2xhc3MoJ2FjdGl2ZScpOworCisgICAgICBkaWFsb2cu
JGVsLmZpbmQoJ3VsLm5hdi10YWJzIGxpIGFbaHJlZj0iIzMiXScpLmFkZENsYXNzKCdhY3RpdmUn
KTsKKworICAgICAgc3B5T24odGFiTmF2aWdhdG9yLCAnbmF2aWdhdGVGb3J3YXJkJykuYW5kLmNh
bGxUaHJvdWdoKCk7CisKKyAgICAgIG5hdmlnYXRlRm9yd2FyZFJlc3VsdCA9IHRhYk5hdmlnYXRv
ci5uYXZpZ2F0ZUZvcndhcmQoCisgICAgICAgIGRpYWxvZy4kZWwuZmluZCgndWwubmF2LXRhYnM6
Zmlyc3QnKSwKKyAgICAgICAgZGlhbG9nLiRlbC5maW5kKCdkaXYjMScpCisgICAgICApOworICAg
IH0pOworCisgICAgaXQoJ3Nob3VsZCByZXR1cm4gZmFsc2UnLCBmdW5jdGlvbiAoKSB7CisKKyAg
ICAgIGV4cGVjdChuYXZpZ2F0ZUZvcndhcmRSZXN1bHQpLnRvRXF1YWwoZmFsc2UpOworCisgICAg
fSk7CisKKyAgfSk7CisKKyAgZGVzY3JpYmUoJ25hdmlnYXRlQmFja3dhcmQgZnJvbSBzZWNvbmQg
dGFiIHRvIGZpcnN0IHRhYicsIGZ1bmN0aW9uICgpIHsKKyAgICB2YXIgbmF2aWdhdGVCYWNrd2Fy
ZFJlc3VsdDsKKyAgICBiZWZvcmVFYWNoKCgpID0+IHsKKyAgICAgIC8vIHNldCBzZWNvbmQgdGFi
IGFjdGl2ZQorICAgICAgZGlhbG9nLiRlbC5maW5kKCd1bC5uYXYtdGFicyBsaSBhLmFjdGl2ZScp
LnJlbW92ZUNsYXNzKCdhY3RpdmUnKTsKKworICAgICAgZGlhbG9nLiRlbC5maW5kKCd1bC5uYXYt
dGFicyBsaSBhW2hyZWY9IiMyIl0nKS5hZGRDbGFzcygnYWN0aXZlJyk7CisKKyAgICAgIHNweU9u
KHRhYk5hdmlnYXRvciwgJ25hdmlnYXRlQmFja3dhcmQnKS5hbmQuY2FsbFRocm91Z2goKTsKKwor
ICAgICAgbmF2aWdhdGVCYWNrd2FyZFJlc3VsdCA9IHRhYk5hdmlnYXRvci5uYXZpZ2F0ZUJhY2t3
YXJkKAorICAgICAgICBkaWFsb2cuJGVsLmZpbmQoJ3VsLm5hdi10YWJzOmZpcnN0JyksCisgICAg
ICAgIGRpYWxvZy4kZWwuZmluZCgnZGl2IzEnKQorICAgICAgKTsKKyAgICB9KTsKKworICAgIGl0
KCdzaG91bGQgcmV0dXJuIHRydWUnLCBmdW5jdGlvbiAoKSB7CisKKyAgICAgIGV4cGVjdChuYXZp
Z2F0ZUJhY2t3YXJkUmVzdWx0KS50b0VxdWFsKHRydWUpOworCisgICAgfSk7CisKKyAgfSk7CisK
KyAgZGVzY3JpYmUoJ25hdmlnYXRlQmFja3dhcmQgZnJvbSBmaXJzdCB0YWInLCBmdW5jdGlvbiAo
KSB7CisgICAgdmFyIG5hdmlnYXRlQmFja3dhcmRSZXN1bHQ7CisgICAgYmVmb3JlRWFjaCgoKSA9
PiB7CisgICAgICBzcHlPbih0YWJOYXZpZ2F0b3IsICduYXZpZ2F0ZUJhY2t3YXJkJykuYW5kLmNh
bGxUaHJvdWdoKCk7CisKKyAgICAgIG5hdmlnYXRlQmFja3dhcmRSZXN1bHQgPSB0YWJOYXZpZ2F0
b3IubmF2aWdhdGVCYWNrd2FyZCgKKyAgICAgICAgZGlhbG9nLiRlbC5maW5kKCd1bC5uYXYtdGFi
czpmaXJzdCcpLAorICAgICAgICBkaWFsb2cuJGVsLmZpbmQoJ2RpdiMxJykKKyAgICAgICk7Cisg
ICAgfSk7CisKKyAgICBpdCgnc2hvdWxkIHJldHVybiBmYWxzZScsIGZ1bmN0aW9uICgpIHsKKwor
ICAgICAgZXhwZWN0KG5hdmlnYXRlQmFja3dhcmRSZXN1bHQpLnRvRXF1YWwoZmFsc2UpOworCisg
ICAgfSk7CisKKyAgfSk7CisKK30pOwo=
--000000000000e77874057f15c883--