Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIKHd-0000uc-4r for pgadmin-hackers@arkaria.postgresql.org; Wed, 29 Jun 2016 18:32:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bIKHc-0006jp-Np for pgadmin-hackers@arkaria.postgresql.org; Wed, 29 Jun 2016 18:32:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bIKHc-0006jj-78 for pgadmin-hackers@postgresql.org; Wed, 29 Jun 2016 18:32:20 +0000 Received: from mail-ob0-x230.google.com ([2607:f8b0:4003:c01::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bIKHZ-0004gK-Ho for pgadmin-hackers@postgresql.org; Wed, 29 Jun 2016 18:32:19 +0000 Received: by mail-ob0-x230.google.com with SMTP id ru5so37725264obc.1 for ; Wed, 29 Jun 2016 11:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JWncKFvmoqcVyYI8qEzhoA7qzR7xT4ptGjFXLtgoukY=; b=abF+2Z41LEu8QPcCHdDmZYAEghrofwE7S1JfqGXlDQsrSSVJYiKLgoADMwGAFLp8Z2 Iei4oexZO5b5+g1zGgeSBTVTJNb6WU7aNYBF6xIZUcS5Xq2x1KxcJM4fYj8lzy/aPzP0 nPL++yQX84jsfWE2JfIhYSknIo/Yytci96tpCIX45HCLwvlnKJjdBupJ15xTB5I6Tvyy Ia+vkpbahEdh+WnyNbRysJ+CO2v6iTDWixiPQ7qmhldKgsesyFaquvMJFAqLIM+gvQLo llj3b2soYPIr8hsfkvXnEMRyRXsK9m5q+7kqIWwwpobrqLch4opJe2mRIz+YcCRqS9Wl r+FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JWncKFvmoqcVyYI8qEzhoA7qzR7xT4ptGjFXLtgoukY=; b=lJA6jHq5szi/1orVeZcPOFjEjIukx7n4PHAJUHVKOvOzp27TCSZAzbFlJ9eiNvNgqq QwWRsUxjRJWYahuZn/SM0r1D0AG1c2kwrLPV62JRIQScFndtnZ094CqY9JJZspm6m+lP Em35Zve2kAqg1u15GzGcHLBtiCtVWX45cU91f7wTO9KbU6VOWq7i1qVHKmi3eYaoOoXw XQiZDftvwyi7J46N/cpKB+TRFmaz3JvjW5kFhHzuvekZxSm5lkmcnnBdVFyQ4U/skmv2 DO3SH29WbBnrqS10Icw87qCM8eFvvcUpRSpqzfyzX9NV+tGGPi8MJavq/pBd+wUGQfbf IYEA== X-Gm-Message-State: ALyK8tIpZZGfdvM7/ehPKtiEZXuSTn1LEV0md/zHZWuMR8B58yNeS4xFYUZk1TYYnC5BjlLNIWlRHNb0RaVE/fSb X-Received: by 10.157.38.141 with SMTP id l13mr6225028otb.193.1467225136504; Wed, 29 Jun 2016 11:32:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.100 with HTTP; Wed, 29 Jun 2016 11:32:15 -0700 (PDT) In-Reply-To: References: <5767F4E1.6020308@kingston.net> From: Harshal Dhumal Date: Thu, 30 Jun 2016 00:02:15 +0530 Message-ID: Subject: Re: Fix for issue RM1336 [pgadmin4] To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113d0efa118c3805366ef92c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113d0efa118c3805366ef92c Content-Type: multipart/alternative; boundary=001a113d0efa118c3405366ef92a --001a113d0efa118c3405366ef92a Content-Type: text/plain; charset=UTF-8 Hi, Here is updated patch for RM1336 Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show "About" dialog in runtime from Ctrl+Shift+A ----> Alt+Shift+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 29, 2016 at 11:41 PM, Dave Page wrote: > Hi > > On Wed, Jun 29, 2016 at 7:05 PM, Harshal Dhumal > wrote: > > Hi, > > > > PFA upadated patch for RM1336 > > > > Issue fixed: Query tool shortcuts weren't working on mac runtime. Also > > changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> > > Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about" > > dialog in runtime. > > Thanks - but let's change the runtime and go back to Ctrl+Shift+A in > the app. The About box in the runtime is really unimportant. > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113d0efa118c3405366ef92a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Here is updated patch for = RM1336

Fixed query tool shortcuts issue in Mac runtime a= nd changed shortcut to show "About" dialog in runtime from Ctrl+S= hift+A ----> Alt+Shift+A
--=C2= =A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0ht= tp://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company
=

On Wed, Jun 29, 2016 at 11:41 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 29, 2016 at 7:05 PM, Harshal Dhumal
<harshal.dhumal@enter= prisedb.com> wrote:
> Hi,
>
> PFA upadated patch for RM1336
>
> Issue fixed: Query tool shortcuts weren't working on mac runtime. = Also
> changed shortcut key for "Explain analyze" from Ctrl+Shift+A= --->
> Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show &quo= t;about"
> dialog in runtime.

Thanks - but let's change the runtime and go back to Ctrl+Shift+= A in
the app. The About box in the runtime is really unimportant.



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113d0efa118c3405366ef92a-- --001a113d0efa118c3805366ef92c Content-Type: text/x-patch; charset=US-ASCII; name="RM1336_V3.patch" Content-Disposition: attachment; filename="RM1336_V3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iq17vhc30 ZGlmZiAtLWdpdCBhL3J1bnRpbWUvQnJvd3NlcldpbmRvdy5jcHAgYi9ydW50 aW1lL0Jyb3dzZXJXaW5kb3cuY3BwCmluZGV4IDU0MTljMGUuLjY4NGNiMjcg MTAwNjQ0Ci0tLSBhL3J1bnRpbWUvQnJvd3NlcldpbmRvdy5jcHAKKysrIGIv cnVudGltZS9Ccm93c2VyV2luZG93LmNwcApAQCAtMTI1LDcgKzEyNSw3IEBA IHZvaWQgQnJvd3NlcldpbmRvdzo6Y3JlYXRlQWN0aW9ucygpCiAgICAgY29u bmVjdChleGl0U2hvcnRjdXQsIFNJR05BTChhY3RpdmF0ZWQoKSksIHRoaXMs IFNMT1QoY2xvc2UoKSkpOwogCiAgICAgLy8gQWJvdXQgYm94Ci0gICAgYWJv dXRTaG9ydGN1dCA9IG5ldyBRU2hvcnRjdXQoUUtleVNlcXVlbmNlKFF0OjpD VFJMICsgUXQ6OlNISUZUICsgUXQ6OktleV9BKSwgdGhpcyk7CisgICAgYWJv dXRTaG9ydGN1dCA9IG5ldyBRU2hvcnRjdXQoUUtleVNlcXVlbmNlKFF0OjpB TFQgKyBRdDo6U0hJRlQgKyBRdDo6S2V5X0EpLCB0aGlzKTsKICAgICBhYm91 dFNob3J0Y3V0LT5zZXRDb250ZXh0KFF0OjpBcHBsaWNhdGlvblNob3J0Y3V0 KTsKICAgICBjb25uZWN0KGFib3V0U2hvcnRjdXQsIFNJR05BTChhY3RpdmF0 ZWQoKSksIHRoaXMsIFNMT1QoYWJvdXQoKSkpOwogfQpkaWZmIC0tZ2l0IGEv d2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0 b3IvanMvc3FsZWRpdG9yLmpzIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRp dG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCmluZGV4 IDkyNTc5ZjEuLjJhMjY5YzAgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rv b2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRv ci5qcworKysgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxh dGVzL3NxbGVkaXRvci9qcy9zcWxlZGl0b3IuanMKQEAgLTE3Niw3ICsxNzYs NyBAQCBkZWZpbmUoCiAgICAgICAgICJjbGljayAjYnRuLWV4cGxhaW4tYnVm ZmVycyI6ICJvbl9leHBsYWluX2J1ZmZlcnMiLAogICAgICAgICAiY2xpY2sg I2J0bi1leHBsYWluLXRpbWluZyI6ICJvbl9leHBsYWluX3RpbWluZyIsCiAg ICAgICAgICJjaGFuZ2UgLmxpbWl0IjogIm9uX2xpbWl0X2NoYW5nZSIsCi0g ICAgICAgICJrZXl1cCI6ICJrZXlBY3Rpb24iCisgICAgICAgICJrZXlkb3du IjogImtleUFjdGlvbiIKICAgICAgIH0sCiAKICAgICAgIC8vIFRoaXMgZnVu Y3Rpb24gaXMgdXNlZCB0byByZW5kZXIgdGhlIHRlbXBsYXRlLgpAQCAtMTAy MCw3ICsxMDIwLDcgQEAgZGVmaW5lKAogICAgICAgICAgICAgLy8gY2hhciBl L0UKICAgICAgICAgICAgIC8vIEV4ZWN1dGUgcXVlcnkuCiAgICAgICAgICAg ICB0aGlzLm9uX2ZsYXNoKGV2KTsKLSAgICAgICAgICB9IGVsc2UgaWYoZXYu a2V5Q29kZSA9PSA4OCl7CisgICAgICAgICAgfSBlbHNlIGlmKGV2LmtleUNv ZGUgPT0gODgpIHsKICAgICAgICAgICAgIC8vIGNoYXIgeC9YCiAgICAgICAg ICAgICAvLyBFeHBsYWluIHF1ZXJ5LgogICAgICAgICAgICAgdGhpcy5vbl9l eHBsYWluKGV2KTsK --001a113d0efa118c3805366ef92c Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113d0efa118c3805366ef92c--