Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQWjO-00063q-P1 for pgadmin-hackers@arkaria.postgresql.org; Fri, 22 Jul 2016 09:26:54 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bQWjO-0006vr-AU for pgadmin-hackers@arkaria.postgresql.org; Fri, 22 Jul 2016 09:26:54 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bQWjA-0006ht-Vc for pgadmin-hackers@postgresql.org; Fri, 22 Jul 2016 09:26:41 +0000 Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bQWj7-00067u-C1 for pgadmin-hackers@postgresql.org; Fri, 22 Jul 2016 09:26:39 +0000 Received: by mail-oi0-x230.google.com with SMTP id w18so154977371oiw.3 for ; Fri, 22 Jul 2016 02:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3iQ++Sy+dmhXzEX0+pdeyWCTyrxQ6lYPbmlSZcyy8OE=; b=SURxG88GNi+A4lUZPJGndv8Nui5Y8MXL6n/vfZSVtBC8LN+MsWme2JozqSX1CSXqKc D21E7PJksXXS7WxPZXHRJmZFw4G/Ygo/+c5ABj+lcqAaq+T3ctRUlRAiT/7QcIubVHoZ 265MkH9JkVRA8jT9WHwWlabl+f5v5Cm7yxD9LbuzFLYXMQUjctRHunqOQw+mg1PA247Z 9c61+8IAdDL6+S7l/CewMqqDpv6uMA69yfotJKm4aNvGEnWe4bJY1WZ3Frz/IGEpli2H q5F9SBTpSw580wwrqDYERH6HD0a5ypm24nkQrg/ux1Ed6BsFxDR09mQEpAHTZCW2i3Ab zBiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3iQ++Sy+dmhXzEX0+pdeyWCTyrxQ6lYPbmlSZcyy8OE=; b=DiTapQirwBptEW8G6ek1N99hNg6SXo96H+/x4jKUGrCPDK9TMniw5DAgOH/VhGSTER cF4pxyg92frmnzZ5bF4kShiPxFyToz7Kc76a0GABAUvbaFPhA0JoXjKH2F5z+6A7AiGc 4AhAZBFptT5yEJuh6CjpT64ES5H4ofspjXnoj+q8x9nJcSk1/HShdk8aoYx2kKfbKitx pGvrkH6N+RbXVqGWw8uQURUnsyV6pUtVaCKG5BuKjxxqW7r5+b2wty/Euug1N8xv6QcG uk0r6yyTeDYZhLTI9Esge/7LQFYRXUEIUnLi2F2Y22rOhNgw/tvPnJmT+vjeHureVsbG wPZw== X-Gm-Message-State: AEkoousO8tzG/2otx5AslWgJ/D1/Xho4ttc7Ss6VkB3G3YT6OlLvIkjXWGarA682sOo7F5vdd/IG4bM7p49LHXlA X-Received: by 10.157.51.8 with SMTP id f8mr1519223otc.157.1469179596652; Fri, 22 Jul 2016 02:26:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.99 with HTTP; Fri, 22 Jul 2016 02:26:35 -0700 (PDT) In-Reply-To: References: From: Harshal Dhumal Date: Fri, 22 Jul 2016 14:56:35 +0530 Message-ID: Subject: Re: patch for RM1460 [pgAdmin4] To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1134f52cf8713e05383607ee X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1134f52cf8713e05383607ee Content-Type: multipart/alternative; boundary=001a1134f52cf8713705383607ec --001a1134f52cf8713705383607ec Content-Type: text/plain; charset=UTF-8 Hi, PFA attached patch to show save as option always and to show menu save option only when file is changed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 21, 2016 at 6:18 PM, Dave Page wrote: > Hi > > Works nicely - committed! > > One change I think we should make (please provide a patch when you get > a minute) is to always allow the dropdown menu and Save As to be used, > regardless of whether the file is dirty. Save should only be available > when there are changes of course. > > Thanks! > > On Wed, Jul 20, 2016 at 1:12 PM, Harshal Dhumal > wrote: > > Hi, > > > > PFA patch for RM1460 > > > > Changes: > > - Opening a file should set the tab name to the filename > > - Editing a file should add a * to the tab name to indicate the file is > > dirty > > - Saving changes to a file should clear the * > > - The Save button should have a drop-down menu, with a Save As option. > > > > -- > > Harshal Dhumal > > Software Engineer > > > > EnterpriseDB India: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1134f52cf8713705383607ec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA attached patch to show save as o= ption always and to show menu save option only when file is changed.

=
--=C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jul 21, 2016 at 6:18 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Hi

Works nicely - committed!

One change I think we should make (please provide a patch when you get
a minute) is to always allow the dropdown menu and Save As to be used,
regardless of whether the file is dirty. Save should only be available
when there are changes of course.

Thanks!

On Wed, Jul 20, 2016 at 1:12 PM, Harshal Dhumal
<harshal.dhumal@enter= prisedb.com> wrote:
> Hi,
>
> PFA patch for RM1460
>
> Changes:
> - Opening a file should set the tab name to the filename
> - Editing a file should add a * to the tab name to indicate the file i= s
> dirty
> - Saving changes to a file should clear the *
> - The Save button should have a drop-down menu, with a Save As option.=
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1134f52cf8713705383607ec-- --001a1134f52cf8713e05383607ee Content-Type: text/x-patch; charset=US-ASCII; name="RM1460_enhancement.patch" Content-Disposition: attachment; filename="RM1460_enhancement.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqxjkm440 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZW1w bGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWlu L3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVk aXRvci5qcwppbmRleCA2ZGIyMzEwLi44OTYxYzU1IDEwMDY0NAotLS0gYS93 ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRv ci9qcy9zcWxlZGl0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3Fs ZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCkBA IC0yMDY1LDcgKzIwNjUsNyBAQCBkZWZpbmUoCiAgICAgICAgICAgICAgICAg c2VsZi5zZXRUaXRsZShzZWxmLmdyaWRWaWV3LmN1cnJlbnRfZmlsZS5yZXBs YWNlKC9eXC98XC8kL2csICcnKSk7CiAgICAgICAgICAgICAgICAgLy8gZGlz YWJsZSBzYXZlIGJ1dHRvbiBvbiBmaWxlIHNhdmUKICAgICAgICAgICAgICAg ICAkKCIjYnRuLXNhdmUiKS5wcm9wKCdkaXNhYmxlZCcsIHRydWUpOwotICAg ICAgICAgICAgICAgICQoIiNidG4tZmlsZS1tZW51LWRyb3Bkb3duIikucHJv cCgnZGlzYWJsZWQnLCB0cnVlKTsKKyAgICAgICAgICAgICAgICAkKCIjYnRu LWZpbGUtbWVudS1zYXZlIikuY3NzKCdkaXNwbGF5JywgJ25vbmUnKTsKICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgfSwKICAgICAgICAgICAgIGVy cm9yOiBmdW5jdGlvbihlKSB7CkBAIC0yMDgwLDYgKzIwODAsNyBAQCBkZWZp bmUoCiAgICAgICAgICAgdmFyIHNlbGYgPSB0aGlzOwogICAgICAgICAgIGlm KHF1ZXJ5X3Rvb2xfb2JqLmdldFZhbHVlKCkubGVuZ3RoID09IDApIHsKICAg ICAgICAgICAgICQoIiNidG4tc2F2ZSIpLnByb3AoJ2Rpc2FibGVkJywgdHJ1 ZSk7CisgICAgICAgICAgICAkKCIjYnRuLWZpbGUtbWVudS1zYXZlIikuY3Nz KCdkaXNwbGF5JywgJ25vbmUnKTsKICAgICAgICAgICAgICQoIiNidG4tZmls ZS1tZW51LWRyb3Bkb3duIikucHJvcCgnZGlzYWJsZWQnLCB0cnVlKTsKICAg ICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgaWYoc2VsZi5ncmlkVmll dy5jdXJyZW50X2ZpbGUpIHsKQEAgLTIwODcsNiArMjA4OCw3IEBAIGRlZmlu ZSgKICAgICAgICAgICAgICAgc2VsZi5zZXRUaXRsZSh0aXRsZSk7CiAgICAg ICAgICAgICB9CiAgICAgICAgICAgICAkKCIjYnRuLXNhdmUiKS5wcm9wKCdk aXNhYmxlZCcsIGZhbHNlKTsKKyAgICAgICAgICAgICQoIiNidG4tZmlsZS1t ZW51LXNhdmUiKS5jc3MoJ2Rpc3BsYXknLCAnYmxvY2snKTsKICAgICAgICAg ICAgICQoIiNidG4tZmlsZS1tZW51LWRyb3Bkb3duIikucHJvcCgnZGlzYWJs ZWQnLCBmYWxzZSk7CiAgICAgICAgICAgfQogICAgICAgICB9LAo= --001a1134f52cf8713e05383607ee Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1134f52cf8713e05383607ee--