Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL391-0000ci-4E for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 06:50:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bL390-0007zd-KQ for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 06:50:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bL38n-0007lk-IJ for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 06:50:29 +0000 Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bL38j-000273-HC for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 06:50:28 +0000 Received: by mail-oi0-x230.google.com with SMTP id f189so11659453oig.3 for ; Wed, 06 Jul 2016 23:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EKp9lCCwsYQmKkQ+W02+2Ibzv6FjZ9sukdArwLgA7A0=; b=MyRDpNq58x80DMYQLADVVBvP0FrmRUG+NysVTnddxqyJB5G4WyJjyCCFRPUBPAoX5x 38sRXBrVWzgqjL7ZMD42/AxX6sXh76lvbBc2QK+E8lvma2gttKJ4weFm5AMi+5ZZ6ebB EQ+UbkIeIyw043mHq/xk0A3bvlWsxzOYkJ5AweoBbPQth0YQla45JLu9pHytnAvKi1DY eCd7z6donTBSa4B4NGzaT889kLx/HcOXCXFuN5jAGgnpZuZPWfklAQTTIdOoscS7zB+Z zBr4rZ8OWkIXZjKC0Cc7p4lz70ePKCZhGBe+5KalvC780xF3c3r/1qoK1brvST9C0Xoq kwVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EKp9lCCwsYQmKkQ+W02+2Ibzv6FjZ9sukdArwLgA7A0=; b=dZUeQ2yeHBVQcvg3S7b6yotYBKp48be7abLaExMAfReVxBjwh00gI0WRqXaJuvkuaX WaEplqtGgdl2RT3Dk71QwHf/O7bQsrrfzDTRIgQ1WlsvXgssqAywMbXqh+C6OQnBUy8a NsVqn0QheR8rXBoerUEAFTdsxlxSSP0xeFUDb9QFHYgRxdSQiGo+tzCmqJcApRM+pp90 XDM8D5m07OsjJIbI4MiF5ZxyBTVY8WxsM5NwWyZgcpvBgsNVYY6TcqWIHRjrdbOT0HgD xlz3DYXT070LBwUqyfMT/UzHK5xTaIvm6nSjoEqBsX80qCH/B92usDCdjWoKXUhssuRx 3NGg== X-Gm-Message-State: ALyK8tIkRwbCbK649gDG+R9bdFjp2IAib8FRLfkFjMVOGc54ZxLKdmLVhiE7JQYaKW3/VOSvYHl1Im/OLQSGfH3m X-Received: by 10.157.19.98 with SMTP id q31mr4889643otq.125.1467874223392; Wed, 06 Jul 2016 23:50:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.100 with HTTP; Wed, 6 Jul 2016 23:50:22 -0700 (PDT) In-Reply-To: References: From: Harshal Dhumal Date: Thu, 7 Jul 2016 12:20:22 +0530 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: Ashesh Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1135177aa92055053706198d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1135177aa92055053706198d Content-Type: text/plain; charset=UTF-8 Hi, By mistake I deleted a line which was not supposed to be deleted, and that line of code was initialization of select2. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi wrote: > Hi Harshal, > > Can you please explain - what was missing in the last patch? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> PFA updated patch for issue RM1260 >> >> -- >> *Harshal Dhumal* >> *Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> Please ignore this patch as this has some minor issue. I'll sent updated >>> one. >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA patch for issue RM1260. >>>> >>>> Changes: Issue wasn't related to foreign table but was due the Select2 >>>> control. Now I have improved select2 control to handle null value in >>>> multi-select mode. Initial it was returning "null" instead it should return >>>> [] (empty array). >>>> >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --001a1135177aa92055053706198d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

By mistake I deleted a line which wa= s not supposed to be deleted, and that line of code was initialization of s= elect2.

=
--=C2=A0
Harshal Dhuma= l
Software Engineer


On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,

= Can you please explain - what was missing in the last patch?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 a= t 12:12 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com<= /a>> wrote:
Hi,

PFA updated patch fo= r issue RM1260

=
On Thu, Jul 7, 2016 at 12:04 PM= , Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Plea= se ignore this patch as this has some minor issue. I'll sent updated on= e.

<= div>
--=C2=A0
Harshal Dhumal
Soft= ware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA patch for issue RM1260.

Changes: Issue w= asn't related to foreign table but was due the Select2 control. Now I h= ave improved select2 control to handle null value in multi-select mode. Ini= tial it was returning "null" instead it should return [] (empty a= rray).


--=C2=A0
Harshal Dhumal
=
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=



--001a1135177aa92055053706198d--